Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dhcp
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 109
    • Issues 109
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • dhcp
  • Issues
  • #184

Closed
Open
Created Apr 25, 2021 by Foster Snowhill@forst

[PATCH] relay: fix IPv6 multicast address in documentation

From e6ca44a168b5ae07cb2b6d7aa9c7548eaf82b7ff Mon Sep 17 00:00:00 2001
From: Foster Snowhill <2516-forst@users.noreply.gitlab.isc.org>
Date: Sun, 25 Apr 2021 15:23:16 +0200
Subject: [PATCH] relay: fix IPv6 multicast address in documentation

In the dhcrelay source code, parse_upstream() function by default defines the
destination address to be the All_DHCP_Servers multicast group (ff05::1:3).

However, the documentation says that it uses All_DHCP_Relay_Agents_and_Servers
(ff02::1:2). This is inconsisent with the implementation.

This commit fixes the documentation to also specify All_DHCP_Servers as the
default multicast group.
---
 relay/dhcrelay.8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/relay/dhcrelay.8 b/relay/dhcrelay.8
index 53cd28bf..10ebfe3d 100644
--- a/relay/dhcrelay.8
+++ b/relay/dhcrelay.8
@@ -325,7 +325,7 @@ forwarded.  At least one \fB-u\fR option must be included in the command
 line when running in DHCPv6 mode.  The interface name \fIifname\fR is a
 mandatory parameter. The destination unicast or multicast address can be
 specified by \fIaddress%\fR; if not specified, the relay agent will forward
-to the DHCPv6 \fIAll_DHCP_Relay_Agents_and_Servers\fR multicast address.
+to the DHCPv6 \fIAll_DHCP_Servers\fR multicast address.
 .PP
 It is possible to specify the same interface with different addresses
 more than once, and even, when the system supports it, to use the same
-- 
2.31.1


This patch is against master (commit 79110e52).

For reference, the relevant line in parse_upstream() function: https://gitlab.isc.org/isc-projects/dhcp/-/blob/79110e525e0584d195327d31f4ee67e6a5e2fe7a/relay/dhcrelay.c#L1532

If possible, can I also please get a project allocation, so that in the future I can submit proper merge requests? Thanks!

Edited Apr 25, 2021 by Foster Snowhill
Assignee
Assign to
Time tracking