dhclient: wrong argument to memcpy
Affects 79110e52, affects dhcp-4.4.2.
client/dhclient.c:3384: memcpy(&client_identifier.buffer->data + 5 - hw_len,
client/dhclient.c:3389: memcpy(&client_identifier.buffer->data+(1+4),
These two lines look wrong. data is of type char[1] and its equivalent pointer would be char*. You would not want to take the address again, as the type of that (char**) leads to a different effect when adding +5.
The lines should be
client/dhclient.c:3384: memcpy(client_identifier.buffer->data + 5 - hw_len,
client/dhclient.c:3389: memcpy(client_identifier.buffer->data+(1+4),
If the source had declared unsigned char data[]
instead of unsigend char data[1]
, this would have been caught.