Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dhcp
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 64
    • Issues 64
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 16
    • Merge Requests 16
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • dhcp
  • Issues
  • #74

Closed
Open
Opened Jan 09, 2020 by ssbertilson@ssbertilson

please enhance DHCP logging for "peer holds all free leases"

name: Feature request
about: Suggest an idea for this project

Some initial questions

  • Are you sure your feature is not already implemented in the latest ISC DHCP version? Not in 4.4.2b1
  • Are you sure your feature is not already implemented in the latest Kea version? Can't easily tell (message not similar enough to quickly find)
  • Are you sure what you would like to do is not possible using some other mechanisms? Yes
  • Have you discussed your idea on dhcp-users or dhcp-workers mailing lists? No since it is such a trivial change

Describe the solution you'd like In server/dhcp.c I'd like to see this change: --- dhcp.c.orig 2019-12-17 13:13:31.000000000 -0600 +++ - 2020-01-09 08:50:16.350350969 -0600 @@ -391,18 +391,19 @@ #endif

    /* If we didn't find a lease, try to allocate one... */
    if (!lease) {
            if (!allocate_lease (&lease, packet,
                                 packet -> shared_network -> pools,
                                 &peer_has_leases)) {
                    if (peer_has_leases)
  •                           log_error ("%s: peer holds all free leases",
  •                                      msgbuf);
  •                           log_error ("%s: network %s: peer holds all free leases",
  •                                      msgbuf,
  •                                      packet -> shared_network -> name);
                      else
                              log_error ("%s: network %s: no free leases",
                                         msgbuf,
                                         packet -> shared_network -> name);
                      return;
              }
      }
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: isc-projects/dhcp#74