Noticed that in 1.9.7 in v6, only the first DHCPREQUEST was getting logged, the subsequent ones weren't. As opposed to DHCPRENEWs which where logged. So the main intended change in this MR was to:
- send multiple DHCPREQUESTs
- check that they are all logged which is now true for master.
Other changes that make it work with master:
- space added:
Address:3000::5->Address: 3000::5 -
"has been renewed"is now logged as"has been assigned"- kea#1868 addresses this, for the time being the test caters to the current behavior
Other changes:
- deduplicated code in some helper functions
- added missing check at the end of
"test_v6_legal_log_address_assigned_duid" -
"test_v4_legal_log_assigned_address_via_relay_pgsql_1"was not about postgres, renamed it to"test_v4_legal_log_assigned_address_via_relay_one_address" - added missing relay pytest marks
- any test that doesn't have "relay" in the name no longer uses relayed packets
- check the whole line once instead of checking parts of it multiple times
- there was no order of tests, mysql and pgsql orders were mixed, i ordered them by file -> mysql -> pgsql
- renamed
"test_v6_loggers_legal_log_hook_*"to"test_v6_legal_log_*"for consistency with the v4 counterparts and for shorter names - maybe some others... huge sorry for the big changes