Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • forge forge
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • forgeforge
  • Merge requests
  • !251

centralize converting options to codes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andrei Pavel requested to merge option-codes into master Feb 16, 2022
  • Overview 3
  • Commits 1
  • Pipelines 4
  • Changes 2

There are two ways to reference options in forge code. By code and by name. All functions that work with options work with codes, but not all of them work with names. This MR enables all options that work with codes to also work with names so that we don't have to remember option codes. It does so by moving the conversion from name to code as low as possible in the call stack. Another problem it solves is the different ways in which the conversion is done. For example, sometimes an option code is checked if it's a number in string format with isdigit(), other times it isn't.

Test run shows 49 test failures. The extra test is test_hook_v4_subnet_grow_cb_command[socket] and it seems intermittent. https://jenkins.aws.isc.org/view/Kea-manual/job/kea-manual/job/tarball-system-tests/63/

Edited Feb 18, 2022 by Andrei Pavel
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: option-codes