Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • forge forge
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • forgeforge
  • Merge requests
  • !360

prevent the same logger from being configured twice

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Andrei Pavel requested to merge loggers into master Mar 08, 2023
  • Overview 1
  • Commits 1
  • Pipelines 5
  • Changes 2

Forge sometimes gets itself into a situation where the same logger is defined twice in Kea. It would be nice if we could avoid that in the majority of tests.

For example, if you run test_radius[v6-radius-reservation-outside-pool-network-memfile], it will run:

  • setup_server_with_radius(**configs[config_type])
  • srv_control.build_and_send_config_files()

Both those calls add loggers, and the general logger gets added each time, for a total of two.

$ diff tests_results/test_radius_v6-radius-reservation-outside-pool-network-memfile_/kea-dhcp6.conf*
         "loggers": [
             {
                 "name": "kea-dhcp6",
                 "output_options": [
                     {
                         "output": "/opt/kea/var/log/kea.log",
                         "flush": true,
                         "maxsize": 10240000,
                         "maxver": 1,
                         "pattern": ""
                     }
                 ],
                 "debuglevel": 99,
                 "severity": "DEBUG"
+            },
+            {
+                "name": "kea-dhcp6",
+                "output_options": [
+                    {
+                        "output": "/opt/kea/var/log/kea.log"
+                    }
+                ],
+                "severity": "DEBUG",
+                "debuglevel": 99
             }
         ],

I think we don't want this behavior by default. If anything, testing two loggers with the same name should be an individual separate test.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: loggers