dhcp4_srv_unittest.cc 45.9 KB
Newer Older
Tomek Mrugalski's avatar
Tomek Mrugalski committed
1
// Copyright (C) 2011-2013  Internet Systems Consortium, Inc. ("ISC")
2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND ISC DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS.  IN NO EVENT SHALL ISC BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE
// OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.

#include <config.h>
#include <sstream>

18
#include <asiolink/io_address.h>
19 20
#include <dhcp/dhcp4.h>
#include <dhcp/option.h>
21
#include <dhcp/option4_addrlst.h>
22
#include <dhcp/option_custom.h>
23
#include <dhcp/option_int_array.h>
24
#include <dhcp4/dhcp4_srv.h>
Tomek Mrugalski's avatar
Tomek Mrugalski committed
25
#include <dhcp4/dhcp4_log.h>
26 27 28 29
#include <dhcpsrv/cfgmgr.h>
#include <dhcpsrv/lease_mgr.h>
#include <dhcpsrv/lease_mgr_factory.h>
#include <dhcpsrv/utils.h>
30 31 32 33 34 35
#include <gtest/gtest.h>

#include <fstream>
#include <iostream>

#include <arpa/inet.h>
36 37 38 39

using namespace std;
using namespace isc;
using namespace isc::dhcp;
40
using namespace isc::asiolink;
41 42 43 44

namespace {

class NakedDhcpv4Srv: public Dhcpv4Srv {
45
    // "Naked" DHCPv4 server, exposes internal fields
46
public:
47 48 49 50 51 52 53 54
    NakedDhcpv4Srv(uint16_t port = 0):Dhcpv4Srv(port) { }

    using Dhcpv4Srv::processDiscover;
    using Dhcpv4Srv::processRequest;
    using Dhcpv4Srv::processRelease;
    using Dhcpv4Srv::processDecline;
    using Dhcpv4Srv::processInform;
    using Dhcpv4Srv::getServerID;
55 56 57
    using Dhcpv4Srv::loadServerID;
    using Dhcpv4Srv::generateServerID;
    using Dhcpv4Srv::writeServerID;
58
    using Dhcpv4Srv::sanityCheck;
59
    using Dhcpv4Srv::srvidToString;
60 61
};

62 63
static const char* SRVID_FILE = "server-id-test.txt";

64 65
class Dhcpv4SrvTest : public ::testing::Test {
public:
66 67 68 69 70

    /// @brief Constructor
    ///
    /// Initializes common objects used in many tests.
    /// Also sets up initial configuration in CfgMgr.
71
    Dhcpv4SrvTest() {
72 73 74 75 76 77 78
        subnet_ = Subnet4Ptr(new Subnet4(IOAddress("192.0.2.0"), 24, 1000,
                                         2000, 3000));
        pool_ = Pool4Ptr(new Pool4(IOAddress("192.0.2.100"), IOAddress("192.0.2.110")));
        subnet_->addPool(pool_);

        CfgMgr::instance().deleteSubnets4();
        CfgMgr::instance().addSubnet4(subnet_);
79

80 81 82 83
        // Add Router option.
        Option4AddrLstPtr opt_routers(new Option4AddrLst(DHO_ROUTERS));
        opt_routers->setAddress(IOAddress("192.0.2.2"));
        subnet_->addOption(opt_routers, false, "dhcp4");
84

85 86
        // it's ok if that fails. There should not be such a file anyway
        unlink(SRVID_FILE);
87
    }
88

89
    /// @brief Add 'Parameter Request List' option to the packet.
90
    ///
91
    /// This function PRL option comprising the following option codes:
92 93 94 95 96 97 98 99 100 101 102 103 104 105
    /// - 5 - Name Server
    /// - 15 - Domain Name
    /// - 7 - Log Server
    /// - 8 - Quotes Server
    /// - 9 - LPR Server
    ///
    /// @param pkt packet to add PRL option to.
    void addPrlOption(Pkt4Ptr& pkt) {

        OptionUint8ArrayPtr option_prl =
            OptionUint8ArrayPtr(new OptionUint8Array(Option::V4,
                                                     DHO_DHCP_PARAMETER_REQUEST_LIST));

        // Let's request options that have been configured for the subnet.
106 107 108 109
        option_prl->addValue(DHO_DOMAIN_NAME_SERVERS);
        option_prl->addValue(DHO_DOMAIN_NAME);
        option_prl->addValue(DHO_LOG_SERVERS);
        option_prl->addValue(DHO_COOKIE_SERVERS);
110 111
        // Let's also request the option that hasn't been configured. In such
        // case server should ignore request for this particular option.
112
        option_prl->addValue(DHO_LPR_SERVERS);
113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151
        // And add 'Parameter Request List' option into the DISCOVER packet.
        pkt->addOption(option_prl);
    }

    /// @brief Configures options being requested in the PRL option.
    ///
    /// The lpr-servers option is NOT configured here altough it is
    /// added to the 'Parameter Request List' option in the
    /// \ref addPrlOption. When requested option is not configured
    /// the server should not return it in its rensponse. The goal
    /// of not configuring the requested option is to verify that
    /// the server will not return it.
    void configureRequestedOptions() {
        // dns-servers
        Option4AddrLstPtr
            option_dns_servers(new Option4AddrLst(DHO_DOMAIN_NAME_SERVERS));
        option_dns_servers->addAddress(IOAddress("192.0.2.1"));
        option_dns_servers->addAddress(IOAddress("192.0.2.100"));
        ASSERT_NO_THROW(subnet_->addOption(option_dns_servers, false, "dhcp4"));

        // domain-name
        OptionDefinition def("domain-name", DHO_DOMAIN_NAME, OPT_FQDN_TYPE);
        boost::shared_ptr<OptionCustom>
            option_domain_name(new OptionCustom(def, Option::V4));
        option_domain_name->writeFqdn("example.com");
        subnet_->addOption(option_domain_name, false, "dhcp4");

        // log-servers
        Option4AddrLstPtr option_log_servers(new Option4AddrLst(DHO_LOG_SERVERS));
        option_log_servers->addAddress(IOAddress("192.0.2.2"));
        option_log_servers->addAddress(IOAddress("192.0.2.10"));
        ASSERT_NO_THROW(subnet_->addOption(option_log_servers, false, "dhcp4"));

        // cookie-servers
        Option4AddrLstPtr option_cookie_servers(new Option4AddrLst(DHO_COOKIE_SERVERS));
        option_cookie_servers->addAddress(IOAddress("192.0.2.1"));
        ASSERT_NO_THROW(subnet_->addOption(option_cookie_servers, false, "dhcp4"));
    }

152 153 154
    /// @brief checks that the response matches request
    /// @param q query (client's message)
    /// @param a answer (server's message)
155
    void messageCheck(const boost::shared_ptr<Pkt4>& q,
156 157 158 159 160 161 162 163 164
                      const boost::shared_ptr<Pkt4>& a) {
        ASSERT_TRUE(q);
        ASSERT_TRUE(a);

        EXPECT_EQ(q->getHops(),   a->getHops());
        EXPECT_EQ(q->getIface(),  a->getIface());
        EXPECT_EQ(q->getIndex(),  a->getIndex());
        EXPECT_EQ(q->getGiaddr(), a->getGiaddr());

165 166 167
        // Check that bare minimum of required options are there.
        // We don't check options requested by a client. Those
        // are checked elsewhere.
168 169 170 171 172 173
        EXPECT_TRUE(a->getOption(DHO_SUBNET_MASK));
        EXPECT_TRUE(a->getOption(DHO_ROUTERS));
        EXPECT_TRUE(a->getOption(DHO_DHCP_SERVER_IDENTIFIER));
        EXPECT_TRUE(a->getOption(DHO_DHCP_LEASE_TIME));
        EXPECT_TRUE(a->getOption(DHO_SUBNET_MASK));

174
        // Check that something is offered
175 176 177
        EXPECT_TRUE(a->getYiaddr().toText() != "0.0.0.0");
    }

178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198
    /// @brief Check that requested options are present.
    ///
    /// @param pkt packet to be checked.
    void optionsCheck(const Pkt4Ptr& pkt) {
        // Check that the requested and configured options are returned
        // in the ACK message.
        EXPECT_TRUE(pkt->getOption(DHO_DOMAIN_NAME))
            << "domain-name not present in the response";
        EXPECT_TRUE(pkt->getOption(DHO_DOMAIN_NAME_SERVERS))
            << "dns-servers not present in the response";
        EXPECT_TRUE(pkt->getOption(DHO_LOG_SERVERS))
            << "log-servers not present in the response";
        EXPECT_TRUE(pkt->getOption(DHO_COOKIE_SERVERS))
            << "cookie-servers not present in the response";
        // Check that the requested but not configured options are not
        // returned in the ACK message.
        EXPECT_FALSE(pkt->getOption(DHO_LPR_SERVERS))
            << "domain-name present in the response but it is"
            << " expected not to be present";
    }

199 200 201 202 203 204 205 206
    /// @brief generates client-id option
    ///
    /// Generate client-id option of specified length
    /// Ids with different lengths are sufficent to generate
    /// unique ids. If more fine grained control is required,
    /// tests generate client-ids on their own.
    /// Sets client_id_ field.
    /// @param size size of the client-id to be generated
207 208 209 210 211 212 213 214 215 216 217 218 219 220
    OptionPtr generateClientId(size_t size = 4) {

        OptionBuffer clnt_id(size);
        for (int i = 0; i < size; i++) {
            clnt_id[i] = 100 + i;
        }

        client_id_ = ClientIdPtr(new ClientId(clnt_id));

        return (OptionPtr(new Option(Option::V4, DHO_DHCP_CLIENT_IDENTIFIER,
                                     clnt_id.begin(),
                                     clnt_id.begin() + size)));
    }

221 222 223 224
    /// @brief generate hardware address
    ///
    /// @param size size of the generated MAC address
    /// @param pointer to Hardware Address object
Tomek Mrugalski's avatar
Tomek Mrugalski committed
225
    HWAddrPtr generateHWAddr(size_t size = 6) {
226
        const uint8_t hw_type = 123; // Just a fake number (typically 6=HTYPE_ETHER, see dhcp4.h)
Tomek Mrugalski's avatar
Tomek Mrugalski committed
227 228 229 230 231 232 233
        OptionBuffer mac(size);
        for (int i = 0; i < size; ++i) {
            mac[i] = 50 + i;
        }
        return (HWAddrPtr(new HWAddr(mac, hw_type)));
    }

234 235 236
    /// Check that address was returned from proper range, that its lease
    /// lifetime is correct, that T1 and T2 are returned properly
    /// @param rsp response to be checked
237 238
    /// @param subnet subnet that should be used to verify assigned address
    ///        and options
239 240
    /// @param t1_mandatory is T1 mandatory?
    /// @param t2_mandatory is T2 mandatory?
241
    void checkAddressParams(const Pkt4Ptr& rsp, const SubnetPtr subnet,
242 243
                            bool t1_mandatory = false,
                            bool t2_mandatory = false) {
244 245 246 247 248 249 250

        // Technically inPool implies inRange, but let's be on the safe
        // side and check both.
        EXPECT_TRUE(subnet->inRange(rsp->getYiaddr()));
        EXPECT_TRUE(subnet->inPool(rsp->getYiaddr()));

        // Check lease time
251 252
        OptionPtr opt = rsp->getOption(DHO_DHCP_LEASE_TIME);
        if (!opt) {
253 254
            ADD_FAILURE() << "Lease time option missing in response";
        } else {
255
            EXPECT_EQ(opt->getUint32(), subnet->getValid());
256 257 258
        }

        // Check T1 timer
259 260 261
        opt = rsp->getOption(DHO_DHCP_RENEWAL_TIME);
        if (opt) {
            EXPECT_EQ(opt->getUint32(), subnet->getT1());
262 263 264 265 266 267 268
        } else {
            if (t1_mandatory) {
                ADD_FAILURE() << "Required T1 option missing";
            }
        }

        // Check T2 timer
269 270 271
        opt = rsp->getOption(DHO_DHCP_REBINDING_TIME);
        if (opt) {
            EXPECT_EQ(opt->getUint32(), subnet->getT2());
272
        } else {
273
            if (t2_mandatory) {
274 275 276 277 278
                ADD_FAILURE() << "Required T2 option missing";
            }
        }
    }

279 280 281 282 283
    /// @brief Basic checks for generated response (message type and trans-id).
    ///
    /// @param rsp response packet to be validated
    /// @param expected_message_type expected message type
    /// @param expected_transid expected transaction-id
284 285 286 287 288 289 290
    void checkResponse(const Pkt4Ptr& rsp, uint8_t expected_message_type,
                       uint32_t expected_transid) {
        ASSERT_TRUE(rsp);
        EXPECT_EQ(expected_message_type, rsp->getType());
        EXPECT_EQ(expected_transid, rsp->getTransid());
    }

291 292 293 294 295 296
    /// @brief Checks if the lease sent to client is present in the database
    ///
    /// @param rsp response packet to be validated
    /// @param client_id expected client-identifier (or NULL)
    /// @param HWAddr expected hardware address (not used now)
    /// @param expected_addr expected address
297
    Lease4Ptr checkLease(const Pkt4Ptr& rsp, const OptionPtr& client_id,
298
                         const HWAddrPtr&, const IOAddress& expected_addr) {
299 300 301 302 303 304 305 306 307 308 309 310 311 312

        ClientIdPtr id;
        if (client_id) {
            OptionBuffer data = client_id->getData();
            id.reset(new ClientId(data));
        }

        Lease4Ptr lease = LeaseMgrFactory::instance().getLease4(expected_addr);
        if (!lease) {
            cout << "Lease for " << expected_addr.toText()
                 << " not found in the database backend.";
            return (Lease4Ptr());
        }

313 314
        EXPECT_EQ(rsp->getYiaddr().toText(), expected_addr.toText());

315 316 317 318 319 320 321 322 323
        EXPECT_EQ(expected_addr.toText(), lease->addr_.toText());
        if (client_id) {
            EXPECT_TRUE(*lease->client_id_ == *id);
        }
        EXPECT_EQ(subnet_->getID(), lease->subnet_id_);

        return (lease);
    }

324 325 326
    /// @brief Checks if server response (OFFER, ACK, NAK) includes proper server-id
    /// @param rsp response packet to be validated
    /// @param expected_srvid expected value of server-id
327
    void checkServerId(const Pkt4Ptr& rsp, const OptionPtr& expected_srvid) {
328 329 330 331 332 333
        // Check that server included its server-id
        OptionPtr opt = rsp->getOption(DHO_DHCP_SERVER_IDENTIFIER);
        ASSERT_TRUE(opt);
        EXPECT_EQ(opt->getType(), expected_srvid->getType() );
        EXPECT_EQ(opt->len(), expected_srvid->len() );
        EXPECT_TRUE(opt->getData() == expected_srvid->getData());
334 335
    }

336 337 338
    /// @brief Checks if server response (OFFER, ACK, NAK) includes proper client-id
    /// @param rsp response packet to be validated
    /// @param expected_clientid expected value of client-id
339 340
    void checkClientId(const Pkt4Ptr& rsp, const OptionPtr& expected_clientid) {
        // check that server included our own client-id
341 342 343 344 345
        OptionPtr opt = rsp->getOption(DHO_DHCP_CLIENT_IDENTIFIER);
        ASSERT_TRUE(opt);
        EXPECT_EQ(expected_clientid->getType(), opt->getType());
        EXPECT_EQ(expected_clientid->len(), opt->len());
        EXPECT_TRUE(expected_clientid->getData() == opt->getData());
346 347
    }

348
    ~Dhcpv4SrvTest() {
349
        CfgMgr::instance().deleteSubnets4();
350 351 352

        // Let's clean up if there is such a file.
        unlink(SRVID_FILE);
353
    };
354

355
    /// @brief A subnet used in most tests
356 357
    Subnet4Ptr subnet_;

358
    /// @brief A pool used in most tests
359 360
    Pool4Ptr pool_;

361
    /// @brief A client-id used in most tests
362
    ClientIdPtr client_id_;
363 364
};

Tomek Mrugalski's avatar
Tomek Mrugalski committed
365 366
// Sanity check. Verifies that both Dhcpv4Srv and its derived
// class NakedDhcpv4Srv can be instantiated and destroyed.
367 368
TEST_F(Dhcpv4SrvTest, basic) {

369
    // Check that the base class can be instantiated
370
    Dhcpv4Srv* srv = NULL;
371
    ASSERT_NO_THROW({
Tomek Mrugalski's avatar
Tomek Mrugalski committed
372
        srv = new Dhcpv4Srv(DHCP4_SERVER_PORT + 10000);
373
    });
374 375
    delete srv;

376
    // Check that the derived class can be instantiated
377 378 379 380 381
    NakedDhcpv4Srv* naked_srv = NULL;
    ASSERT_NO_THROW({
        naked_srv = new NakedDhcpv4Srv(DHCP4_SERVER_PORT + 10000);
    });
    EXPECT_TRUE(naked_srv->getServerID());
382
    delete naked_srv;
383 384 385 386 387

    ASSERT_NO_THROW({
        naked_srv = new NakedDhcpv4Srv(0);
    });
    EXPECT_TRUE(naked_srv->getServerID());
388

Tomek Mrugalski's avatar
Tomek Mrugalski committed
389
    delete naked_srv;
390 391
}

Tomek Mrugalski's avatar
Tomek Mrugalski committed
392 393 394 395 396 397 398 399
// Verifies that received DISCOVER can be processed correctly,
// that the OFFER message generated in response is valid and
// contains necessary options.
//
// Note: this test focuses on the packet correctness. There
// are other tests that verify correctness of the allocation
// engine. See DiscoverBasic, DiscoverHint, DiscoverNoClientId
// and DiscoverInvalidHint.
400
TEST_F(Dhcpv4SrvTest, processDiscover) {
401
    NakedDhcpv4Srv* srv = new NakedDhcpv4Srv(0);
Tomek Mrugalski's avatar
Tomek Mrugalski committed
402
    vector<uint8_t> mac(6);
403 404 405
    for (int i = 0; i < 6; i++) {
        mac[i] = 255 - i;
    }
406 407

    boost::shared_ptr<Pkt4> pkt(new Pkt4(DHCPDISCOVER, 1234));
408 409 410 411 412 413 414 415
    boost::shared_ptr<Pkt4> offer;

    pkt->setIface("eth0");
    pkt->setIndex(17);
    pkt->setHWAddr(1, 6, mac);
    pkt->setRemoteAddr(IOAddress("192.0.2.56"));
    pkt->setGiaddr(IOAddress("192.0.2.67"));

Tomek Mrugalski's avatar
Tomek Mrugalski committed
416
    // Let's make it a relayed message
417 418
    pkt->setHops(3);
    pkt->setRemotePort(DHCP4_SERVER_PORT);
419

420
    // We are going to test that certain options are returned
421 422 423 424
    // (or not returned) in the OFFER message when requested
    // using 'Parameter Request List' option. Let's configure
    // those options that are returned when requested.
    configureRequestedOptions();
425

Tomek Mrugalski's avatar
Tomek Mrugalski committed
426
    // Should not throw
427
    EXPECT_NO_THROW(
428
        offer = srv->processDiscover(pkt);
429 430
    );

Tomek Mrugalski's avatar
Tomek Mrugalski committed
431
    // Should return something
432 433 434 435
    ASSERT_TRUE(offer);

    EXPECT_EQ(DHCPOFFER, offer->getType());

Tomek Mrugalski's avatar
Tomek Mrugalski committed
436
    // This is relayed message. It should be sent back to relay address.
437 438
    EXPECT_EQ(pkt->getGiaddr(), offer->getRemoteAddr());

439
    messageCheck(pkt, offer);
440

441 442 443 444 445
    // There are some options that are always present in the
    // message, even if not requested.
    EXPECT_TRUE(offer->getOption(DHO_DOMAIN_NAME));
    EXPECT_TRUE(offer->getOption(DHO_DOMAIN_NAME_SERVERS));

446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471
    // We did not request any options so they should not be present
    // in the OFFER.
    EXPECT_FALSE(offer->getOption(DHO_LOG_SERVERS));
    EXPECT_FALSE(offer->getOption(DHO_COOKIE_SERVERS));
    EXPECT_FALSE(offer->getOption(DHO_LPR_SERVERS));

    // Add 'Parameter Request List' option.
    addPrlOption(pkt);

    // Now repeat the test but request some options.
    EXPECT_NO_THROW(
        offer = srv->processDiscover(pkt);
    );

    // Should return something
    ASSERT_TRUE(offer);

    EXPECT_EQ(DHCPOFFER, offer->getType());

    // This is relayed message. It should be sent back to relay address.
    EXPECT_EQ(pkt->getGiaddr(), offer->getRemoteAddr());

    messageCheck(pkt, offer);

    // Check that the requested options are returned.
    optionsCheck(offer);
472

Tomek Mrugalski's avatar
Tomek Mrugalski committed
473
    // Now repeat the test for directly sent message
474 475 476 477 478 479 480 481
    pkt->setHops(0);
    pkt->setGiaddr(IOAddress("0.0.0.0"));
    pkt->setRemotePort(DHCP4_CLIENT_PORT);

    EXPECT_NO_THROW(
        offer = srv->processDiscover(pkt);
    );

Tomek Mrugalski's avatar
Tomek Mrugalski committed
482
    // Should return something
483 484 485 486
    ASSERT_TRUE(offer);

    EXPECT_EQ(DHCPOFFER, offer->getType());

Tomek Mrugalski's avatar
Tomek Mrugalski committed
487
    // This is direct message. It should be sent back to origin, not
488 489 490
    // to relay.
    EXPECT_EQ(pkt->getRemoteAddr(), offer->getRemoteAddr());

491 492
    messageCheck(pkt, offer);

493 494
    // Check that the requested options are returned.
    optionsCheck(offer);
495 496 497 498

    delete srv;
}

Tomek Mrugalski's avatar
Tomek Mrugalski committed
499 500 501 502 503 504 505
// Verifies that received REQUEST can be processed correctly,
// that the ACK message generated in response is valid and
// contains necessary options.
//
// Note: this test focuses on the packet correctness. There
// are other tests that verify correctness of the allocation
// engine. See RequestBasic.
506
TEST_F(Dhcpv4SrvTest, processRequest) {
507
    NakedDhcpv4Srv* srv = new NakedDhcpv4Srv(0);
Tomek Mrugalski's avatar
Tomek Mrugalski committed
508
    vector<uint8_t> mac(6);
509 510 511 512 513 514
    for (int i = 0; i < 6; i++) {
        mac[i] = i*10;
    }

    boost::shared_ptr<Pkt4> req(new Pkt4(DHCPREQUEST, 1234));
    boost::shared_ptr<Pkt4> ack;
515

516 517 518 519 520
    req->setIface("eth0");
    req->setIndex(17);
    req->setHWAddr(1, 6, mac);
    req->setRemoteAddr(IOAddress("192.0.2.56"));
    req->setGiaddr(IOAddress("192.0.2.67"));
521

522 523 524 525 526 527
    // We are going to test that certain options are returned
    // in the ACK message when requested using 'Parameter
    // Request List' option. Let's configure those options that
    // are returned when requested.
    configureRequestedOptions();

528
    // Should not throw
529 530 531 532
    ASSERT_NO_THROW(
        ack = srv->processRequest(req);
    );

533
    // Should return something
534 535 536 537
    ASSERT_TRUE(ack);

    EXPECT_EQ(DHCPACK, ack->getType());

538
    // This is relayed message. It should be sent back to relay address.
539 540
    EXPECT_EQ(req->getGiaddr(), ack->getRemoteAddr());

541
    messageCheck(req, ack);
542

543 544 545 546 547 548
    // There are some options that are always present in the
    // message, even if not requested.
    EXPECT_TRUE(ack->getOption(DHO_DOMAIN_NAME));
    EXPECT_TRUE(ack->getOption(DHO_DOMAIN_NAME_SERVERS));

    // We did not request any options so these should not be present
549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571
    // in the ACK.
    EXPECT_FALSE(ack->getOption(DHO_LOG_SERVERS));
    EXPECT_FALSE(ack->getOption(DHO_COOKIE_SERVERS));
    EXPECT_FALSE(ack->getOption(DHO_LPR_SERVERS));

    // Add 'Parameter Request List' option.
    addPrlOption(req);

    // Repeat the test but request some options.
    ASSERT_NO_THROW(
        ack = srv->processRequest(req);
    );

    // Should return something
    ASSERT_TRUE(ack);

    EXPECT_EQ(DHCPACK, ack->getType());

    // This is relayed message. It should be sent back to relay address.
    EXPECT_EQ(req->getGiaddr(), ack->getRemoteAddr());

    // Check that the requested options are returned.
    optionsCheck(ack);
572

573
    // Now repeat the test for directly sent message
574 575 576 577
    req->setHops(0);
    req->setGiaddr(IOAddress("0.0.0.0"));
    req->setRemotePort(DHCP4_CLIENT_PORT);

578
    EXPECT_NO_THROW(
579
        ack = srv->processDiscover(req);
580 581
    );

582
    // Should return something
583 584 585 586
    ASSERT_TRUE(ack);

    EXPECT_EQ(DHCPOFFER, ack->getType());

587
    // This is direct message. It should be sent back to origin, not
588 589 590
    // to relay.
    EXPECT_EQ(ack->getRemoteAddr(), req->getRemoteAddr());

591
    messageCheck(req, ack);
592

593 594
    // Check that the requested options are returned.
    optionsCheck(ack);
595 596 597 598 599 600 601 602 603

    delete srv;
}

TEST_F(Dhcpv4SrvTest, processRelease) {
    NakedDhcpv4Srv* srv = new NakedDhcpv4Srv();

    boost::shared_ptr<Pkt4> pkt(new Pkt4(DHCPRELEASE, 1234));

604
    // Should not throw
605 606 607 608 609 610 611 612 613 614 615 616
    EXPECT_NO_THROW(
        srv->processRelease(pkt);
    );

    delete srv;
}

TEST_F(Dhcpv4SrvTest, processDecline) {
    NakedDhcpv4Srv* srv = new NakedDhcpv4Srv();

    boost::shared_ptr<Pkt4> pkt(new Pkt4(DHCPDECLINE, 1234));

617
    // Should not throw
618 619 620 621 622 623 624 625 626 627 628 629
    EXPECT_NO_THROW(
        srv->processDecline(pkt);
    );

    delete srv;
}

TEST_F(Dhcpv4SrvTest, processInform) {
    NakedDhcpv4Srv* srv = new NakedDhcpv4Srv();

    boost::shared_ptr<Pkt4> pkt(new Pkt4(DHCPINFORM, 1234));

630
    // Should not throw
631 632 633 634
    EXPECT_NO_THROW(
        srv->processInform(pkt);
    );

635
    // Should return something
636 637
    EXPECT_TRUE(srv->processInform(pkt));

638
    // @todo Implement more reasonable tests before starting
639
    // work on processSomething() method.
640

641
    delete srv;
642 643
}

644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675
TEST_F(Dhcpv4SrvTest, serverReceivedPacketName) {
    // Check all possible packet types
    for (int itype = 0; itype < 256; ++itype) {
        uint8_t type = itype;

        switch (type) {
        case DHCPDECLINE:
            EXPECT_STREQ("DECLINE", Dhcpv4Srv::serverReceivedPacketName(type));
            break;

        case DHCPDISCOVER:
            EXPECT_STREQ("DISCOVER", Dhcpv4Srv::serverReceivedPacketName(type));
            break;

        case DHCPINFORM:
            EXPECT_STREQ("INFORM", Dhcpv4Srv::serverReceivedPacketName(type));
            break;

        case DHCPRELEASE:
            EXPECT_STREQ("RELEASE", Dhcpv4Srv::serverReceivedPacketName(type));
            break;

        case DHCPREQUEST:
            EXPECT_STREQ("REQUEST", Dhcpv4Srv::serverReceivedPacketName(type));
            break;

        default:
            EXPECT_STREQ("UNKNOWN", Dhcpv4Srv::serverReceivedPacketName(type));
        }
    }
}

676 677 678 679 680 681 682 683 684 685 686 687 688
// This test verifies that incoming DISCOVER can be handled properly, that an
// OFFER is generated, that the response has an address and that address
// really belongs to the configured pool.
//
// constructed very simple DISCOVER message with:
// - client-id option
//
// expected returned OFFER message:
// - copy of client-id
// - server-id
// - offered address
TEST_F(Dhcpv4SrvTest, DiscoverBasic) {
    boost::scoped_ptr<NakedDhcpv4Srv> srv;
689
    ASSERT_NO_THROW(srv.reset(new NakedDhcpv4Srv(0)));
690 691 692 693 694 695

    Pkt4Ptr dis = Pkt4Ptr(new Pkt4(DHCPDISCOVER, 1234));
    dis->setRemoteAddr(IOAddress("192.0.2.1"));
    OptionPtr clientid = generateClientId();
    dis->addOption(clientid);

696
    // Pass it to the server and get an offer
697 698
    Pkt4Ptr offer = srv->processDiscover(dis);

699
    // Check if we get response at all
700 701
    checkResponse(offer, DHCPOFFER, 1234);

702
    // Check that address was returned from proper range, that its lease
703 704 705
    // lifetime is correct, that T1 and T2 are returned properly
    checkAddressParams(offer, subnet_);

706
    // Check identifiers
707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725
    checkServerId(offer, srv->getServerID());
    checkClientId(offer, clientid);
}


// This test verifies that incoming DISCOVER can be handled properly, that an
// OFFER is generated, that the response has an address and that address
// really belongs to the configured pool.
//
// constructed very simple DISCOVER message with:
// - client-id option
// - address set to specific value as hint
//
// expected returned OFFER message:
// - copy of client-id
// - server-id
// - offered address
TEST_F(Dhcpv4SrvTest, DiscoverHint) {
    boost::scoped_ptr<NakedDhcpv4Srv> srv;
726
    ASSERT_NO_THROW(srv.reset(new NakedDhcpv4Srv(0)));
727 728 729 730 731 732 733 734
    IOAddress hint("192.0.2.107");

    Pkt4Ptr dis = Pkt4Ptr(new Pkt4(DHCPDISCOVER, 1234));
    dis->setRemoteAddr(IOAddress("192.0.2.1"));
    OptionPtr clientid = generateClientId();
    dis->addOption(clientid);
    dis->setYiaddr(hint);

735
    // Pass it to the server and get an offer
736 737
    Pkt4Ptr offer = srv->processDiscover(dis);

738
    // Check if we get response at all
739 740
    checkResponse(offer, DHCPOFFER, 1234);

741
    // Check that address was returned from proper range, that its lease
742 743 744 745 746
    // lifetime is correct, that T1 and T2 are returned properly
    checkAddressParams(offer, subnet_);

    EXPECT_EQ(offer->getYiaddr().toText(), hint.toText());

747
    // Check identifiers
748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765
    checkServerId(offer, srv->getServerID());
    checkClientId(offer, clientid);
}


// This test verifies that incoming DISCOVER can be handled properly, that an
// OFFER is generated, that the response has an address and that address
// really belongs to the configured pool.
//
// constructed very simple DISCOVER message with:
// - address set to specific value as hint
//
// expected returned OFFER message:
// - copy of client-id
// - server-id
// - offered address
TEST_F(Dhcpv4SrvTest, DiscoverNoClientId) {
    boost::scoped_ptr<NakedDhcpv4Srv> srv;
766
    ASSERT_NO_THROW(srv.reset(new NakedDhcpv4Srv(0)));
767 768 769 770 771 772
    IOAddress hint("192.0.2.107");

    Pkt4Ptr dis = Pkt4Ptr(new Pkt4(DHCPDISCOVER, 1234));
    dis->setRemoteAddr(IOAddress("192.0.2.1"));
    dis->setYiaddr(hint);

773
    // Pass it to the server and get an offer
774 775
    Pkt4Ptr offer = srv->processDiscover(dis);

776
    // Check if we get response at all
777 778
    checkResponse(offer, DHCPOFFER, 1234);

779
    // Check that address was returned from proper range, that its lease
780 781 782 783 784
    // lifetime is correct, that T1 and T2 are returned properly
    checkAddressParams(offer, subnet_);

    EXPECT_EQ(offer->getYiaddr().toText(), hint.toText());

785
    // Check identifiers
786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802
    checkServerId(offer, srv->getServerID());
}

// This test verifies that incoming DISCOVER can be handled properly, that an
// OFFER is generated, that the response has an address and that address
// really belongs to the configured pool.
//
// constructed very simple DISCOVER message with:
// - client-id option
// - address set to specific value as hint, but that hint is invalid
//
// expected returned OFFER message:
// - copy of client-id
// - server-id
// - offered address (!= hint)
TEST_F(Dhcpv4SrvTest, DiscoverInvalidHint) {
    boost::scoped_ptr<NakedDhcpv4Srv> srv;
803
    ASSERT_NO_THROW(srv.reset(new NakedDhcpv4Srv(0)));
804 805 806 807 808 809 810 811
    IOAddress hint("10.1.2.3");

    Pkt4Ptr dis = Pkt4Ptr(new Pkt4(DHCPDISCOVER, 1234));
    dis->setRemoteAddr(IOAddress("192.0.2.107"));
    OptionPtr clientid = generateClientId();
    dis->addOption(clientid);
    dis->setYiaddr(hint);

812
    // Pass it to the server and get an offer
813 814
    Pkt4Ptr offer = srv->processDiscover(dis);

815
    // Check if we get response at all
816 817
    checkResponse(offer, DHCPOFFER, 1234);

818
    // Check that address was returned from proper range, that its lease
819 820 821 822 823
    // lifetime is correct, that T1 and T2 are returned properly
    checkAddressParams(offer, subnet_);

    EXPECT_NE(offer->getYiaddr().toText(), hint.toText());

824
    // Check identifiers
825 826 827 828 829 830 831 832
    checkServerId(offer, srv->getServerID());
    checkClientId(offer, clientid);
}

/// @todo: Add a test that client sends hint that is in pool, but currently
/// being used by a different client.

// This test checks that the server is offering different addresses to different
Tomek Mrugalski's avatar
Tomek Mrugalski committed
833 834
// clients in OFFERs. Please note that OFFER is not a guarantee that such
// an address will be assigned. Had the pool was very small and contained only
835
// 2 addresses, the third client would get the same offer as the first one
836
// and this is a correct behavior. It is REQUEST that will fail for the third
Tomek Mrugalski's avatar
Tomek Mrugalski committed
837
// client. OFFER is basically saying "if you send me a request, you will
838 839 840
// probably get an address like this" (there are no guarantees).
TEST_F(Dhcpv4SrvTest, ManyDiscovers) {
    boost::scoped_ptr<NakedDhcpv4Srv> srv;
841
    ASSERT_NO_THROW(srv.reset(new NakedDhcpv4Srv(0)));
842 843 844 845 846 847 848 849 850

    Pkt4Ptr dis1 = Pkt4Ptr(new Pkt4(DHCPDISCOVER, 1234));
    Pkt4Ptr dis2 = Pkt4Ptr(new Pkt4(DHCPDISCOVER, 2345));
    Pkt4Ptr dis3 = Pkt4Ptr(new Pkt4(DHCPDISCOVER, 3456));

    dis1->setRemoteAddr(IOAddress("192.0.2.1"));
    dis2->setRemoteAddr(IOAddress("192.0.2.2"));
    dis3->setRemoteAddr(IOAddress("192.0.2.3"));

851
    // Different client-id sizes
852 853 854 855 856 857 858 859
    OptionPtr clientid1 = generateClientId(4); // length 4
    OptionPtr clientid2 = generateClientId(5); // length 5
    OptionPtr clientid3 = generateClientId(6); // length 6

    dis1->addOption(clientid1);
    dis2->addOption(clientid2);
    dis3->addOption(clientid3);

860 861 862 863
    // Pass it to the server and get an offer
    Pkt4Ptr offer1 = srv->processDiscover(dis1);
    Pkt4Ptr offer2 = srv->processDiscover(dis2);
    Pkt4Ptr offer3 = srv->processDiscover(dis3);
864

865 866 867 868
    // Check if we get response at all
    checkResponse(offer1, DHCPOFFER, 1234);
    checkResponse(offer2, DHCPOFFER, 2345);
    checkResponse(offer3, DHCPOFFER, 3456);
869

870 871 872
    IOAddress addr1 = offer1->getYiaddr();
    IOAddress addr2 = offer2->getYiaddr();
    IOAddress addr3 = offer3->getYiaddr();
873 874

    // Check that the assigned address is indeed from the configured pool
875 876 877 878
    checkAddressParams(offer1, subnet_);
    checkAddressParams(offer2, subnet_);
    checkAddressParams(offer3, subnet_);

879
    // Check server-ids
880 881 882 883 884 885
    checkServerId(offer1, srv->getServerID());
    checkServerId(offer2, srv->getServerID());
    checkServerId(offer3, srv->getServerID());
    checkClientId(offer1, clientid1);
    checkClientId(offer2, clientid2);
    checkClientId(offer3, clientid3);
886 887 888 889 890 891 892 893 894 895

    // Finally check that the addresses offered are different
    EXPECT_NE(addr1.toText(), addr2.toText());
    EXPECT_NE(addr2.toText(), addr3.toText());
    EXPECT_NE(addr3.toText(), addr1.toText());
    cout << "Offered address to client1=" << addr1.toText() << endl;
    cout << "Offered address to client2=" << addr2.toText() << endl;
    cout << "Offered address to client3=" << addr3.toText() << endl;
}

Tomek Mrugalski's avatar
Tomek Mrugalski committed
896 897
// This test verifies that incoming REQUEST can be handled properly, that an
// ACK is generated, that the response has an address and that address
898 899
// really belongs to the configured pool.
//
Tomek Mrugalski's avatar
Tomek Mrugalski committed
900
// constructed a single REQUEST message with:
901
// - client-id option
Tomek Mrugalski's avatar
Tomek Mrugalski committed
902 903
// - hwaddr information
// - requested address (that the client received in DISCOVER/OFFER exchange)
904
//
Tomek Mrugalski's avatar
Tomek Mrugalski committed
905
// expected returned ACK message:
906 907
// - copy of client-id
// - server-id
Tomek Mrugalski's avatar
Tomek Mrugalski committed
908 909 910
// - assigned address
//
// Test verifies that the lease is actually in the database.
911 912
TEST_F(Dhcpv4SrvTest, RequestBasic) {
    boost::scoped_ptr<NakedDhcpv4Srv> srv;
913
    ASSERT_NO_THROW(srv.reset(new NakedDhcpv4Srv(0)));
914 915 916 917 918 919 920 921 922 923 924

    IOAddress hint("192.0.2.107");
    Pkt4Ptr req = Pkt4Ptr(new Pkt4(DHCPREQUEST, 1234));
    req->setRemoteAddr(IOAddress("192.0.2.1"));
    OptionPtr clientid = generateClientId();
    req->addOption(clientid);
    req->setYiaddr(hint);

    // Pass it to the server and get an advertise
    Pkt4Ptr ack = srv->processRequest(req);

925
    // Check if we get response at all
926 927 928
    checkResponse(ack, DHCPACK, 1234);
    EXPECT_EQ(hint.toText(), ack->getYiaddr().toText());

929
    // Check that address was returned from proper range, that its lease
930 931 932
    // lifetime is correct, that T1 and T2 are returned properly
    checkAddressParams(ack, subnet_);

933
    // Check identifiers
934 935 936
    checkServerId(ack, srv->getServerID());
    checkClientId(ack, clientid);

937
    // Check that the lease is really in the database
938 939 940 941 942 943
    Lease4Ptr l = checkLease(ack, clientid, req->getHWAddr(), hint);

    ASSERT_TRUE(l);
    LeaseMgrFactory::instance().deleteLease(l->addr_);
}

Tomek Mrugalski's avatar
Tomek Mrugalski committed
944 945 946 947 948 949 950 951 952 953 954 955 956 957 958
// This test verifies that incoming REQUEST can be handled properly, that an
// ACK is generated, that the response has an address and that address
// really belongs to the configured pool.
//
// constructed 3 REQUEST messages with:
// - client-id option (differs between messages)
// - hwaddr information (differs between messages)
//
// expected returned ACK message:
// - copy of client-id
// - server-id
// - assigned address (different for each client)
TEST_F(Dhcpv4SrvTest, ManyRequests) {

    boost::scoped_ptr<NakedDhcpv4Srv> srv;
959
    ASSERT_NO_THROW(srv.reset(new NakedDhcpv4Srv(0)));
Tomek Mrugalski's avatar
Tomek Mrugalski committed
960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981

    const IOAddress req_addr1("192.0.2.105");
    const IOAddress req_addr2("192.0.2.101");
    const IOAddress req_addr3("192.0.2.109");
    const IOAddress relay("192.0.2.1");

    Pkt4Ptr req1 = Pkt4Ptr(new Pkt4(DHCPOFFER, 1234));
    Pkt4Ptr req2 = Pkt4Ptr(new Pkt4(DHCPOFFER, 2345));
    Pkt4Ptr req3 = Pkt4Ptr(new Pkt4(DHCPOFFER, 3456));

    req1->setRemoteAddr(relay);
    req2->setRemoteAddr(relay);
    req3->setRemoteAddr(relay);

    req1->setYiaddr(req_addr1);
    req2->setYiaddr(req_addr2);
    req3->setYiaddr(req_addr3);

    req1->setHWAddr(generateHWAddr(6));
    req2->setHWAddr(generateHWAddr(7));
    req3->setHWAddr(generateHWAddr(8));

982
    // Different client-id sizes
Tomek Mrugalski's avatar
Tomek Mrugalski committed
983 984 985 986 987 988 989 990 991 992 993 994 995
    OptionPtr clientid1 = generateClientId(4); // length 4
    OptionPtr clientid2 = generateClientId(5); // length 5
    OptionPtr clientid3 = generateClientId(6); // length 6

    req1->addOption(clientid1);
    req2->addOption(clientid2);
    req3->addOption(clientid3);

    // Pass it to the server and get an advertise
    Pkt4Ptr ack1 = srv->processRequest(req1);
    Pkt4Ptr ack2 = srv->processRequest(req2);
    Pkt4Ptr ack3 = srv->processRequest(req3);

996
    // Check if we get response at all
Tomek Mrugalski's avatar
Tomek Mrugalski committed
997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014
    checkResponse(ack1, DHCPACK, 1234);
    checkResponse(ack2, DHCPACK, 2345);
    checkResponse(ack3, DHCPACK, 3456);

    IOAddress addr1 = ack1->getYiaddr();
    IOAddress addr2 = ack2->getYiaddr();
    IOAddress addr3 = ack3->getYiaddr();

    // Check that every client received the address it requested
    EXPECT_EQ(req_addr1.toText(), addr1.toText());
    EXPECT_EQ(req_addr2.toText(), addr2.toText());
    EXPECT_EQ(req_addr3.toText(), addr3.toText());

    // Check that the assigned address is indeed from the configured pool
    checkAddressParams(ack1, subnet_);
    checkAddressParams(ack2, subnet_);
    checkAddressParams(ack3, subnet_);

1015
    // Check DUIDs
Tomek Mrugalski's avatar
Tomek Mrugalski committed
1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039
    checkServerId(ack1, srv->getServerID());
    checkServerId(ack2, srv->getServerID());
    checkServerId(ack3, srv->getServerID());
    checkClientId(ack1, clientid1);
    checkClientId(ack2, clientid2);
    checkClientId(ack3, clientid3);

    // Check that leases are in the database
    Lease4Ptr l = checkLease(ack1, clientid1, req1->getHWAddr(), addr1);
    EXPECT_TRUE(l);
    l = checkLease(ack2, clientid2, req2->getHWAddr(), addr2);
    l = checkLease(ack3, clientid3, req3->getHWAddr(), addr3);

    // Finally check that the addresses offered are different
    EXPECT_NE(addr1.toText(), addr2.toText());
    EXPECT_NE(addr2.toText(), addr3.toText());
    EXPECT_NE(addr3.toText(), addr1.toText());
    cout << "Offered address to client1=" << addr1.toText() << endl;
    cout << "Offered address to client2=" << addr2.toText() << endl;
    cout << "Offered address to client3=" << addr3.toText() << endl;
}


// This test verifies that incoming (positive) REQUEST/Renewing can be handled properly, that a
1040 1041 1042 1043 1044 1045 1046 1047 1048 1049
// REPLY is generated, that the response has an address and that address
// really belongs to the configured pool and that lease is actually renewed.
//
// expected:
// - returned REPLY message has copy of client-id
// - returned REPLY message has server-id
// - returned REPLY message has IA that includes IAADDR
// - lease is actually renewed in LeaseMgr
TEST_F(Dhcpv4SrvTest, RenewBasic) {
    boost::scoped_ptr<NakedDhcpv4Srv> srv;
1050
    ASSERT_NO_THROW(srv.reset(new NakedDhcpv4Srv(0)));
1051 1052

    const IOAddress addr("192.0.2.106");
1053 1054 1055 1056
    const uint32_t temp_t1 = 50;
    const uint32_t temp_t2 = 75;
    const uint32_t temp_valid = 100;
    const time_t temp_timestamp = time(NULL) - 10;
1057

1058
    // Generate client-id also sets client_id_ member
1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086
    OptionPtr clientid = generateClientId();

    // Check that the address we are about to use is indeed in pool
    ASSERT_TRUE(subnet_->inPool(addr));

    // let's create a lease and put it in the LeaseMgr
    uint8_t hwaddr2[] = { 0, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe};
    Lease4Ptr used(new Lease4(IOAddress("192.0.2.106"), hwaddr2, sizeof(hwaddr2),
                              &client_id_->getDuid()[0], client_id_->getDuid().size(),
                              temp_valid, temp_t1, temp_t2, temp_timestamp,
                              subnet_->getID()));
    ASSERT_TRUE(LeaseMgrFactory::instance().addLease(used));

    // Check that the lease is really in the database
    Lease4Ptr l = LeaseMgrFactory::instance().getLease4(addr);
    ASSERT_TRUE(l);

    // Check that T1, T2, preferred, valid and cltt really set.
    // Constructed lease looks as if it was assigned 10 seconds ago
    // EXPECT_EQ(l->t1_, temp_t1);
    // EXPECT_EQ(l->t2_, temp_t2);
    EXPECT_EQ(l->valid_lft_, temp_valid);
    EXPECT_EQ(l->cltt_, temp_timestamp);

    // Let's create a RENEW
    Pkt4Ptr req = Pkt4Ptr(new Pkt4(DHCPREQUEST, 1234));
    req->setRemoteAddr(IOAddress(addr));
    req->setYiaddr(addr);
Tomek Mrugalski's avatar
Tomek Mrugalski committed
1087
    req->setCiaddr(addr); // client's address
1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098

    req->addOption(clientid);
    req->addOption(srv->getServerID());

    // Pass it to the server and hope for a REPLY
    Pkt4Ptr ack = srv->processRequest(req);

    // Check if we get response at all
    checkResponse(ack, DHCPACK, 1234);
    EXPECT_EQ(addr.toText(), ack->getYiaddr().toText());

1099
    // Check that address was returned from proper range, that its lease
1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118
    // lifetime is correct, that T1 and T2 are returned properly
    checkAddressParams(ack, subnet_);

    // Check identifiers
    checkServerId(ack, srv->getServerID());
    checkClientId(ack, clientid);

    // Check that the lease is really in the database
    l = checkLease(ack, clientid, req->getHWAddr(), addr);
    ASSERT_TRUE(l);

    // Check that T1, T2, preferred, valid and cltt were really updated
    EXPECT_EQ(l->t1_, subnet_->getT1());
    EXPECT_EQ(l->t2_, subnet_->getT2());
    EXPECT_EQ(l->valid_lft_, subnet_->getValid());

    // Checking for CLTT is a bit tricky if we want to avoid off by 1 errors
    int32_t cltt = static_cast<int32_t>(l->cltt_);
    int32_t expected = static_cast<int32_t>(time(NULL));
1119
    // Equality or difference by 1 between cltt and expected is ok.
1120 1121 1122 1123 1124 1125 1126 1127 1128 1129
    EXPECT_GE(1, abs(cltt - expected));

    EXPECT_TRUE(LeaseMgrFactory::instance().deleteLease(addr));
}

// @todo: Implement tests for rejecting renewals

// This test verifies if the sanityCheck() really checks options presence.
TEST_F(Dhcpv4SrvTest, sanityCheck) {
    boost::scoped_ptr<NakedDhcpv4Srv> srv;
1130
    ASSERT_NO_THROW(srv.reset(new NakedDhcpv4Srv(0)));
1131 1132 1133

    Pkt4Ptr pkt = Pkt4Ptr(new Pkt4(DHCPDISCOVER, 1234));

1134
    // Client-id is optional for information-request, so
1135 1136
    EXPECT_NO_THROW(srv->sanityCheck(pkt, Dhcpv4Srv::OPTIONAL));

1137
    // Empty packet, no server-id
1138 1139 1140 1141
    EXPECT_THROW(srv->sanityCheck(pkt, Dhcpv4Srv::MANDATORY), RFCViolation);

    pkt->addOption(srv->getServerID());

1142
    // Server-id is mandatory and present = no exception
1143 1144
    EXPECT_NO_THROW(srv->sanityCheck(pkt, Dhcpv4Srv::MANDATORY));

1145
    // Server-id is forbidden, but present => exception
1146 1147 1148 1149
    EXPECT_THROW(srv->sanityCheck(pkt, Dhcpv4Srv::FORBIDDEN),
                 RFCViolation);
}

Tomek Mrugalski's avatar
Tomek Mrugalski committed
1150 1151