Skip to content
  • Thomas Markwalder's avatar
    [5046] Move apply logging and config commit from processConfig to set-config handler · 354e68ad
    Thomas Markwalder authored
    src/bin/dhcp4/ctrl_dhcp4_srv.cc
        commandConfigReloadHandler() - use commandSetConfigHandler()
        instead of processConfig() to account for logging config
    
        commandSetConfigHandler() - apply logging config and commit config here instead of
        in processConfig()
    
    src/bin/dhcp4/tests/dhcp4_test_utils.h
         ~NakedDhcpv4Srv() - removed unecesary initLogger call
    
    src/bin/dhcp4/tests/kea_controller_unittest.cc
         ~JSONFileBackendTest() - removed unecessary call to setDefaultLogging
    
    src/bin/dhcp6/ctrl_dhcp6_srv.cc
        commandConfigReloadHandler() - use commandSetConfigHandler()
        instead of processConfig() to account for logging config
    
        commandSetConfigHandler() - apply logging config and commit config here instead of
        in processConfig()
    
    src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
        createUnixChannelServer() -  added config commit so command channel behavior
        is correct
    
        TEST_F(CtrlDhcpv6SrvTest, configReload)
            Wrap configuration in Dhcp6 element
    
        TEST_F(CtrlChannelDhcpv6SrvTest, set_config)
            Turn off timers in config
    
    src/lib/dhcpsrv/srv_config.cc
        SrvConfig::applyLoggingCfg() - remove logic added to not call manager.process
        when there are no specs.
    354e68ad