Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
ISC Open Source Projects
Kea
Commits
080ee7ee
Commit
080ee7ee
authored
Jul 24, 2014
by
Marcin Siodelski
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[3269] Address issues raised in the second review.
parent
5e5f9047
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
src/bin/dhcp6/dhcp6_srv.cc
src/bin/dhcp6/dhcp6_srv.cc
+2
-2
src/bin/dhcp6/tests/confirm_unittest.cc
src/bin/dhcp6/tests/confirm_unittest.cc
+1
-1
No files found.
src/bin/dhcp6/dhcp6_srv.cc
View file @
080ee7ee
...
...
@@ -2351,7 +2351,6 @@ Dhcpv6Srv::processConfirm(const Pkt6Ptr& confirm) {
// in IA_NA, mark it verified and verify that it belongs to the
// subnet.
if
(
iaaddr
)
{
verified
=
true
;
// If at least one address is not in range, then return
// the NotOnLink status code.
if
(
subnet
&&
!
subnet
->
inRange
(
iaaddr
->
getAddress
()))
{
...
...
@@ -2362,9 +2361,10 @@ Dhcpv6Srv::processConfirm(const Pkt6Ptr& confirm) {
status_msg
.
str
()));
return
(
reply
);
}
verified
=
true
;
}
else
{
isc_throw
(
Unexpected
,
"failed to cast the IA Address option"
" to the Option6IAAddrPtr. This is programm
atic
"
" to the Option6IAAddrPtr. This is programm
ing
"
" error and should be reported"
);
}
}
...
...
src/bin/dhcp6/tests/confirm_unittest.cc
View file @
080ee7ee
...
...
@@ -297,7 +297,7 @@ TEST_F(ConfirmTest, relayedUnicast) {
ASSERT_GT
(
client
.
getLeaseNum
(),
0
);
client
.
setDestAddress
(
IOAddress
(
"2001:db8:1::1"
));
// Send Confirm message to the server.
ASSERT_NO_THROW
(
client
.
doConfirm
());
ASSERT_NO_THROW
(
client
.
doConfirm
());
// Client should have received a response.
ASSERT_TRUE
(
client
.
getContext
().
response_
);
// Client should have received a status code option and this option should
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment