From 43a491c55d92c01653d36ce2f5948f9fdeb8c239 Mon Sep 17 00:00:00 2001
From: Tomek Mrugalski <tomasz@isc.org>
Date: Fri, 10 Aug 2018 19:16:12 +0200
Subject: [PATCH] [gitlab9] Skeleton unit-tests for kea-netconf implemented.

---
 src/bin/netconf/tests/Makefile.am             |  6 ++--
 src/bin/netconf/tests/netconf_env_unittest.cc | 32 +++++++++++++++++++
 src/bin/netconf/tests/run_unittests.cc        | 12 ++-----
 3 files changed, 39 insertions(+), 11 deletions(-)
 create mode 100644 src/bin/netconf/tests/netconf_env_unittest.cc

diff --git a/src/bin/netconf/tests/Makefile.am b/src/bin/netconf/tests/Makefile.am
index 7285f8daa0..5e3384a9ab 100644
--- a/src/bin/netconf/tests/Makefile.am
+++ b/src/bin/netconf/tests/Makefile.am
@@ -30,7 +30,8 @@ if HAVE_GTEST
 
 TESTS += netconf_unittests
 
-netconf_unittests_SOURCES  = netconf_unittest.cc
+netconf_unittests_SOURCES  = run_unittests.cc
+netconf_unittests_SOURCES += netconf_env_unittest.cc
 
 netconf_unittests_CPPFLAGS = $(AM_CPPFLAGS) $(GTEST_INCLUDES)
 netconf_unittests_LDFLAGS = $(AM_LDFLAGS) $(CRYPTO_LDFLAGS)
@@ -52,12 +53,13 @@ netconf_unittests_LDADD = $(top_builddir)/src/bin/netconf/libnetconf.la
 #netconf_unittests_LDADD += $(top_builddir)/src/lib/dns/libkea-dns++.la
 #netconf_unittests_LDADD += $(top_builddir)/src/lib/cryptolink/libkea-cryptolink.la
 #netconf_unittests_LDADD += $(top_builddir)/src/lib/hooks/libkea-hooks.la
+netconf_unittests_LDADD += $(top_builddir)/src/lib/util/unittests/libutil_unittests.la
 netconf_unittests_LDADD += $(top_builddir)/src/lib/log/libkea-log.la
 netconf_unittests_LDADD += $(top_builddir)/src/lib/util/threads/libkea-threads.la
 netconf_unittests_LDADD += $(top_builddir)/src/lib/util/libkea-util.la
 netconf_unittests_LDADD += $(top_builddir)/src/lib/exceptions/libkea-exceptions.la
 netconf_unittests_LDADD += $(LOG4CPLUS_LIBS) $(CRYPTO_LIBS)
-netconf_unittests_LDADD += $(BOOST_LIBS) $(GTEST_LDADD)
+netconf_unittests_LDADD += $(BOOST_LIBS) $(GTEST_LDADD) $(SYSREPO_LIBS)
 endif
 
 noinst_EXTRA_DIST = configs-list.txt
diff --git a/src/bin/netconf/tests/netconf_env_unittest.cc b/src/bin/netconf/tests/netconf_env_unittest.cc
new file mode 100644
index 0000000000..7d4e212732
--- /dev/null
+++ b/src/bin/netconf/tests/netconf_env_unittest.cc
@@ -0,0 +1,32 @@
+// Copyright (C) 2018 Internet Systems Consortium, Inc. ("ISC")
+//
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+/// @brief Basic environment tests for netconf
+
+
+#include <sysrepo-cpp/Session.h>
+#include <gtest/gtest.h>
+
+class NetconfTest : public ::testing::Test {
+public:
+
+    NetconfTest() {}
+
+};
+
+// This test checks if a session to sysrepo can be established.
+// It uses sysrepo code directly, so it's a sanity check for the
+// environment. Doesn't test any Kea code.
+TEST_F(NetconfTest, environmentSanity) {
+
+    S_Connection conn;
+
+    ASSERT_NO_THROW(conn.reset(new Connection("kea-netconf")));
+
+    S_Session sess;
+
+    ASSERT_NO_THROW(sess.reset(new Session(conn)));
+}
diff --git a/src/bin/netconf/tests/run_unittests.cc b/src/bin/netconf/tests/run_unittests.cc
index 172768f2e7..c0847cad14 100644
--- a/src/bin/netconf/tests/run_unittests.cc
+++ b/src/bin/netconf/tests/run_unittests.cc
@@ -6,21 +6,15 @@
 
 #include <config.h>
 
-#include <log/logger_support.h>
-#include <dhcp4/dhcp4_log.h>
 #include <gtest/gtest.h>
+#include <util/unittests/run_all.h>
+#include <log/logger_support.h>
 
 int
 main(int argc, char* argv[]) {
-
     ::testing::InitGoogleTest(&argc, argv);
 
-    // See the documentation of the KEA_* environment variables in
-    // src/lib/log/README for info on how to tweak logging
     isc::log::initLogger();
 
-    setenv("KEA_PIDFILE_DIR", TEST_DATA_BUILDDIR, 1);
-    int result = RUN_ALL_TESTS();
-
-    return (result);
+    return (isc::util::unittests::run_all());
 }
-- 
GitLab