[174-warning-for-unused-trace-levels] Made extern debug levels

src/bin/dhcp4/dhcp4_log.cc

-// Copyright (C) 2012-2015 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2012-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -14,6 +14,15 @@
 namespace isc {
 namespace dhcp {
 
+extern const int DBG_DHCP4_START = isc::log::DBGLVL_START_SHUT;
+extern const int DBG_DHCP4_SHUT = isc::log::DBGLVL_START_SHUT;
+extern const int DBG_DHCP4_COMMAND = isc::log::DBGLVL_COMMAND;
+extern const int DBG_DHCP4_BASIC = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DBG_DHCP4_HOOKS = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DBG_DHCP4_BASIC_DATA = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int DBG_DHCP4_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int DBG_DHCP4_DETAIL_DATA = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+
 const char* DHCP4_ROOT_LOGGER_NAME = "kea-dhcp4";
 const char* DHCP4_APP_LOGGER_NAME = "dhcp4";
 const char* DHCP4_BAD_PACKET_LOGGER_NAME = "bad-packets";

src/bin/dhcp4/dhcp4_log.h

@@ -21,19 +21,19 @@ namespace dhcp {
 //@{
 
 /// @brief Debug level used to log information during server startup.
-const int DBG_DHCP4_START = isc::log::DBGLVL_START_SHUT;
+extern const int DBG_DHCP4_START;
 
 /// @brief Debug level used to log information during server shutdown.
-const int DBG_DHCP4_SHUT = isc::log::DBGLVL_START_SHUT;
+extern const int DBG_DHCP4_SHUT;
 
 /// @brief Debug level used to log receiving commands.
-const int DBG_DHCP4_COMMAND = isc::log::DBGLVL_COMMAND;
+extern const int DBG_DHCP4_COMMAND;
 
 /// @brief Debug level used to trace basic operations within the code.
-const int DBG_DHCP4_BASIC = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DBG_DHCP4_BASIC;
 
 /// @brief Debug level used to trace hook related operations
-const int DBG_DHCP4_HOOKS = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DBG_DHCP4_HOOKS;
 
 /// @brief Debug level used to log the traces with some basic data.
 ///
@@ -42,7 +42,7 @@ const int DBG_DHCP4_HOOKS = isc::log::DBGLVL_TRACE_BASIC;
 /// more detailed information in cases when it is warranted and the
 /// extraction of the data doesn't impact the server's performance
 /// significantly.
-const int DBG_DHCP4_BASIC_DATA = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int DBG_DHCP4_BASIC_DATA;
 
 /// @brief Debug level used to trace detailed errors.
 ///
@@ -50,10 +50,10 @@ const int DBG_DHCP4_BASIC_DATA = isc::log::DBGLVL_TRACE_BASIC_DATA;
 /// packets.  (These are not logged at severities of WARN or higher for fear
 /// that a set of deliberately invalid packets set to the server could overwhelm
 /// the logging.)
-const int DBG_DHCP4_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int DBG_DHCP4_DETAIL;
 
 /// @brief This level is used to log the contents of packets received and sent.
-const int DBG_DHCP4_DETAIL_DATA = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+extern const int DBG_DHCP4_DETAIL_DATA;
 
 //@}
 

src/bin/dhcp6/dhcp6_log.cc

-// Copyright (C) 2012-2015 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2012-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -14,6 +14,15 @@
 namespace isc {
 namespace dhcp {
 
+extern const int DBG_DHCP6_START = isc::log::DBGLVL_START_SHUT;
+extern const int DBG_DHCP6_SHUT = isc::log::DBGLVL_START_SHUT;
+extern const int DBG_DHCP6_COMMAND = isc::log::DBGLVL_COMMAND;
+extern const int DBG_DHCP6_BASIC = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DBG_DHCP6_HOOKS = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DBG_DHCP6_BASIC_DATA = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int DBG_DHCP6_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int DBG_DHCP6_DETAIL_DATA = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+
 const char* DHCP6_ROOT_LOGGER_NAME = "kea-dhcp6";
 const char* DHCP6_APP_LOGGER_NAME = "dhcp6";
 const char* DHCP6_BAD_PACKET_LOGGER_NAME = "bad-packets";

src/bin/dhcp6/dhcp6_log.h

-// Copyright (C) 2012-2015,2017 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2012-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -18,19 +18,19 @@ namespace dhcp {
 //@{
 
 /// @brief Debug level used to log information during server startup.
-const int DBG_DHCP6_START = isc::log::DBGLVL_START_SHUT;
+extern const int DBG_DHCP6_START;
 
 /// @brief Debug level used to log information during server shutdown.
-const int DBG_DHCP6_SHUT = isc::log::DBGLVL_START_SHUT;
+extern const int DBG_DHCP6_SHUT;
 
 /// @brief Debug level used to log receiving commands.
-const int DBG_DHCP6_COMMAND = isc::log::DBGLVL_COMMAND;
+extern const int DBG_DHCP6_COMMAND;
 
 /// @brief Debug level used to trace basic operations within the code.
-const int DBG_DHCP6_BASIC = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DBG_DHCP6_BASIC;
 
 /// @brief Debug level used to trace hook related operations
-const int DBG_DHCP6_HOOKS = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DBG_DHCP6_HOOKS;
 
 /// @brief Debug level used to log the traces with some basic data.
 ///
@@ -39,7 +39,7 @@ const int DBG_DHCP6_HOOKS = isc::log::DBGLVL_TRACE_BASIC;
 /// more detailed information in cases when it is warranted and the
 /// extraction of the data doesn't impact the server's performance
 /// significantly.
-const int DBG_DHCP6_BASIC_DATA = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int DBG_DHCP6_BASIC_DATA;
 
 /// @brief Debug level used to trace detailed errors.
 ///
@@ -47,10 +47,10 @@ const int DBG_DHCP6_BASIC_DATA = isc::log::DBGLVL_TRACE_BASIC_DATA;
 /// packets.  (These are not logged at severities of WARN or higher for fear
 /// that a set of deliberately invalid packets set to the server could overwhelm
 /// the logging.)
-const int DBG_DHCP6_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int DBG_DHCP6_DETAIL;
 
 /// @brief This level is used to log the contents of packets received and sent.
-const int DBG_DHCP6_DETAIL_DATA = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+extern const int DBG_DHCP6_DETAIL_DATA;
 
 //@}
 

src/bin/netconf/netconf_log.cc

@@ -14,6 +14,11 @@
 namespace isc {
 namespace netconf {
 
+extern const int NETCONF_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int NETCONF_DBG_RESULTS = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int NETCONF_DBG_TRACE_DETAIL_DATA =
+    isc::log::DBGLVL_TRACE_DETAIL_DATA;
+
 const char* NETCONF_LOGGER_NAME = "netconf";
 
 isc::log::Logger netconf_logger(NETCONF_LOGGER_NAME);

src/bin/netconf/netconf_log.h

@@ -26,19 +26,19 @@ namespace netconf {
 /// @brief Traces normal operations.
 ///
 /// E.g. sending a command to a server etc.
-const int NETCONF_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int NETCONF_DBG_TRACE;
 
 /// @brief Records the results of the commands.
 ///
 /// Using the example of tracing commands to a server, this will just record
 /// the summary results.
-const int NETCONF_DBG_RESULTS = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int NETCONF_DBG_RESULTS;
 
 /// @brief Additional information.
 ///
 /// Record detailed tracing. This is generally reserved for tracing
 /// configurations from or to a server.
-const int NETCONF_DBG_TRACE_DETAIL_DATA = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+extern const int NETCONF_DBG_TRACE_DETAIL_DATA;
 
 ///@}
 

src/lib/config/config_log.cc

-// Copyright (C) 2011-2015 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2011-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -15,6 +15,8 @@ namespace config {
 
 isc::log::Logger command_logger("commands");
 
+extern const int DBG_COMMAND = isc::log::DBGLVL_COMMAND;
+
 } // namespace nsas
 } // namespace isc
 

src/lib/config/config_log.h

-// Copyright (C) 2011-2015,2017 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2011-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -21,7 +21,7 @@ namespace config {
 extern isc::log::Logger command_logger;
 
 // Enumerate configuration elements as they are processed.
-const int DBG_COMMAND = isc::log::DBGLVL_COMMAND;
+extern const int DBG_COMMAND;
 
 } // namespace config
 } // namespace isc

src/lib/database/db_log.cc

@@ -17,6 +17,9 @@ using namespace isc::log;
 namespace isc {
 namespace db {
 
+/// @brief Database logging levels.
+extern const int DB_DBG_TRACE_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+
 /// @brief Map of translated messages.
 const DbLogger::MessageMap db_message_map = {
     { DB_INVALID_ACCESS,       DATABASE_INVALID_ACCESS },

src/lib/database/db_log.h

@@ -37,7 +37,7 @@ namespace db {
 ///
 /// Record detailed tracing. This is generally reserved for tracing access to
 /// the lease database.
-const int DB_DBG_TRACE_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int DB_DBG_TRACE_DETAIL;
 
 ///@}
 

src/lib/dhcpsrv/alloc_engine_log.cc

-// Copyright (C) 2015 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2015-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -13,6 +13,12 @@
 namespace isc {
 namespace dhcp {
 
+extern const int ALLOC_ENGINE_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int ALLOC_ENGINE_DBG_RESULTS = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int ALLOC_ENGINE_DBG_TRACE_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int ALLOC_ENGINE_DBG_TRACE_DETAIL_DATA =
+    isc::log::DBGLVL_TRACE_DETAIL_DATA;
+
 isc::log::Logger alloc_engine_logger("alloc-engine");
 
 } // namespace dhcp

src/lib/dhcpsrv/alloc_engine_log.h

-// Copyright (C) 2015,2017 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2015-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -19,23 +19,23 @@ namespace dhcp {
 /// Defines the levels used to output debug messages from the @c AllocEngine.
 
 /// @brief Traces normal operations
-const int ALLOC_ENGINE_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int ALLOC_ENGINE_DBG_TRACE;
 
 /// @brief Records the results of various operations.
 ///
 /// Messages logged at this level will typically contain summary of the
 /// data retrieved.
-const int ALLOC_ENGINE_DBG_RESULTS = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int ALLOC_ENGINE_DBG_RESULTS;
 
 /// @brief Record detailed traces
 ///
 /// Messages logged at this level will log detailed tracing information.
-const int ALLOC_ENGINE_DBG_TRACE_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int ALLOC_ENGINE_DBG_TRACE_DETAIL;
 
 /// @brief Records detailed results of various operations.
 ///
 /// Messages logged at this level will contain detailed results.
-const int ALLOC_ENGINE_DBG_TRACE_DETAIL_DATA = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+extern const int ALLOC_ENGINE_DBG_TRACE_DETAIL_DATA;
 
 //@}
 

src/lib/dhcpsrv/dhcpsrv_log.cc

-// Copyright (C) 2012-2015 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2012-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -13,6 +13,13 @@
 namespace isc {
 namespace dhcp {
 
+extern const int DHCPSRV_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DHCPSRV_DBG_RESULTS = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int DHCPSRV_DBG_TRACE_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int DHCPSRV_DBG_TRACE_DETAIL_DATA =
+    isc::log::DBGLVL_TRACE_DETAIL_DATA;
+extern const int DHCPSRV_DBG_HOOKS = isc::log::DBGLVL_TRACE_BASIC;
+
 isc::log::Logger dhcpsrv_logger("dhcpsrv");
 
 } // namespace dhcp

src/lib/dhcpsrv/dhcpsrv_log.h

-// Copyright (C) 2011-2015,2017 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2011-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -23,27 +23,27 @@ namespace dhcp {
 /// @brief Traces normal operations
 ///
 /// E.g. sending a query to the database etc.
-const int DHCPSRV_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DHCPSRV_DBG_TRACE;
 
 /// @brief Records the results of the lookups
 ///
 /// Using the example of tracing queries from the backend database, this will
 /// just record the summary results.
-const int DHCPSRV_DBG_RESULTS = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int DHCPSRV_DBG_RESULTS;
 
 /// @brief Additional information
 ///
 /// Record detailed tracing. This is generally reserved for tracing access to
 /// the lease database.
-const int DHCPSRV_DBG_TRACE_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int DHCPSRV_DBG_TRACE_DETAIL;
 
 /// @brief Additional information
 ///
 /// Record detailed (and verbose) data on the server.
-const int DHCPSRV_DBG_TRACE_DETAIL_DATA = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+extern const int DHCPSRV_DBG_TRACE_DETAIL_DATA;
 
 // Trace hook related operations
-const int DHCPSRV_DBG_HOOKS = isc::log::DBGLVL_TRACE_BASIC;
+extern const int DHCPSRV_DBG_HOOKS;
 
 ///@}
 

src/lib/dhcpsrv/hosts_log.cc

-// Copyright (C) 2015 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2015-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -13,6 +13,12 @@
 namespace isc {
 namespace dhcp {
 
+extern const int HOSTS_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int HOSTS_DBG_RESULTS = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int HOSTS_DBG_TRACE_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int HOSTS_DBG_TRACE_DETAIL_DATA =
+    isc::log::DBGLVL_TRACE_DETAIL_DATA;
+
 isc::log::Logger hosts_logger("hosts");
 
 } // namespace dhcp

src/lib/dhcpsrv/hosts_log.h

-// Copyright (C) 2015,2017 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2015-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -24,23 +24,23 @@ namespace dhcp {
 ///
 /// An example of the normal operation is the call to one of the functions
 /// which retrieve the reservations or add new reservation.
-const int HOSTS_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int HOSTS_DBG_TRACE;
 
 /// @brief Records the results of the lookups
 ///
 /// Messages logged at this level will typically contain summary of the
 /// data retrieved.
-const int HOSTS_DBG_RESULTS = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int HOSTS_DBG_RESULTS;
 
 /// @brief Record detailed traces
 ///
 /// Messages logged at this level will log detailed tracing information.
-const int HOSTS_DBG_TRACE_DETAIL = isc::log::DBGLVL_TRACE_DETAIL;
+extern const int HOSTS_DBG_TRACE_DETAIL;
 
 /// @brief Records detailed results of lookups.
 ///
 /// Messages logged at this level will contain detailed results.
-const int HOSTS_DBG_TRACE_DETAIL_DATA = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+extern const int HOSTS_DBG_TRACE_DETAIL_DATA;
 
 ///@}
 

src/lib/eval/eval_log.cc

-// Copyright (C) 2015 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2015-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -13,6 +13,9 @@
 namespace isc {
 namespace dhcp {
 
+extern const int EVAL_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int EVAL_DBG_STACK = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+
 isc::log::Logger eval_logger("eval");
 
 } // namespace dhcp

src/lib/eval/eval_log.h

-// Copyright (C) 2015-2017 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2015-2018 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -19,11 +19,11 @@ namespace dhcp {
 /// Note that higher numbers equate to more verbose (and detailed) output.
 
 // The first level traces normal operations,
-const int EVAL_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int EVAL_DBG_TRACE;
 
 // Additional information on the calls.  Report the values that were
 // popped from or pushed to the value stack.
-const int EVAL_DBG_STACK = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+extern const int EVAL_DBG_STACK;
 
 /// @brief Eval Logger
 ///

src/lib/hooks/hooks_log.cc

@@ -18,9 +18,9 @@ isc::log::Logger hooks_logger("hooks");
 
 isc::log::Logger callouts_logger("callouts");
 
-const int HOOKS_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
-const int HOOKS_DBG_CALLS = isc::log::DBGLVL_TRACE_BASIC_DATA;
-const int HOOKS_DBG_EXTENDED_CALLS = isc::log::DBGLVL_TRACE_DETAIL_DATA;
+extern const int HOOKS_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
+extern const int HOOKS_DBG_CALLS = isc::log::DBGLVL_TRACE_BASIC_DATA;
+extern const int HOOKS_DBG_EXTENDED_CALLS = isc::log::DBGLVL_TRACE_DETAIL_DATA;
 
 
 } // namespace hooks