diff --git a/tests/tools/perfdhcp/perf_pkt4.cc b/tests/tools/perfdhcp/perf_pkt4.cc index 3ccef94e9880054a51f1fcdbaf27c3b68da9c307..8b7e974d7210ddba5be5b8e574177139483679e1 100644 --- a/tests/tools/perfdhcp/perf_pkt4.cc +++ b/tests/tools/perfdhcp/perf_pkt4.cc @@ -13,7 +13,7 @@ // PERFORMANCE OF THIS SOFTWARE. #include -#include +#include #include "perf_pkt4.h" diff --git a/tests/tools/perfdhcp/test_control.cc b/tests/tools/perfdhcp/test_control.cc index 01f864f11a17b2e494f600b6eb85a723246bba8d..f7f4978fd7b6b85f626a012a39c6d3d6eb079b88 100644 --- a/tests/tools/perfdhcp/test_control.cc +++ b/tests/tools/perfdhcp/test_control.cc @@ -1284,6 +1284,10 @@ TestControl::sendDiscover4(const TestControlSocket& socket, if (!pkt4) { isc_throw(Unexpected, "failed to create DISCOVER packet"); } + + // Delete the default Message Type option set by Pkt4 + pkt4->delOption(DHO_DHCP_MESSAGE_TYPE); + // Set options: DHCP_MESSAGE_TYPE and DHCP_PARAMETER_REQUEST_LIST OptionBuffer buf_msg_type; buf_msg_type.push_back(DHCPDISCOVER); @@ -1371,11 +1375,7 @@ TestControl::sendRequest4(const TestControlSocket& socket, const dhcp::Pkt4Ptr& offer_pkt4) { const uint32_t transid = generateTransid(); Pkt4Ptr pkt4(new Pkt4(DHCPREQUEST, transid)); - OptionBuffer buf_msg_type; - buf_msg_type.push_back(DHCPREQUEST); - OptionPtr opt_msg_type = Option::factory(Option::V4, DHO_DHCP_MESSAGE_TYPE, - buf_msg_type); - pkt4->addOption(opt_msg_type); + // Use first flags indicates that we want to use the server // id captured in first packet. if (CommandOptions::instance().isUseFirst() && diff --git a/tests/tools/perfdhcp/tests/test_control_unittest.cc b/tests/tools/perfdhcp/tests/test_control_unittest.cc index 6c27731e1b71cb51c0165978c0ce4f531e3a27c3..ae67e6ef6260bec639ad2c109254d3c0c3aa3256 100644 --- a/tests/tools/perfdhcp/tests/test_control_unittest.cc +++ b/tests/tools/perfdhcp/tests/test_control_unittest.cc @@ -630,13 +630,10 @@ private: boost::shared_ptr createOfferPkt4(uint32_t transid) const { boost::shared_ptr offer(new Pkt4(DHCPOFFER, transid)); - OptionPtr opt_msg_type = Option::factory(Option::V4, DHO_DHCP_MESSAGE_TYPE, - OptionBuffer(DHCPOFFER)); OptionPtr opt_serverid = Option::factory(Option::V4, DHO_DHCP_SERVER_IDENTIFIER, OptionBuffer(4, 1)); offer->setYiaddr(asiolink::IOAddress("127.0.0.1")); - offer->addOption(opt_msg_type); offer->addOption(opt_serverid); offer->updateTimestamp(); return (offer);