Commit 6c9732dc authored by Jelte Jansen's avatar Jelte Jansen
Browse files

[357] address review comments

- explain 0 value for tcp_recv_timeout
- initialize value in config parser (to 0, it will be set by build() anyway)
parent 5298a0ca
......@@ -1640,6 +1640,7 @@ can use various data source backends.
<varname>tcp_recv_timeout</varname> is the timeout used on
incoming TCP connections, in milliseconds. If the query
is not sent within this time, the connection is closed.
Setting this to 0 will disable TCP timeouts completely.
</simpara>
</listitem>
</varlistentry>
......
......@@ -120,11 +120,15 @@ private:
/// \brief Configuration for TCP receive timeouts
class TCPRecvTimeoutConfig : public AuthConfigParser {
public:
TCPRecvTimeoutConfig(AuthSrv& server) : server_(server)
TCPRecvTimeoutConfig(AuthSrv& server) : server_(server), timeout_(0)
{}
virtual void build(ConstElementPtr config) {
timeout_ = config->intValue();
if (config->intValue() >= 0) {
timeout_ = config->intValue();
} else {
isc_throw(AuthConfigError, "tcp_recv_timeout must be 0 or higher");
}
}
virtual void commit() {
......
......@@ -156,6 +156,7 @@
<varname>tcp_recv_timeout</varname> is the timeout used on
incoming TCP connections, in milliseconds. If the query
is not sent within this time, the connection is closed.
Setting this to 0 will disable TCP timeouts completely.
</para>
<!-- TODO: formating -->
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment