Commit 7e81bfc6 authored by Francis Dupont's avatar Francis Dupont Committed by Tomek Mrugalski

[fdunparse2] Finished agent and added some @todos

parent 0a6b0221
......@@ -16,7 +16,7 @@
},
"hooks-libraries": [
{
"library": "/tmp/kea/src/bin/agent/tests/.libs/libbasic.so",
"library": "/opt/local/control-agent-commands.so",
"parameters": {
"param1": "foo"
}
......
......@@ -81,6 +81,7 @@ ElementPtr CfgMACSource::toElement() const {
}
result->add(Element::create(name));
}
// @todo check if the list is empty (including a new unit test)
return (result);
}
......
......@@ -313,7 +313,7 @@ CfgSubnets4::toElement() const {
ElementPtr pool_list = Element::createList();
for (PoolCollection::const_iterator pool = pools.cbegin();
pool != pools.cend(); ++pool) {
// Prepare the map for a pool
// Prepare the map for a pool (@todo move this code to pool.cc)
ElementPtr pool_map = Element::createMap();
// Set pool
const IOAddress& first = (*pool)->getFirstAddress();
......
......@@ -289,7 +289,7 @@ CfgSubnets6::toElement() const {
ElementPtr pool_list = Element::createList();
for (PoolCollection::const_iterator pool = pools.cbegin();
pool != pools.cend(); ++pool) {
// Prepare the map for a pool
// Prepare the map for a pool (@todo move this code to pool.cc)
ElementPtr pool_map = Element::createMap();
// Set pool
const IOAddress& first = (*pool)->getFirstAddress();
......@@ -320,7 +320,7 @@ CfgSubnets6::toElement() const {
ElementPtr pdpool_list = Element::createList();
for (PoolCollection::const_iterator pool = pdpools.cbegin();
pool != pdpools.cend(); ++pool) {
// Get it as a Pool6
// Get it as a Pool6 (@todo move this code to pool.cc)
const Pool6* pdpool = dynamic_cast<Pool6*>(pool->get());
if (!pdpool) {
isc_throw(ToElementError, "invalid pd-pool pointer");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment