Commit 87a15e84 authored by Marcin Siodelski's avatar Marcin Siodelski
Browse files

[#42, !103] Addressed two review comments.

Commentary for sleep(1) in case of the error condition in the IfaceMgr.
Also fixed one parameter name in the doxygen.
parent d0b75afb
......@@ -1221,6 +1221,9 @@ void IfaceMgr::receiveDHCP4Packets() {
// Signal the error to receive4.
receiver_error_ = strerror(errno);
error_watch_.markReady();
// We need to sleep in case of the error condition to
// prevent the thread from tight looping when result
// gets negative.
sleep(1);
}
continue;
......@@ -1303,6 +1306,9 @@ void IfaceMgr::receiveDHCP6Packets() {
// Signal the error to receive6.
receiver_error_ = strerror(errno);
error_watch_.markReady();
// We need to sleep in case of the error condition to
// prevent the thread from tight looping when result
// gets negative.
sleep(1);
}
continue;
......
......@@ -234,7 +234,7 @@ public:
/// @brief Constructor
///
/// @param queue_type logical name of the queue implementation
/// @param queue_capacity maximum number of packets the queue can hold
/// @param capacity maximum number of packets the queue can hold
PacketQueueRing(const std::string& queue_type, size_t capacity)
: PacketQueue<PacketTypePtr>(queue_type) {
queue_.set_capacity(capacity);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment