Commit 9500689f authored by Jeremy C. Reed's avatar Jeremy C. Reed
Browse files

[master] for log4cplus unused variable issue

add comment
change from unused-parameter to unused-variable
remove additional change as was not needed.

discussed on jabber
and I tested directly with clang on Mac OS X (where problem
was seen).
parent db96ce78
......@@ -29,7 +29,9 @@ run_unittests_LDFLAGS = $(AM_LDFLAGS) $(GTEST_LDFLAGS)
run_unittests_CXXFLAGS = $(AM_CXXFLAGS)
if USE_CLANGPP
run_unittests_CXXFLAGS += -Wno-error=unused-parameter
# This is to workaround unused variables tcout and tcerr in
# log4cplus's streams.h.
run_unittests_CXXFLAGS += -Wno-unused-variable
endif
run_unittests_LDADD = $(GTEST_LDADD)
run_unittests_LDADD += $(top_builddir)/src/lib/log/liblog.la
......@@ -39,10 +41,6 @@ endif
TESTS += logger_support_test
logger_support_test_SOURCES = logger_support_test.cc
logger_support_test_CPPFLAGS = $(AM_CPPFLAGS)
logger_support_test_CXXFLAGS = $(AM_CXXFLAGS)
if USE_CLANGPP
logger_support_test_CXXFLAGS += -Wno-error=unused-parameter
endif
logger_support_test_LDFLAGS = $(AM_LDFLAGS)
logger_support_test_LDADD = $(top_builddir)/src/lib/log/liblog.la
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment