Commit 9dac9afb authored by JINMEI Tatuya's avatar JINMEI Tatuya
Browse files

[1858] cleanup: removed unnecessary list() conversion from dict values.

dict.values() is an iterable, so we can use it directly in the for statement.
(and we don't modify components within the loop).
parent c9de2864
......@@ -712,8 +712,7 @@ class BoB:
'''
logmsg = BIND10_SEND_SIGKILL if forceful else BIND10_SEND_SIGTERM
# TODO: we should be able to skip list()
for component in list(self.components.values()):
for component in self.components.values():
logger.info(logmsg, component.name(), component.pid())
try:
component.kill(forceful)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment