Commit 9e363eaa authored by Michal 'vorner' Vaner's avatar Michal 'vorner' Vaner
Browse files

[1596] Some comments

parent 30219fe1
......@@ -193,9 +193,13 @@ class BoB:
self.nocache = nocache
self.component_config = {}
# Some time in future, it may happen that a single component has
# multple processes. If so happens, name "components" may be
# inapropriate. But as the code isn't probably completely ready
# for it, we leave it at components for now.
# multple processes (like a pipeline-like component). If so happens,
# name "components" may be inapropriate. But as the code isn't probably
# completely ready for it, we leave it at components for now. We also
# want to support multiple instances of a single component. If it turns
# out that we'll have a single component with multiple same processes
# or if we start multiple components with the same configuration (we do
# this now, but it might change) is an open question.
self.components = {}
# Simply list of components that died and need to wait for a
# restart. Components manage their own restart schedule now
......
......@@ -94,12 +94,8 @@ my_command_handler(const string& command, ConstElementPtr args) {
const int pid(args->get("pid")->intValue());
const pid_t my_pid(getpid());
if (my_pid != pid) {
// It is not for us
//
// Note that this is completely expected situation, if
// there are multiple instances of the server running and
// another instance is being shut down, we get the message
// too, due to the multicast nature of our message bus.
// It is not for us (this is expected, see auth/command.cc
// and the ShutdownCommand there).
return answer;
}
}
......
......@@ -22,9 +22,9 @@ Dependencies between them are not yet handled. It might turn out they are
needed, in that case they will be added sometime in future.
This framework allows for a single process to be started multiple times (by
specifying multiple components with the same configuration). However, the rest
of the system might not handle such situation well, so until it is made so,
it would be better to start each process at most once.
specifying multiple components with the same configuration). We might want
to add a more convenient support (like providing a count argument to the
configuration). This is yet to be designed.
"""
import isc.log
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment