Commit a8c8f392 authored by JINMEI Tatuya's avatar JINMEI Tatuya
Browse files

[1574] an editorial cleanup: moved ToUpper above places where it's used

(not mandatory to compile, but the previous position looked awkward)
parent 1639806c
......@@ -280,6 +280,15 @@ struct InMemoryZoneFinder::InMemoryZoneFinderImpl {
}
}
// A helper functor to convert the 1st NSEC3 label to all upper-cased
// characters. Note: technically there's a subtle issue when char
// is signed, but in practice the label should consist of all positive
// character values for a valid NSEC3 hash name (if it's invalid the
// resulting zone doesn't work correctly anyway).
struct ToUpper {
char operator()(char ch) { return (toupper(ch)); }
};
result::Result addRRsig(const ConstRRsetPtr sig_rrset, ZoneData& zone_data)
{
// Check consistency of the type covered.
......@@ -353,15 +362,6 @@ struct InMemoryZoneFinder::InMemoryZoneFinderImpl {
return (result::SUCCESS);
}
// A helper functor to convert the 1st NSEC3 label to all upper-cased
// characters. Note: technically there's a subtle issue when char
// is signed, but in practice the label should consist of all positive
// character values for a valid NSEC3 hash name (if it's invalid the
// resulting zone doesn't work correctly anyway).
struct ToUpper {
char operator()(char ch) { return (toupper(ch)); }
};
result::Result addNSEC3(const ConstRRsetPtr rrset, ZoneData& zone_data) {
if (!zone_data.nsec3_data_) {
zone_data.nsec3_data_.reset(new ZoneData::NSEC3Data);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment