Commit ac5e4786 authored by Thomas Markwalder's avatar Thomas Markwalder

[3121] Addressed review comments

Added suggested code commentary.
parent 215020f1
......@@ -265,8 +265,9 @@ TSIGKeyInfoParser::createConfigParser(const std::string& config_id) {
void
TSIGKeyInfoParser::commit() {
/// @todo if at some point TSIG keys need some form of resource
/// initialization do that here
/// @todo if at some point TSIG keys need some form of runtime resource
/// initialization, such as creating some sort of hash instance in
/// crytpolib. Once TSIG is fully implemented under Trac #3432 we'll know.
}
// *********************** TSIGKeyInfoListParser *************************
......
......@@ -561,6 +561,8 @@ public:
virtual isc::dhcp::ParserPtr createConfigParser(const std::string&
config_id);
/// @brief Commits the TSIGKeyInfo configuration
/// Currently this method is a NOP, as the key instance is created and
/// then added to a local list of keys in build().
virtual void commit();
private:
......@@ -613,7 +615,8 @@ public:
/// @brief Commits the list of TSIG keys
///
/// Iterates over the internal list of TSIGKeyInfoParsers, invoking
/// commit on each one.
/// commit on each one. Then commits the local list of keys to
/// storage.
virtual void commit();
private:
......@@ -675,6 +678,8 @@ public:
config_id);
/// @brief Commits the configured DnsServerInfo
/// Currently this method is a NOP, as the server instance is created and
/// then added to the list of servers in build().
virtual void commit();
private:
......@@ -788,6 +793,8 @@ public:
config_id);
/// @brief Commits the configured DdnsDomain
/// Currently this method is a NOP, as the domain instance is created and
/// then added to the list of domains in build().
virtual void commit();
private:
......@@ -920,6 +927,8 @@ public:
config_id);
/// @brief Commits the configured DdsnDomainListMgr
/// Currently this method is a NOP, as the manager instance is created
/// in build().
virtual void commit();
private:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment