Commit b9cd36cb authored by Jelte Jansen's avatar Jelte Jansen
Browse files

unit tests for b10-cfgmgr

moved a little bit of code into a main() function (instead of calling it directly), for easier testing
module magic happening in the test.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac238@2127 e5f2f494-b856-4b98-b285-d166d9295462
parent e2892b6f
...@@ -393,6 +393,7 @@ AC_CONFIG_FILES([Makefile ...@@ -393,6 +393,7 @@ AC_CONFIG_FILES([Makefile
src/bin/bindctl/Makefile src/bin/bindctl/Makefile
src/bin/bindctl/tests/Makefile src/bin/bindctl/tests/Makefile
src/bin/cfgmgr/Makefile src/bin/cfgmgr/Makefile
src/bin/cfgmgr/tests/Makefile
src/bin/host/Makefile src/bin/host/Makefile
src/bin/loadzone/Makefile src/bin/loadzone/Makefile
src/bin/msgq/Makefile src/bin/msgq/Makefile
...@@ -423,6 +424,7 @@ AC_CONFIG_FILES([Makefile ...@@ -423,6 +424,7 @@ AC_CONFIG_FILES([Makefile
src/lib/xfr/Makefile src/lib/xfr/Makefile
]) ])
AC_OUTPUT([src/bin/cfgmgr/b10-cfgmgr.py AC_OUTPUT([src/bin/cfgmgr/b10-cfgmgr.py
src/bin/cfgmgr/tests/b10-cfgmgr_test.py
src/bin/cmdctl/cmdctl.py src/bin/cmdctl/cmdctl.py
src/bin/cmdctl/run_b10-cmdctl.sh src/bin/cmdctl/run_b10-cmdctl.sh
src/bin/cmdctl/tests/cmdctl_test src/bin/cmdctl/tests/cmdctl_test
......
SUBDIRS = tests
pkglibexecdir = $(libexecdir)/@PACKAGE@ pkglibexecdir = $(libexecdir)/@PACKAGE@
pkglibexec_SCRIPTS = b10-cfgmgr pkglibexec_SCRIPTS = b10-cfgmgr
......
...@@ -38,7 +38,8 @@ def signal_handler(signal, frame): ...@@ -38,7 +38,8 @@ def signal_handler(signal, frame):
if cm: if cm:
cm.running = False cm.running = False
if __name__ == "__main__": def main():
global cm
try: try:
cm = ConfigManager(DATA_PATH) cm = ConfigManager(DATA_PATH)
signal.signal(signal.SIGINT, signal_handler) signal.signal(signal.SIGINT, signal_handler)
...@@ -53,3 +54,6 @@ if __name__ == "__main__": ...@@ -53,3 +54,6 @@ if __name__ == "__main__":
print("[b10-cfgmgr] Interrupted, exiting") print("[b10-cfgmgr] Interrupted, exiting")
if cm: if cm:
cm.write_config() cm.write_config()
if __name__ == "__main__":
main()
PYTESTS = b10-cfgmgr_test.py
EXTRA_DIST = $(PYTESTS)
# later will have configure option to choose this, like: coverage run --branch
PYCOVERAGE = $(PYTHON)
# test using command-line arguments, so use check-local target instead of TESTS
check-local:
for pytest in $(PYTESTS) ; do \
echo Running test: $$pytest ; \
env PYTHONPATH=$(abs_top_srcdir)/src/lib/python:$(abs_top_builddir)/src/lib/python:$(abs_top_builddir)/src/bin/cfgmgr \
$(PYCOVERAGE) $(abs_srcdir)/$$pytest ; \
done
# Copyright (C) 2010 Internet Systems Consortium.
#
# Permission to use, copy, modify, and distribute this software for any
# purpose with or without fee is hereby granted, provided that the above
# copyright notice and this permission notice appear in all copies.
#
# THE SOFTWARE IS PROVIDED "AS IS" AND INTERNET SYSTEMS CONSORTIUM
# DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL
# INTERNET SYSTEMS CONSORTIUM BE LIABLE FOR ANY SPECIAL, DIRECT,
# INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING
# FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT,
# NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION
# WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
# $Id: cfgmgr_test.py 2126 2010-06-16 14:40:22Z jelte $
#
# Tests for the configuration manager run script
#
import unittest
import os
import sys
class MyConfigManager:
def __init__(self, path):
self._path = path
self.read_config_called = False
self.notify_boss_called = False
self.run_called = False
self.write_config_called = False
self.running = True
def read_config(self):
self.read_config_called = True
def notify_boss(self):
self.notify_boss_called = True
def run(self):
self.run_called = True
def write_config(self):
self.write_config_called = True
class TestConfigManagerStartup(unittest.TestCase):
def test_cfgmgr(self):
# some creative module use;
# b10-cfgmgr has a hypen, so we use __import__
# this also gives us the chance to override the imported
# moculde ConfigManager in it.
b = __import__("b10-cfgmgr")
b.ConfigManager = MyConfigManager
b.main()
self.assertTrue(b.cm.read_config_called)
self.assertTrue(b.cm.notify_boss_called)
self.assertTrue(b.cm.run_called)
self.assertTrue(b.cm.write_config_called)
self.assertTrue(b.cm.running)
b.signal_handler(None, None)
self.assertFalse(b.cm.running)
# TODO: take value from the 'global config module'
# (and rename the .in aay from this file again)
data_path = "@localstatedir@/@PACKAGE@".replace("${prefix}", "@prefix@")
self.assertEqual(data_path, b.DATA_PATH)
# remove the 'module' again, or later tests may fail
# (if it is already present it won't be loaded again)
sys.modules.pop("b10-cfgmgr")
def test_cfgmgr_from_source(self):
tmp_env_var = "/just/some/dir"
env_var = None
if "B10_FROM_SOURCE" in os.environ:
env_var = os.environ["B10_FROM_SOURCE"]
os.environ["B10_FROM_SOURCE"] = tmp_env_var
b = __import__("b10-cfgmgr", globals(), locals())
b.ConfigManager = MyConfigManager
self.assertEqual(tmp_env_var, b.DATA_PATH)
if env_var != None:
os.environ["B10_FROM_SOURCE"] = env_var
sys.modules.pop("b10-cfgmgr")
if __name__ == '__main__':
unittest.main()
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment