Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Kea
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
415
Issues
415
List
Boards
Labels
Service Desk
Milestones
Merge Requests
67
Merge Requests
67
Operations
Operations
Incidents
Packages & Registries
Packages & Registries
Container Registry
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
ISC Open Source Projects
Kea
Commits
c73ca19a
Commit
c73ca19a
authored
May 25, 2012
by
Jelte Jansen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[1455] Added notes about possible optimizations
As per review comment
http://bind10.isc.org/ticket/1455#comment:15
parent
f621147e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
0 deletions
+15
-0
src/lib/python/isc/ddns/logger.py
src/lib/python/isc/ddns/logger.py
+3
-0
src/lib/python/isc/ddns/session.py
src/lib/python/isc/ddns/session.py
+12
-0
No files found.
src/lib/python/isc/ddns/logger.py
View file @
c73ca19a
...
...
@@ -89,6 +89,9 @@ class RRsetFormatter:
This class is designed to delay the conversion until it's explicitly
requested, so the conversion doesn't happen if the corresponding log
message is suppressed because of its log level.
See the note for the ClientFormatter class about overhead tradeoff.
This class shares the same discussion.
"""
def
__init__
(
self
,
rrset
):
self
.
__rrset
=
rrset
...
...
src/lib/python/isc/ddns/session.py
View file @
c73ca19a
...
...
@@ -199,6 +199,12 @@ class UpdateSession:
TTL, and Rdata (if any) of the given RRset are ignored.
RFC2136 Section 2.4.1.
Returns True if the prerequisite is satisfied, False otherwise.
Note: the only thing used in the call to find() here is the
result status. The actual data is immediately dropped. As
a future optimization, we may want to add a find() option to
only return what the result code would be (and not read/copy
any actual data).
'''
_
,
finder
=
datasrc_client
.
find_zone
(
rrset
.
get_name
())
result
,
_
,
_
=
finder
.
find
(
rrset
.
get_name
(),
rrset
.
get_type
(),
...
...
@@ -246,6 +252,12 @@ class UpdateSession:
1 or more RRs).
RFC2136 Section 2.4.4
Returns True if the prerequisite is satisfied, False otherwise.
Note: the only thing used in the call to find_all() here is
the result status. The actual data is immediately dropped. As
a future optimization, we may want to add a find_all() option
to only return what the result code would be (and not read/copy
any actual data).
'''
_
,
finder
=
datasrc_client
.
find_zone
(
rrset
.
get_name
())
result
,
rrsets
,
flags
=
finder
.
find_all
(
rrset
.
get_name
(),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment