Commit ca0a6b8a authored by Francis Dupont's avatar Francis Dupont

[#553] Addressed comments

parent cf1f3fdb
...@@ -500,12 +500,6 @@ public: ...@@ -500,12 +500,6 @@ public:
> >
> IfaceContainer; > IfaceContainer;
/// @brief Constructor.
IfaceCollection() { }
/// @brief Destructor.
~IfaceCollection() { }
/// @brief Begin iterator. /// @brief Begin iterator.
/// ///
/// @return The container sequence begin iterator. /// @return The container sequence begin iterator.
...@@ -583,6 +577,14 @@ private: ...@@ -583,6 +577,14 @@ private:
std::mutex mutex_; std::mutex mutex_;
/// @brief The last interface returned by a lookup method. /// @brief The last interface returned by a lookup method.
///
/// A lookup method first tries the cache: if it matches the cache is
/// returned without an expensive lookup in the container. If it does
/// not match and a value is found in the container the cache is
/// updated with this value.
/// The cache should perform well when active interfaces are a small
/// subset of the whole interface set, or when consecutive packets
/// come from the same interface.
IfacePtr cache_; IfacePtr cache_;
/// @brief The container. /// @brief The container.
......
...@@ -95,7 +95,7 @@ PktFilterInet6::openSocket(const Iface& iface, ...@@ -95,7 +95,7 @@ PktFilterInet6::openSocket(const Iface& iface,
if (setsockopt(sock, IPPROTO_IPV6, IPV6_V6ONLY, if (setsockopt(sock, IPPROTO_IPV6, IPV6_V6ONLY,
(char *)&flag, sizeof(flag)) < 0) { (char *)&flag, sizeof(flag)) < 0) {
close(sock); close(sock);
isc_throw(SocketConfigError, "Can't set IPPROTO_IPV6 option on " isc_throw(SocketConfigError, "Can't set IPV6_V6ONLY option on "
"IPv6 socket."); "IPv6 socket.");
} }
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment