Commit cb91ca85 authored by Marcin Siodelski's avatar Marcin Siodelski
Browse files

[3743] Minor changes in the pkt4.{h,cc} as a result of the review.

Objects passed by reference and todo instead of TODO.
parent c955a585
......@@ -284,7 +284,7 @@ void Pkt4::setType(uint8_t dhcp_type) {
std::string
Pkt4::getLabel() const {
/// @TODO If and when client id is extracted into Pkt4, this method should
/// @todo If and when client id is extracted into Pkt4, this method should
/// the instance member rather than fetch it every time.
ClientIdPtr client_id;
OptionPtr client_opt = getOption(DHO_DHCP_CLIENT_IDENTIFIER);
......@@ -297,7 +297,7 @@ Pkt4::getLabel() const {
}
std::string
Pkt4::makeLabel(const HWAddrPtr hwaddr, const ClientIdPtr client_id,
Pkt4::makeLabel(const HWAddrPtr& hwaddr, const ClientIdPtr& client_id,
const uint32_t transid) {
stringstream label;
label << "hwaddr=[" << (hwaddr ? hwaddr->toText() : "no info")
......
......@@ -128,8 +128,8 @@ public:
/// @param transid - numeric transaction id to include in the string
///
/// @return string with text representation
static std::string makeLabel(const HWAddrPtr hwaddr,
const ClientIdPtr client_id,
static std::string makeLabel(const HWAddrPtr& hwaddr,
const ClientIdPtr& client_id,
const uint32_t transid);
/// @brief Returns text representation of the packet.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment