Commit d0b75afb authored by Thomas Markwalder's avatar Thomas Markwalder
Browse files

[#42, !103] Additional review fixes

    Minor commentary changes.
parent 464ea71b
......@@ -300,12 +300,6 @@ void IfaceMgr::stopDHCPReceiver() {
getPacketQueue4()->clear();
}
void
IfaceMgr::closeSockets(const uint16_t) {
isc_throw(NotImplemented, "closeSockets(family) is obsolete");
}
IfaceMgr::~IfaceMgr() {
// control_buf_ is deleted automatically (scoped_ptr)
control_buf_len_ = 0;
......
......@@ -919,12 +919,6 @@ public:
/// Is used in destructor, but also from Dhcpv4Srv and Dhcpv6Srv classes.
void closeSockets();
/// @brief Closes all IPv4 or IPv6 sockets.
///
/// Obsolete!
/// @throw NotImplemented
void closeSockets(const uint16_t family);
/// @brief Returns number of detected interfaces.
///
/// @return number of detected interfaces
......
......@@ -47,7 +47,7 @@ public:
/// @brief Constructor
///
/// @param queue_type name of this queue's implementation type.
/// @param queue_type logical name of the queue implementation
/// Typically this is assigned by the factory that creates the
/// queue. It is the logical name used to register queue
/// implementations.
......@@ -233,7 +233,7 @@ public:
/// @brief Constructor
///
/// @param queue_type logical name of the queue type
/// @param queue_type logical name of the queue implementation
/// @param queue_capacity maximum number of packets the queue can hold
PacketQueueRing(const std::string& queue_type, size_t capacity)
: PacketQueue<PacketTypePtr>(queue_type) {
......@@ -365,6 +365,7 @@ class PacketQueueRing4 : public PacketQueueRing<Pkt4Ptr> {
public:
/// @brief Constructor
///
/// @param queue_type logical name of the queue implementation
/// @param capacity maximum number of packets the queue can hold
PacketQueueRing4(const std::string& queue_type, size_t capacity)
: PacketQueueRing(queue_type, capacity) {
......@@ -384,6 +385,7 @@ class PacketQueueRing6 : public PacketQueueRing<Pkt6Ptr> {
public:
/// @brief Constructor
///
/// @param queue_type logical name of the queue implementation
/// @param capacity maximum number of packets the queue can hold
PacketQueueRing6(const std::string& queue_type, size_t capacity)
: PacketQueueRing(queue_type, capacity) {
......
......@@ -13,6 +13,9 @@ namespace isc {
namespace dhcp {
PacketQueueMgr4::PacketQueueMgr4() {
// @todo Please forgive magic strings and constants. The default values,
// mechanisms will soon be reworked.
// Register default queue factory
registerPacketQueueFactory("kea-ring4", [](data::ConstElementPtr parameters)
-> PacketQueue4Ptr {
......@@ -28,7 +31,6 @@ PacketQueueMgr4::PacketQueueMgr4() {
return (queue);
});
/// @todo default comes from ?
data::ElementPtr parameters = data::Element::createMap();
parameters->set("queue-type", data::Element::create("kea-ring4"));
parameters->set("capacity", data::Element::create(static_cast<long int>(500)));
......
......@@ -13,6 +13,9 @@ namespace isc {
namespace dhcp {
PacketQueueMgr6::PacketQueueMgr6() {
// @todo Please forgive magic strings and constants. The default values,
// mechanisms will soon be reworked.
// Register default queue factory
registerPacketQueueFactory("kea-ring6", [](data::ConstElementPtr parameters)
-> PacketQueue6Ptr {
......@@ -28,7 +31,6 @@ PacketQueueMgr6::PacketQueueMgr6() {
return (queue);
});
// @todo default comes from ?
data::ElementPtr parameters = data::Element::createMap();
parameters->set("queue-type", data::Element::create("kea-ring6"));
parameters->set("capacity", data::Element::create(static_cast<long int>(500)));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment