Commits · 0043299b12a87ddbbf6334a81b86eb2cf1147dd3 · ISC Open Source Projects / Kea

25 Jul, 2010 1 commit

removed redundant null checks before delete. · 0043299b

JINMEI Tatuya authored Jul 25, 2010

should be trivial enough, skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2604 e5f2f494-b856-4b98-b285-d166d9295462

0043299b

22 Jul, 2010 8 commits

cleanup: removed unnecessary lexical_cast. · f7d5d843

JINMEI Tatuya authored Jul 22, 2010

should be trivial enough, skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2583 e5f2f494-b856-4b98-b285-d166d9295462

f7d5d843

cleanup: removed <config.h> because we don't use UNUSED_PARAM in this file. · 3cc88bfa
JINMEI Tatuya authored Jul 22, 2010
```
(trivial)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2582 e5f2f494-b856-4b98-b285-d166d9295462
```
3cc88bfa

cleanup: removed <config.h> because we now don't use UNUSED_PARAM. · 92a66728

JINMEI Tatuya authored Jul 22, 2010

quite trivial, skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2581 e5f2f494-b856-4b98-b285-d166d9295462

92a66728

constify. · 4c3dd96d

JINMEI Tatuya authored Jul 22, 2010

(trivial)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2580 e5f2f494-b856-4b98-b285-d166d9295462

4c3dd96d

added a brief comment about unistd.h · c982ccbb

JINMEI Tatuya authored Jul 22, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2579 e5f2f494-b856-4b98-b285-d166d9295462

c982ccbb

worked around another brokenness of sunstudio. · c2258c4e

JINMEI Tatuya authored Jul 22, 2010

(may not be super trivial, but let me commit it to trunk to make the build/test
succeed.  I'll ask a quick sanity check on jabber)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2578 e5f2f494-b856-4b98-b285-d166d9295462

c2258c4e

added redundant top-level consts in declarations to help broken sunstudio behavior. · a82c729c

JINMEI Tatuya authored Jul 22, 2010

hopefully trivial enough, so skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2577 e5f2f494-b856-4b98-b285-d166d9295462

a82c729c

removed a redundant comman after the last member of enum. · 53548932

JINMEI Tatuya authored Jul 22, 2010

should be trivial enough, skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2574 e5f2f494-b856-4b98-b285-d166d9295462

53548932

21 Jul, 2010 12 commits

corrected indentation. · 71dcd00e

JINMEI Tatuya authored Jul 21, 2010

minor, no review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2570 e5f2f494-b856-4b98-b285-d166d9295462

71dcd00e

fixed a typo in a comment. · 4eb24414

JINMEI Tatuya authored Jul 21, 2010

too trivial, skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2569 e5f2f494-b856-4b98-b285-d166d9295462

4eb24414

updated the test reflecting the fact we disabled notify · 79a6c20a

JINMEI Tatuya authored Jul 21, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2563 e5f2f494-b856-4b98-b285-d166d9295462

79a6c20a

some grammar/editorial fixes · 538e33c1

JINMEI Tatuya authored Jul 21, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2561 e5f2f494-b856-4b98-b285-d166d9295462

538e33c1

minor update on a comment (about how rrclass is passed) · 21e7e5c2

JINMEI Tatuya authored Jul 21, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2560 e5f2f494-b856-4b98-b285-d166d9295462

21e7e5c2

commented about local placeholders of {UDP/TCP}Endpoints. · 01d4f42c
JINMEI Tatuya authored Jul 21, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2559 e5f2f494-b856-4b98-b285-d166d9295462
```
01d4f42c
commented about instantiation policy for the IOSocket class. · c994b2e9
JINMEI Tatuya authored Jul 21, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2558 e5f2f494-b856-4b98-b285-d166d9295462
```
c994b2e9

editorial fix · 4c27eae3

JINMEI Tatuya authored Jul 21, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2557 e5f2f494-b856-4b98-b285-d166d9295462

4c27eae3

removed unnecessary forward declaration, and added a comment about the remaining one. · 4601b4d2
JINMEI Tatuya authored Jul 21, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2556 e5f2f494-b856-4b98-b285-d166d9295462
```
4601b4d2

- renamed a variable: s/is_axfr_connection_established/xfrout_connected/ as suggested in review · dc0e2cde

JINMEI Tatuya authored Jul 21, 2010

- commented on how a customized AbstractXfroutClient object is used


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2555 e5f2f494-b856-4b98-b285-d166d9295462

dc0e2cde

added notes about protected destructors in base classes. · 252f19a1
JINMEI Tatuya authored Jul 21, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2554 e5f2f494-b856-4b98-b285-d166d9295462
```
252f19a1

avoid using limited broadcast address (all 1 address) for a failure test case. · 05368c56

JINMEI Tatuya authored Jul 21, 2010

on some systems this won't fail as expected.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2553 e5f2f494-b856-4b98-b285-d166d9295462

05368c56

20 Jul, 2010 9 commits

include base64 headers to subsequently include necessary boost header files,... · ee16d6b5

JINMEI Tatuya authored Jul 20, 2010

include base64 headers to subsequently include necessary boost header files, instead of including them from our own header files directly.
this will fix build problems in different versions of boost.

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2552 e5f2f494-b856-4b98-b285-d166d9295462

ee16d6b5

additioal review comment: explained the (x + 7) & ~7 idiom. · 27c12d61

JINMEI Tatuya authored Jul 20, 2010

and some minor editorial nits.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac256@2546 e5f2f494-b856-4b98-b285-d166d9295462

27c12d61

forgot to add a new test data file to EXTRA_DIST · 551e9a0b
Jelte Jansen authored Jul 20, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2545 e5f2f494-b856-4b98-b285-d166d9295462
```
551e9a0b

whoops, forgot to update one test · 52f35abe

Jelte Jansen authored Jul 20, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2543 e5f2f494-b856-4b98-b285-d166d9295462

52f35abe

review comment: describe why the interfaces under util should be hidden. · b2de2340
JINMEI Tatuya authored Jul 20, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac256@2539 e5f2f494-b856-4b98-b285-d166d9295462
```
b2de2340

Minor grammar fixes in comments. · 65166f58

Evan Hunt authored Jul 20, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2538 e5f2f494-b856-4b98-b285-d166d9295462

65166f58

addressed review comments: use the size of table for range check instead of a... · 6fba3157

JINMEI Tatuya authored Jul 20, 2010

addressed review comments: use the size of table for range check instead of a fixed magic number; style consistency in assertion.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac256@2537 e5f2f494-b856-4b98-b285-d166d9295462

6fba3157

addressed review comments: missing .h in _SOURCES. · baf673f1

JINMEI Tatuya authored Jul 20, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac256@2536 e5f2f494-b856-4b98-b285-d166d9295462

baf673f1

addressed review comments · 2de55f89

JINMEI Tatuya authored Jul 20, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac256@2535 e5f2f494-b856-4b98-b285-d166d9295462

2de55f89

19 Jul, 2010 2 commits

removed one more "redundant" -1 arg to file.read(). · af94c66b

JINMEI Tatuya authored Jul 19, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac284@2534 e5f2f494-b856-4b98-b285-d166d9295462

af94c66b

addressed comments from trac review · 9cf201a5

Jelte Jansen authored Jul 19, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac284@2532 e5f2f494-b856-4b98-b285-d166d9295462

9cf201a5

17 Jul, 2010 1 commit
- addressed review comments: describe the intent of Base32HexTest.decodeMap · 039843d5
  JINMEI Tatuya authored Jul 17, 2010
```
in more detail.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac256@2528 e5f2f494-b856-4b98-b285-d166d9295462
```
  039843d5
16 Jul, 2010 7 commits

- changed 'if 0'ed tests to DISABLED_xxx · f6161c16

JINMEI Tatuya authored Jul 16, 2010

  (except tests for base32, which is being addressed)
- also made trivial style fixes on brace positions

This is suggested in review comments for trac #256.  Reasonable, but not
related to the main issue of that ticket, so I'm making the changes right
now directly to trunk.  Pretty trivial, so skipping explicit review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2523 e5f2f494-b856-4b98-b285-d166d9295462

f6161c16

suggested changes: · ce44a279

JINMEI Tatuya authored Jul 16, 2010

 - exit non 0 code on failure
 - be clearer about additional tests in TODO
 - style: fold a long line in the test


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac277@2522 e5f2f494-b856-4b98-b285-d166d9295462

ce44a279

1. Raise CmdctlException instead of exiting when port is used by other... · c08819a7

Likun Zhang authored Jul 16, 2010

1. Raise CmdctlException instead of exiting when port is used by other processes. 2. Make error message be more accurate.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac277@2521 e5f2f494-b856-4b98-b285-d166d9295462

c08819a7

update AM_CPPFLAGS · 8c60a2c5

JINMEI Tatuya authored Jul 16, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2520 e5f2f494-b856-4b98-b285-d166d9295462

8c60a2c5

add AM_CPPFLAGS to run_unittests_CPPFLAGS · 39aef3ab

JINMEI Tatuya authored Jul 16, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2519 e5f2f494-b856-4b98-b285-d166d9295462

39aef3ab

missing -I options · 5f7f70fc

JINMEI Tatuya authored Jul 16, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2518 e5f2f494-b856-4b98-b285-d166d9295462

5f7f70fc

s/#include "header"/#include <[path/]header>/ (trac #291) · 5f173987
JINMEI Tatuya authored Jul 16, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2517 e5f2f494-b856-4b98-b285-d166d9295462
```
5f173987