1. 15 Jan, 2020 3 commits
  2. 23 Oct, 2019 2 commits
    • Thomas Markwalder's avatar
      [#900,!561] Addressed review comments · c75a7c10
      Thomas Markwalder authored
      src/lib/dhcp/libdhcp++.cc
          Cleaned up necessary exception decls
      
      src/lib/dhcp/option.h
          Added commentary for SkipThisOptionError
      
      src/lib/dhcp/option_definition.cc
          Cleaned up unnecessary exception decls
      
      src/lib/dhcp/option_string.cc
          Replaced NULL with nul
      
      src/lib/testutils/gtest_utils.h
          Added emissions of exception type name
      c75a7c10
    • Thomas Markwalder's avatar
      [#900,!561] kea-dhcp4/6 now quietly drop empty or all-null string options · a917e4ae
      Thomas Markwalder authored
      src/lib/dhcp/option.h
          class SkipThisOptionError - new exception type
      
      src/lib/dhcp/libdhcp++.cc
          LibDHCP::unpackOptions4()
          LibDHCP::unpackOptions6() - explicitly catches and handles
          SkipThisOptionError expceptions
      
      src/lib/dhcp/option_definition.cc
          OptionDefinition::optionFactory() - now rethrows SkipThisOptionError
      
      src/lib/dhcp/option_int.h
          OptionInt::unpack() - altered ambiguous exception text
      
      src/lib/dhcp/option_int_array.h
          OptionIntArray::unpack() - altered ambiguous exception text
      
      src/lib/dhcp/option_string.cc
          OptionString::unpack() - now throws SkipThisOptionError if option, once
          trimmed, is empty
      
      src/lib/dhcp/tests/option_string_unittest.cc
          Updated tests
      
      src/lib/dhcp/tests/pkt4_unittest.cc
          TEST_F(Pkt4Test, testSkipThisOptionError) - new test
      
      src/lib/dhcp/tests/pkt6_unittest.cc
          TEST_F(Pkt6Test, testSkipThisOptionError) - new test
      
      src/lib/dhcpsrv/tests/cfg_option_unittest.cc
          Updated expected exception text
      
      src/lib/testutils/gtest_utils.h
          Added two macros to emit exception info on throws.
          #define EXPECT_NO_THROW_LOG(statement)
          #define ASSERT_NO_THROW_LOG(statement)
      a917e4ae
  3. 21 Jun, 2019 2 commits
  4. 28 May, 2019 1 commit
  5. 18 Apr, 2019 1 commit
  6. 16 Jan, 2019 1 commit
    • Thomas Markwalder's avatar
      [5440] libdhcp++ now quietly drops empty host name options from inbound packets · 8d1f1d7f
      Thomas Markwalder authored
      src/lib/dhcp/libdhcp++.cc
          LibDHCP::unpackOptions4() - added logic to drop Host Name option
          if when empty
      
      src/lib/dhcp/tests/libdhcp++_unittest.cc
          TEST_F(LibDhcpTest, emptyHostName)  - new unit test
      
      src/bin/dhcp4/dhcp4_srv.cc
          Dhcpv4Srv::processHostnameOption() - removed prior 5440 logic
          to ignore blank hostname options
      
      src/bin/dhcp4/dhcp4_messages.mes
          Removed prior 5440 message
      8d1f1d7f
  7. 19 Dec, 2018 1 commit
  8. 10 Sep, 2018 1 commit
  9. 06 Mar, 2018 1 commit
    • Thomas Markwalder's avatar
      [5551] Addressed review comments · b791aaef
      Thomas Markwalder authored
          Added commentary, updated sub-options unpacking,
          and added support for skip logic to kea-dhcp6.
      
      src/lib/dhcp/option.h
          Added detail to SkipRemainingOptionsError commentary
      
      src/lib/dhcp/libdhcp++.cc
          LibDHCP::unpackVendorOptions4()
          LibDHCP::unpackVendorOptions6()
      
      src/lib/dhcp/tests/pkt4_unittest.cc
          TEST_F(Pkt4Test, unpackVendorMalformed) - updated for
          new exception type
      
          TEST_F(Pkt4Test, truncatedVendorLength) - removed
          extraneous byte streams
      
      src/lib/dhcp/tests/pkt6_unittest.cc
          TEST_F(Pkt6Test, unpackVendorMalformed) - updated for
          new exception type
      
          TEST_F(Pkt6Test, truncatedVendorLength) - new test for
          truncated vendor options
      
      src/lib/dhcp/tests/pkt_captures.h
      src/lib/dhcp/tests/pkt_captures.cc
          isc::dhcp::Pkt6Ptr captureSolicitWithVIVSO()
          isc::dhcp::Pkt6Ptr captureSolicitWithTruncatedVIVSO() -
          new captured packets
      
      src/bin/dhcp6/dhcp6_messages.mes
          DHCP6_PACKET_OPTIONS_SKIPPED - new log message
      
      src/bin/dhcp6/dhcp6_srv.cc
          Dhcpv6Srv::processPacket() - added explicit catch of
          SkipRemainingOptionsError to allow processing the packet
      
      src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
          TEST_F(Dhcpv6SrvTest, truncatedVIVSO) - new test to verify
          server's ability to handle SkipRemainingOptionsError
      b791aaef
  10. 02 Mar, 2018 2 commits
  11. 31 Jan, 2018 1 commit
  12. 30 Jan, 2018 1 commit
  13. 25 Sep, 2017 1 commit
  14. 20 Sep, 2017 3 commits
  15. 23 Jul, 2017 1 commit
  16. 26 Oct, 2016 1 commit
  17. 10 Jun, 2016 1 commit
  18. 25 May, 2016 1 commit
  19. 19 May, 2016 1 commit
  20. 18 May, 2016 2 commits
  21. 17 May, 2016 1 commit
  22. 12 May, 2016 1 commit
  23. 16 Dec, 2015 1 commit
  24. 01 Dec, 2015 1 commit
  25. 24 Nov, 2015 1 commit
  26. 23 Nov, 2015 4 commits
  27. 13 Nov, 2015 1 commit
  28. 31 Oct, 2015 1 commit
  29. 24 Jun, 2015 1 commit