Still have lots to do.
Some of these marked with TODO indicating needing further work
(but better than it was before).

... to conform to coding standards.

See bug #2367 for the fix-scaffolding.py tool.

- Added V6ADDRESS_LEN and V4ADDRESS_LEN
- Removed unnecessary parameters to Option constructors
- Many missing Doxygen comments added
- using sizeof(uintXX_t) instead of 2 and 4 in pack()/unpack()
- Many other smaller changes.

- buffer type changed: char => uint8_t
- removed unnecessary statements in Makefile.am

- similar to from_string() used in underlying boost::asio::address

its counter intuitive behavior and surprising results rarely justify
the introduction, and, in fact, it caused a regression:
http://git.bind10.isc.org/~tester/builder/BIND10/20111007175000-Solaris10-sparc-Sunstudio/logs/unittests.out
Apparently the reason why this was introduced is to assist the comparison
tests used in a dhcp6 test.  To work this around I replaced the test code
using toText().  The right solution is to introduce operator<< for IOAddress,
which will satisfy gtest (we already have operator== so EXPECT_EQ should
work otherwise).

... which causes Solaris to complain - loudly.

if not in forwarder mode.

* Extend logging in IOFetch (and add message definitions)
* Update buffer size setting for UDP socket
* remove spaces at end of lines in other files

IOFetch is a general upstream "fetch" class that should be able to
operate over TCP or UDP.  Related changes have been made in the
associated classes.  So far, only the unit tests for a UDP fetch
have been made (and passed).

Fix some typos, wrong doxygen tags, replace some html tags,
fix some parameters, add missing parameters, add some TODOs (this
is not complete).

In particular:
* Use Use asiolink abstractions instead of Boost::asio directly
* Add cross-section checks (answer/question v authority)
* Extended description of bailiwick
* Methods added to isc::dns::Message and asiolink::IOAddress

briefly talked about it on jabber, no one opposed to it, Jeremy explicitly
agreed.  changes are trivial themselves, so no explicit review.

 ../../../src/lib/asiolink/ioaddress.h:37: warning: 'class asiolink::IOAddress' has virtual functions but non-virtual destructor

so remove "virtual"

(via jabber)


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac327@3508 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac327@3310 e5f2f494-b856-4b98-b285-d166d9295462

asiolink.cc are now in multiple files (ioaddress.h, iosocket.h, etc).
Also removed some shared_ptr's that weren't really needed in tcpdns
and udpdns.  This work isn't done yet, but committing now to simplify
the review a bit.



git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac327@3150 e5f2f494-b856-4b98-b285-d166d9295462