GitLab

copied (with some modification) object holder and test memory segment
from #2100.  They should be unified when this branch and #2100 are merged.

also now make sure all linked RdataSets are released.

...instead of give its type as a class template parameter and instantiate
it within the tree.  it won't work (well) for ZoneData, because we need
to know the RR class to delete RdataSet (which is the data type for
ZoneData tree), but there's no way to tell the RR class about it.
A good side effect of this change is that we now don't have to link
the memory segment for the tree and its nodes with the zone data
(although in practice it's quite likely to use the same segment for
all of them).

I also updated setData() (further from #2100); it now doesn't even delete
any existing data.  This is partly relaetd to the above change on
deleter - we cannot instantiate the deleter within this method.  We could
pass the deleter as a parameter, but, actually, in the case of ZoneData
we wouldn't have to delete the data; when setData() encounters existing
data, it's more likely that ZoneData tries to extend the RdataSet list.
It makes more sense to let ZoneData manage all data, including when to
delete them.

(although not absolutely necessary) I also changed the type of deleter
in the domain tree test to highlight we could use a plain old function
instead of a functor object.

change size is big, but most of the changes are trivial conversion
from something like <T, DT> to <T>.

so we can reuse the same data for each fixture.

added getOrigiNode() to get access to the origin node.

so I can use the LabelSequence objects in EXPECT_EQ().
also fixed a minor error in doxygen comment in equals().

right now, only simple create/destry are supported (and they are not 100% safe
yet).

not directly related to this branch, but we'll eventually need this.
the change is purely local to the domaintree.h; no need to update tests.

discussed via jabber

noted on jabber

Some review on jabber. If necessary, jelte can update later.

okayed by muks

and updated entries for style (even old entries).

since not backward incompatible or operational changes.

This is only needed so I don't have differences later.
This won't be needed once we stop including generated docs in the
source tree.

as suggested in review.
also updated getRRSIGWithRdataCount() to generate the data from write,
not from text as I found it took much longer time if I did it from text
(which is simpler).  with large number of RRSIGs it's noticeable and not
good for unittests to run frequently.

it was indeed not expected to be copyable.  making this explicit would help
prevent accidental misuse.
as suggested in review.

referring to #2066.