1. 29 Oct, 2019 1 commit
  2. 23 Oct, 2019 1 commit
    • Thomas Markwalder's avatar
      [#900,!561] kea-dhcp4/6 now quietly drop empty or all-null string options · a917e4ae
      Thomas Markwalder authored
      src/lib/dhcp/option.h
          class SkipThisOptionError - new exception type
      
      src/lib/dhcp/libdhcp++.cc
          LibDHCP::unpackOptions4()
          LibDHCP::unpackOptions6() - explicitly catches and handles
          SkipThisOptionError expceptions
      
      src/lib/dhcp/option_definition.cc
          OptionDefinition::optionFactory() - now rethrows SkipThisOptionError
      
      src/lib/dhcp/option_int.h
          OptionInt::unpack() - altered ambiguous exception text
      
      src/lib/dhcp/option_int_array.h
          OptionIntArray::unpack() - altered ambiguous exception text
      
      src/lib/dhcp/option_string.cc
          OptionString::unpack() - now throws SkipThisOptionError if option, once
          trimmed, is empty
      
      src/lib/dhcp/tests/option_string_unittest.cc
          Updated tests
      
      src/lib/dhcp/tests/pkt4_unittest.cc
          TEST_F(Pkt4Test, testSkipThisOptionError) - new test
      
      src/lib/dhcp/tests/pkt6_unittest.cc
          TEST_F(Pkt6Test, testSkipThisOptionError) - new test
      
      src/lib/dhcpsrv/tests/cfg_option_unittest.cc
          Updated expected exception text
      
      src/lib/testutils/gtest_utils.h
          Added two macros to emit exception info on throws.
          #define EXPECT_NO_THROW_LOG(statement)
          #define ASSERT_NO_THROW_LOG(statement)
      a917e4ae
  3. 09 Mar, 2018 1 commit
  4. 06 Mar, 2018 1 commit
    • Thomas Markwalder's avatar
      [5551] Addressed review comments · b791aaef
      Thomas Markwalder authored
          Added commentary, updated sub-options unpacking,
          and added support for skip logic to kea-dhcp6.
      
      src/lib/dhcp/option.h
          Added detail to SkipRemainingOptionsError commentary
      
      src/lib/dhcp/libdhcp++.cc
          LibDHCP::unpackVendorOptions4()
          LibDHCP::unpackVendorOptions6()
      
      src/lib/dhcp/tests/pkt4_unittest.cc
          TEST_F(Pkt4Test, unpackVendorMalformed) - updated for
          new exception type
      
          TEST_F(Pkt4Test, truncatedVendorLength) - removed
          extraneous byte streams
      
      src/lib/dhcp/tests/pkt6_unittest.cc
          TEST_F(Pkt6Test, unpackVendorMalformed) - updated for
          new exception type
      
          TEST_F(Pkt6Test, truncatedVendorLength) - new test for
          truncated vendor options
      
      src/lib/dhcp/tests/pkt_captures.h
      src/lib/dhcp/tests/pkt_captures.cc
          isc::dhcp::Pkt6Ptr captureSolicitWithVIVSO()
          isc::dhcp::Pkt6Ptr captureSolicitWithTruncatedVIVSO() -
          new captured packets
      
      src/bin/dhcp6/dhcp6_messages.mes
          DHCP6_PACKET_OPTIONS_SKIPPED - new log message
      
      src/bin/dhcp6/dhcp6_srv.cc
          Dhcpv6Srv::processPacket() - added explicit catch of
          SkipRemainingOptionsError to allow processing the packet
      
      src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
          TEST_F(Dhcpv6SrvTest, truncatedVIVSO) - new test to verify
          server's ability to handle SkipRemainingOptionsError
      b791aaef
  5. 27 Nov, 2017 1 commit
  6. 23 Jul, 2017 2 commits
  7. 12 Apr, 2017 1 commit
  8. 02 Feb, 2017 1 commit
  9. 14 Dec, 2016 1 commit
  10. 06 Sep, 2016 1 commit
  11. 08 Jul, 2016 1 commit
  12. 19 May, 2016 1 commit
  13. 06 Apr, 2016 1 commit
  14. 04 Apr, 2016 1 commit
  15. 16 Dec, 2015 1 commit
  16. 15 Dec, 2015 1 commit
    • Thomas Markwalder's avatar
      [4247] Pkt6 MAC extraction now sets HWAddr::source_ to the appropriate value · d7433e8d
      Thomas Markwalder authored
      src/lib/dhcp/pkt.cc
          Pkt::getMAC(uint32_t hw_addr_src)
              sets HwAddr.source_ to HWADDR_SOURCE_RAW if appropriate
      
          Pkt::getMACFromIPv6(const isc::asiolink::IOAddress& addr)
              sets HwAddr.source_ to HWADDR_SOURCE_IPV6_LINK_LOCAL
      
      src/lib/dhcp/pkt6.cc
          Pkt6::getMACFromDUID()
              sets HwAddr.source_ to HWADDR_SOURCE_DUID
      
          Pkt6::getMACFromIPv6RelayOpt()
              sets HwAddr.source_ to HWADDR_SOURCE_CLIENT_ADDR_RELAY_OPTION;
      
          Pkt6::getMACFromDocsisModem()         sets HwAddr.source_ to HWADDR_SOURCE_DOCSIS_MODEM;
      
          Pkt6::getMACFromDocsisCMTS()
              sets HwAddr.source_ to HWADDR_SOURCE_DOCSIS_CMTS;
      
          Pkt6::getMACFromRemoteIdRelayOption()
              sets HwAddr.source_ to HWADDR_SOURCE_REMOTE_ID;
      
      src/lib/dhcp/tests/pkt6_unittest.cc
          Added checks for correct HWAddr::source_ values to the following tests:
          TEST_F(Pkt6Test, getMAC)
          TEST_F(Pkt6Test, getMAC)
          TEST_F(Pkt6Test, getMACFromIPv6LinkLocal_direct)
          TEST_F(Pkt6Test, getMACFromIPv6LinkLocal_singleRelay)
          TEST_F(Pkt6Test, getMACFromIPv6LinkLocal_multiRelay)
          TEST_F(Pkt6Test, getMACFromIPv6RelayOpt_singleRelay)
          TEST_F(Pkt6Test, getMACFromIPv6RelayOpt_multipleRelay)
          TEST_F(Pkt6Test, getMACFromDUID)
          TEST_F(Pkt6Test, getMACFromDUID)
          TEST_F(Pkt6Test, getMAC_DOCSIS_Modem)
          TEST_F(Pkt6Test, getMAC_DOCSIS_CMTS)
          TEST_F(Pkt6Test, getMACFromRemoteIdRelayOption)
      d7433e8d
  17. 11 Dec, 2015 1 commit
  18. 31 Oct, 2015 1 commit
  19. 26 Oct, 2015 1 commit
  20. 21 Oct, 2015 1 commit
  21. 08 Oct, 2015 1 commit
  22. 24 Jun, 2015 1 commit
  23. 19 Jun, 2015 1 commit
  24. 18 Jun, 2015 1 commit
  25. 05 Jun, 2015 1 commit
  26. 20 May, 2015 1 commit
  27. 19 May, 2015 3 commits
  28. 18 May, 2015 2 commits
  29. 12 May, 2015 1 commit
  30. 13 Mar, 2015 1 commit
  31. 10 Mar, 2015 1 commit
  32. 05 Mar, 2015 1 commit
  33. 03 Mar, 2015 1 commit
  34. 27 Jan, 2015 2 commits
  35. 31 Dec, 2014 1 commit