- that's where the production code is

 - will need to revert this and actually implement in separate MR

Thomas Markwalder authored Nov 11, 2021 and Tomek Mrugalski committed Nov 17, 2021

For now The pgsql cb hook library builds but does not get installed.

src/hooks/dhcp/pgsql_cb/Makefile.am
    Disabled installation of libdhcp_pgsql_cb

Thomas Markwalder authored Nov 11, 2021 and Tomek Mrugalski committed Nov 17, 2021

new file:   src/lib/util/triplet.h

Thomas Markwalder authored Nov 10, 2021 and Tomek Mrugalski committed Nov 17, 2021

src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.*
    Removed Triplet binding functions (supported directly by
    PsqlBindArray)

    Commented out myriad of currently unused function arguments
    Fixed missing return errors

src/hooks/dhcp/pgsql_cb/tests/pgsql_cb_impl_unittest.cc
    Removed problematic dummy schema stuff, now reliably uses
    full schema like all other Postgresql unit tests

    Removed triplet binding function tests

Thomas Markwalder authored Nov 10, 2021 and Tomek Mrugalski committed Nov 17, 2021

src/lib/pgsql/pgsql_exchange.*
    PsqlBindArray::add(const Triplet<uint32_t>& triplet)
    PsqlBindArray::addMin(const Triplet<uint32_t>& triplet)
    PsqlBindArray::addMax(const Triplet<uint32_t>& triplet) -
    new functions for storing Triplets

src/lib/pgsql/tests/pgsql_exchange_unittest.cc
    TEST(PsqlBindArray, addTriplet) - new test

Thomas Markwalder authored Nov 10, 2021 and Tomek Mrugalski committed Nov 17, 2021

    renamed:    src/lib/dhcpsrv/triplet.h -> src/lib/util/triplet.h

    modified:
    src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.h
    src/hooks/dhcp/pgsql_cb/tests/pgsql_cb_impl_unittest.cc
    src/lib/cc/simple_parser.cc
    src/lib/cc/simple_parser.h
    src/lib/dhcpsrv/Makefile.am
    src/lib/dhcpsrv/client_class_def.cc
    src/lib/dhcpsrv/client_class_def.h
    src/lib/dhcpsrv/network.h
    src/lib/dhcpsrv/parsers/base_network_parser.cc
    src/lib/dhcpsrv/parsers/client_class_def_parser.cc
    src/lib/dhcpsrv/subnet.h
    src/lib/dhcpsrv/tests/Makefile.am
    src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
    src/lib/dhcpsrv/tests/alloc_engine6_unittest.cc
    src/lib/dhcpsrv/tests/alloc_engine_utils.cc
    src/lib/dhcpsrv/tests/cfg_shared_networks4_unittest.cc
    src/lib/dhcpsrv/tests/cfg_shared_networks6_unittest.cc
    src/lib/dhcpsrv/tests/cfg_subnets4_unittest.cc
    src/lib/dhcpsrv/tests/cfg_subnets6_unittest.cc
    src/lib/dhcpsrv/tests/client_class_def_parser_unittest.cc
    src/lib/dhcpsrv/tests/shared_network_unittest.cc
    src/lib/dhcpsrv/tests/srv_config_unittest.cc
    src/lib/dhcpsrv/tests/subnet_unittest.cc
    src/lib/dhcpsrv/tests/triplet_unittest.cc
    src/lib/util/Makefile.am

 - to be added back in #96

 - to be reinstantiated back in #95

 147 more to go...

 - amNull(), getInteger<T>, getType()