GitLab

src/lib/testutils/dhcp_test_lib.sh.in
    renamed kill_processes to kill_processes_by_name
    replaced call to kill_pids with call to kill_processes_by_name

Minor updates to the commentary for get_pid function.

Removed Daemon::init() method, improved server log message
descpriptions, and minor typos.

src/lib/testutils/dhcp_test_lib.sh.in
    - server_pid_file_test() - common test for any server
    to verify PID file management

src/bin/d2/tests/d2_process_tests.sh.in
    remmoved duplicate_server_start_test
    now calls server_pid_file_test

Added PID file creation to DHCP4
    src/bin/dhcp4/dhcp4_messages.mes
    -  added log DHCP4_ALREADY_RUNNING

    src/bin/dhcp4/main.cc
    - added logic to create the PID and catch
    exception specific to PID conflict

    src/bin/dhcp4/tests/Makefile.am
    - exports KEA_PIDFILE_DIR

    src/bin/dhcp4/tests/dhcp4_process_tests.sh.in
    - added call to server_pid_file_test

    src/bin/dhcp4/tests/dhcp4_unittests.cc
    - main(int argc, char* argv[])
    sets env var KEA_PIDFILE_DIR

src/lib/dhcpsrv/daemon.c/h
    Daemon::Daemon() - Constructor will now override the default PID
    directory with the value of env variable KEA_PIDFILE_DIR.  This
    provides a simple means to alter the value for tests.

    Added am_file_author_ flag so Daemon instances will only delete
    a file they have written.

src/lib/testutils/dhcp_test_lib.sh.in
    - verify_server_pid() - new function which verifies that a server has a PID file
    and that it contains the server's PID, and that the process is alive.

src/bin/keactrl/tests/Makefile.am
    - added export of KEA_PIDFILE_DIR to override default PID directory during tests

Added PID file creation to D2
    src/bin/d2/d_controller.cc
    - DControllerBase::launch() - Added block to createPIDFile()

    -DControllerBase::parseArgs() Replaced call to Daemon::init()
    with call to Daemon::setConfigFile()

    src/bin/d2/tests/Makefile.am
    - added export of KEA_PIDFILE_DIR to override default PID directory during tests

    src/bin/d2/tests/d2_process_tests.sh.in
    - dupcliate_server_start_test() - new test which verifies that D2 cannot be
    started twice (with the same configuration file)

    src/bin/d2/tests/d2_unittests.cc
    - main(int argc, char* argv[]) sets environment variable KEA_PIDFILE_DIR
     to override default PID diretory during tests

src/lib/util/pid_file.cc/h
src/lib/util/tests/pid_file_unittest.cc
    Changed PIDFile::check() to return either the PID contained in the PID file
    if the process is alive, or 0, rather than bool.  This permits callers
    to see/log the PID.

 - Daemon::getVersion() added
 - exists => exits in docs
 - fixed comment in dhcp_test_lib.sh.in

There is a new function used in keactrl tests which waits for the server
to shutdown, rather than check if it is down already. This is to avoid
race condition when the process may not completely terminate when we
check that it is.

Without that change the name of the process will be truncated if the
command line to start the process is out of bounds of the window size.
When running unit tests on the build farm there is in fact no window so
the ps function wouldn't find a pid of Kea and the shell-based tests
would fail.