GitLab

update the test case and log message accordingly.

the users of this method only need the set behavior, and the previous code
actually didn't swap them as expected anyway.

it's a topic of #2363, but the change is small and is better to be fixed
here because it would cause conflict.

the latter will soon be deprecated.

they are not expected to be copied, and I actually had a bug due to an
accidental copy.  Making it non copyable will help avoid such bugs.

auth_srv test's clientList tests are now converted to clients manager's test.
("holder" tests).

this will help corner case considerations of it being NULL

this way we can avoid having a situtation that it's NULL.

A few more checks in test
cleaned up added headers
reordered log message file

from AuthSrv:: (in auth_srv.h) to isc:datasrc:: (in client_list.h), the previous location wasn't really relevant now that it is used elsewhere, and this seemed the most logical location

See ticket #2366 for details.

Okayed by muks on jabber.

Note that no test checked this and I don't introduce any test
since I am pretty sure this code will no exist in any production
version of a resolver (since won't limit IN only).

(it is now sync.h, which was already included)

Acked on jabber by muks

Conflicts:
	src/lib/util/threads/tests/lock_unittest.cc

solaris's pthread_cond_destroy doesn't seem to fail reliably in this case
as the test expects.