GitLab

It was obviously forgotten (and cppcheck complained).

In this case, the user should be aware of the error as much as possible.
In case of MANY_ERRORS, we can't do this, exception is able to handle
just one error.

Instead of file name. And use it for some of the tests, to avoid
juggling with files.

Reject invalid parameters and invalid attempts to load twice.

By catching all exceptions. It is questionable, if we want to do it that
way, but it seems to work at least for now.

Generate several broken input and see all of them fail. Also check they
continue to parse or not according to parameters.

Tested at least on the domain names. There is no known Rdata type
implementation handling relative names right now.

As we pass exactly one RR each time, RRset is overkill. We just pass
bunch of parameters to the callback.

It seemed the wrong pushSource was used due to some automatic
conversion. Also, it complained it couldn't find the file, because a
slash was missing (and nobody noticed before).

The tentative interface of the MasterLoader was missing a callback to
add RRsets.

Also, include some small changes to the interface - pass RRClass as
reference and have DEFAULT options value for no special options.

an empty qstring previously caused an exception, which is a clear bug
and should be fixed.  nul-terminating string regions is an extension,
but I found it useful when implementing RDATA parsers.