GitLab

NO_SUCH_ZONE.

as it's not really about availability anymore.

also refactored the code to better clarify the code flow.

are still ignored.

in that case.  also log that event.  added a test case for it.

of the same name/type when they are different (unusual for modern zones
but possible).  added test case for it, and for that purpose added sqlite3
test data and refactored the test framework a bit.

- log client's address (needed to update _guess_remote also)
- log xfr type (currently it's always 'AXFR', but we'll soon support IXFR)
- log the event of quote failure

XfroutSession().  The original code was already buggy in this sense, but
with the newer data source API it will be a bit more likely to happen
due to the generality of the API, so it would make sense to fix it here.

one question.

can happen from a broken data source)

instead of the old API.  Now we can completely drop
_create_rrset_from_db_record, so did it.  With this change the main xfrout
code is free from the old API.

not in _reply_xfrout_query() using the old API.
_create_rrset_from_db_record() is now almost obsolete, so the test for it
was also removed.

use that for logging.  get_query_zone_name/class() are now removed
(they were almost one-liner, and didn't see make much sense to be separate
methods other than making the code rather unredable)

using the new API.  _zone_has_soa() and _zone_exit() were not needed anymore,
so were removed, so were corresponding tests.

in _check_xfrout_available().

localstatedir.  (e.g.) /usr/local/var/bind10-devel instead of /usr/local/var.

also updated the EOL code of auth/spec_config.h.pre.in from CR+LF (DOS style)
to LF (unix style), mainly for consistency.

(I first thought it could be deferred, but since the exception can happen
just due to incorrect config input, it should be guaranteed from the
beginning.)

Also made sure that both the default ACL and zone config are changed
atomically under the protection of lock.

simply use the spec default values in initialization of UnixSockServer.
this way we can avoid redundant initialization.

and log messages for them.  this is necessary to gracefully die due to
broken config data in b10-config.db at startup time.

transfer_acl (for consistency) and is now used as the default transfer ACL.
related tests were added.  also removed DEFAULT_RRCLASS, and retrieved the
default RR class from the spec.

ACL will be used when configured.
An unrelated change was piggy-backed: the ACL check was moved outside of
the try-except block.  it doesn't make sense to return FORMERR when an
exception is raised in the ACL check.
Also some minor style fixes were made (folding some long lines)

best matching ACL for the given zone.

generic, the intent is to use it for transfer ACL per zone.  The notion of
per-zone configuration should eventually be implemented in a more generic
way (not specific to xfrout).

for python logging message scripts.

so that *not* using it must be specified explicitely
changed most test cases to not set it (as they are testing other things)