GitLab

so I can use the LabelSequence objects in EXPECT_EQ().
also fixed a minor error in doxygen comment in equals().

- typos
- few code fixes
- test updates

these were basically for this serialization, but now that we have a
different version of serialization/deserialization, we don't need them
for this purpose.  Until we see the need for them for specific purposes,
it'd be better to clean them up.

This simplifies some internal part of the code, and eliminates the need for
offsets_size_ (so it's removed).  This change is a preparation for making
the "from raw data" construction more generic to support non absolute labels.
This is a purely internal refactoring, and public interfaces aren't changed.

and remove the unnecessary 'explicit' from it ('non-explicit' usage
wouldn't be a copy constructor in the first place).

and remove the unnecessary 'explicit' from it ('non-explicit' usage
wouldn't be a copy constructor in the first place).

- style fix in return value
- updated header documentation
- added common label count checks to tests

The Name tests are not repeated as the Name variant is a wrapper
around the LabelSequence variant. Such tests would be redundant.
Instead, tests for LabelSequence specific stripLeft(), stripRight()
were added.

instead of reference to Name
- moved actual name comparison code to labelsequence
- removed Name reference
- replaced by data, offsets, and offset_size values
- added 'raw' constructor for LabelSequence

The revised versoin of MessageRenderer doesn't store it in an STL container,
so it doesn't have to be default-constructable.
the intermediate experimental version of the renderer was removed as
it depends on the default constructor.

also make sure member variables are initialized explicitly.

maptolower hidden in name.cc is now exposed to the LabelSequence implementation
in a "private" namespace.

in name compression we need this info (and in some cases we don't need
the data itself).

leftSplit() -> stripLeft()
rightSplit() -> stripRight()

- split up split() into leftSplit() and rightSplit()
- made LabelSequence a Friend class of Name
   - no need for separate offsets vector
   - no need for Name::at_p()
- fixed copyright year :)

also disallow split to zero length, add isAbsolute(), and update tests