1. 19 Dec, 2018 1 commit
  2. 06 Mar, 2018 1 commit
    • Thomas Markwalder's avatar
      [5551] Addressed review comments · b791aaef
      Thomas Markwalder authored
          Added commentary, updated sub-options unpacking,
          and added support for skip logic to kea-dhcp6.
      
      src/lib/dhcp/option.h
          Added detail to SkipRemainingOptionsError commentary
      
      src/lib/dhcp/libdhcp++.cc
          LibDHCP::unpackVendorOptions4()
          LibDHCP::unpackVendorOptions6()
      
      src/lib/dhcp/tests/pkt4_unittest.cc
          TEST_F(Pkt4Test, unpackVendorMalformed) - updated for
          new exception type
      
          TEST_F(Pkt4Test, truncatedVendorLength) - removed
          extraneous byte streams
      
      src/lib/dhcp/tests/pkt6_unittest.cc
          TEST_F(Pkt6Test, unpackVendorMalformed) - updated for
          new exception type
      
          TEST_F(Pkt6Test, truncatedVendorLength) - new test for
          truncated vendor options
      
      src/lib/dhcp/tests/pkt_captures.h
      src/lib/dhcp/tests/pkt_captures.cc
          isc::dhcp::Pkt6Ptr captureSolicitWithVIVSO()
          isc::dhcp::Pkt6Ptr captureSolicitWithTruncatedVIVSO() -
          new captured packets
      
      src/bin/dhcp6/dhcp6_messages.mes
          DHCP6_PACKET_OPTIONS_SKIPPED - new log message
      
      src/bin/dhcp6/dhcp6_srv.cc
          Dhcpv6Srv::processPacket() - added explicit catch of
          SkipRemainingOptionsError to allow processing the packet
      
      src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
          TEST_F(Dhcpv6SrvTest, truncatedVIVSO) - new test to verify
          server's ability to handle SkipRemainingOptionsError
      b791aaef
  3. 27 Feb, 2018 1 commit
    • Thomas Markwalder's avatar
      [5551] kea-dhcp4 now attempts to process packets with truncated VIVSO · f202ec60
      Thomas Markwalder authored
      src/lib/dhcp/option.h
          SkipRemainingOptionsError - new error to signal
          that unpacking skipped options
      src/lib/dhcp/option_vendor.cc
          OptionVendor::unpack() - modified to throw
          SkipRemainingOptions on truncated length
      
      src/lib/dhcp/option_definition.cc
          OptionDefinition::optionFactory()
          Added catch-rethrow of SkipRemainginOptionsError
      
      src/bin/dhcp4/dhcp4_messages.mes
          Added DHCP4_PACKET_OPTIONS_SKIPPED log message
      
      src/bin/dhcp4/dhcp4_srv.cc
          Dhcpv4Srv::processPacket() - added explicit catch
          of SkipRemainingOptionsError which logs the error
          but allows the processing to continue.
      
      src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
          TEST_F(Dhcpv4SrvTest, truncatedVIVSOOption) -
          new test to verify skip-options logic for truncated
          vendor option
      
      src/lib/dhcp/tests/pkt4_unittest.cc
          TEST_F(Pkt4Test, truncatedVendorLength) - new
          test that verifies Pkt4 unpacking of truncated VIVSO
      
      src/lib/dhcp/tests/pkt_captures4.cc
          Pkt4Ptr PktCaptures::discoverWithValidVIVSO()
          Pkt4Ptr PktCaptures::discoverWithTruncatedVIVSO() -
          new captured discovers
      f202ec60
  4. 27 Nov, 2017 1 commit
  5. 12 Apr, 2017 1 commit
  6. 14 Dec, 2016 1 commit
  7. 08 Jul, 2016 2 commits
  8. 19 May, 2016 1 commit
  9. 21 Mar, 2016 1 commit
  10. 19 Mar, 2016 1 commit
  11. 05 Feb, 2016 1 commit
  12. 16 Dec, 2015 2 commits
  13. 11 Dec, 2015 1 commit
  14. 26 Oct, 2015 1 commit
  15. 21 Oct, 2015 1 commit
  16. 02 Sep, 2015 1 commit
  17. 18 Jun, 2015 1 commit
  18. 11 Jun, 2015 1 commit
  19. 09 Jun, 2015 1 commit
    • Tomek Mrugalski's avatar
      [3794] Changes after review: · 9976c775
      Tomek Mrugalski authored
       - Pkt4::check() removed
       - commented recent change in Pkt4::setType()
       - Pkt4::setType() now used OptionInt<uint8> rather than
         Option::setUint8()
      9976c775
  20. 05 Jun, 2015 1 commit
  21. 19 May, 2015 2 commits
  22. 15 May, 2015 1 commit
  23. 12 May, 2015 1 commit
  24. 05 May, 2015 1 commit
  25. 04 May, 2015 2 commits
  26. 20 Apr, 2015 2 commits
  27. 17 Mar, 2015 2 commits
  28. 23 Dec, 2014 1 commit
    • Tomek Mrugalski's avatar
      [3554] Changes after review: · 2662ac5f
      Tomek Mrugalski authored
       - Moved MAC operations to a new CfgMACSource class
       - Moved macros to HWaddr class
       - Added several unit-tests for MAC sources
       - MAC extraction code moved to separate function in Dhcpv6Srv
      2662ac5f
  29. 08 Oct, 2014 1 commit
  30. 06 Oct, 2014 2 commits
    • Tomek Mrugalski's avatar
      [3546] Another changes after review: · eff16335
      Tomek Mrugalski authored
       - (offset - 4) explained better
       - Modified Dhcpv6Srv::unpackOptions()
       - setHWAddrMember() mac_addr renamed (this time for real)
       - Commented out unused variables
       - RelayInfo now uses DEFAULT_ADDRESS6 in ctor
       - LibDHCP::unpackOptions6 and callback now used uniformly
       - Clarified that ERO is Echo Request Option (RFC4994)
       - unpackOptions4 in libdhcp and Dhcp4Srv no longer throw when
         truncated option is received.
      eff16335
    • Tomek Mrugalski's avatar
      [3546] Changes after review: · 2b6d7f5e
      Tomek Mrugalski authored
       - Pkt4, Pkt6 classes now have descriptions
       - Many descriptions updated in Pkt class
       - Pkt::addOption() moved back to Pkt (from Pkt6)
       - DEFAULT_ADDRESS{,6} are now in private namespace.
       - copyright updated
      2b6d7f5e
  31. 30 Sep, 2014 1 commit
  32. 28 Jul, 2014 1 commit
    • Stephen Morris's avatar
      [3430] Changes in a bid to avoid a Coverity warning · ccfd61b4
      Stephen Morris authored
      Coverity picked up that a construct like "&array[ARRAY_LENGTH]" is
      an access to an invalid element, although it is a valid marker
      as the end of an STL range.  This change alters that construct
      to "array + ARRAY_LENGTH".
      ccfd61b4
  33. 17 Jan, 2014 1 commit
    • Tomek Mrugalski's avatar
      [3203] Changes after review: · afea612c
      Tomek Mrugalski authored
       - Dhcpv{4,6}Srv::classifyPacket() is now better commented.
       - constants are now used instead of magic numbers
       - Pkt{4,6}::addClass is now better commented
      afea612c