GitLab

It has been asserted that using empty() is more efficient than using
size() > 0 due to the possible extra work size() has to do. So provide
an empty() function, which matches the underlying Boost implementation.

reviewed by jelte via jabber.

Changes some log message descriptions and some
function arguments and some output.

To help debugging.

Currently, it contains only the definitions related to CC. If we have
other definitions for other purposes, we may create further definition
files.

Also, rename it to proto_defs, since all is protocol constants.

Move the generator scripts to better place.

There should be no difference in functionality.

Changed to header and payload, which removes the confusion of the first
part message being called env and the other called msg in one send and
the first being msg (and the second omitted) in the second case.

Use the newly introduced constants in the group_sendmsg method. Other
methods still need to be ported, but leaving that to other ticket.

* Spaces
* Remove commented-out code
* Use full relative path to header

Some loops changed to use unsigned loop indexes to avoid warning
messages from some compilers.

discussed via jabber

fix no matching class member found

This reverts commit 834f8d0f.

no matching class member
or
no uniquely matching class member found

I just added isc::data::

Maybe there is a better doxygen way, need to research more.

This reverts commit 6342eda0.

The length sent over wire are 32bit unsigned integers, but it could read
it as size_t which might be 64bit. It's strange this didn't cause any
trouble, but this is cleaner anyway.

briefly talked about it on jabber, no one opposed to it, Jeremy explicitly
agreed.  changes are trivial themselves, so no explicit review.

Instead of detecting when it stopped, use dummy work object to keep it
busy.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-recursor-config@3422 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-recursor-config@3351 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2752 e5f2f494-b856-4b98-b285-d166d9295462

remove io_service.reset() call from blocking read; application using it is responsible for keeping io_service alive (if necessary by using a io_service::work object).
Also added a test with multiple reads


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2750 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac310@2748 e5f2f494-b856-4b98-b285-d166d9295462

 - added surrandong parentheses for return values based on agreed guideline
 - removed redundant semicolons after a block
 - fixed curly brace position

diff is large, but the change is very trivial.  so I'm skipping explicit review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2745 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2735 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2727 e5f2f494-b856-4b98-b285-d166d9295462

  - removed a redundant blank line
  - folded a long line


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2726 e5f2f494-b856-4b98-b285-d166d9295462

new approach for blocking reads to prevent races: if the timeout or read is canceled, also wait until the cancel signal is processed

other cleanup;

only use one variable for the read_result and timer_result (with boost::optional)
setResult does not need to be a member function, so i moved it out of the class
don't cancel timer if it wasn't set
added an io_service.reset() call to reset internal flags before the run_one() calls


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2716 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2702 e5f2f494-b856-4b98-b285-d166d9295462

addressed the small issues from jinmei's review (i.e. everything except the first two points and the one about integer sizes)


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2699 e5f2f494-b856-4b98-b285-d166d9295462

  - removed redundant white spaces in blank lines
  - removed redundant C++ namespace (isc::cc)
  - folded some too long lines
  - constify some variables
  - add UNUSED_PARAM for an unused variable (it compiles without it right now, but it'd be better to specify it for our internal code)
  - removed a duplicate include (asio.hpp in session_unittests.cc)
  - removed redundant space around '=' for default parameter spec (based on python coding guideline)


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2696 e5f2f494-b856-4b98-b285-d166d9295462