GitLab

of class member variables (which are now removed).  also added a test to
detect a bug in the previous code where the sigtype field for addRRset
was incorrectly carried over after adding an RRSIG.

Also updated doc and tests accordingly.

catch exception in rollback explicitly.  added a test case for that.

implementation completely within .cc as even the class name doesn't have to
be visible.

startUpdateZone() to be more consistent with getIterator()).

by update tests.  the semantics should be preserved at the moment.
making a commit at this point mainly as a checkpoint.

for database_unittests (due to too many conflicts).

also use is_open() instead of != NULL (it's strange that the original code
did even compile, but in any case this one should be better in clarity and
possibly in portability).
okayed on jabber, should be minor enough, directly pushing.

with fixing conflicts:
	src/lib/datasrc/database.cc
	src/lib/datasrc/database.h
	src/lib/datasrc/sqlite3_accessor.cc
	src/lib/datasrc/tests/Makefile.am
	src/lib/datasrc/tests/sqlite3_accessor_unittest.cc

would sound less odd.

When they are regenerated by make (not during initial configure run),
they were not set executable, which was useless. This way they are set
executable twice during the initial configure-make-make check, but at
last it works.

The folder contains both generated and directly written files, so we
need to handle them separately, because of when we have different
builddir than srcdir.

after it returns false.
okayed on jabber, and I don't think we need a separate ticket/branch for
this as it's just a small documentation update.

instead of vector, mainly to be consistent with other interfaces.

since it would have to have a return value, and even any xxx_EQ doesn't
make much sense because this is not actually what we are trying to test.
I choise to simply let it fail (should it ever happens); we should be able
to know by seeing some of the subsequent tests fail.

Instead of EXTRA_DIST, this allows make to regenerate them on .in
change.

Just to bring in changes and solve conflicts, there was some refactoring
elsewhere.

Conflicts:
	src/lib/datasrc/database.cc
	src/lib/datasrc/datasrc_messages.mes
	src/lib/datasrc/tests/database_unittest.cc

Conflicts:
	src/lib/datasrc/database.cc
	src/lib/datasrc/database.h
	src/lib/datasrc/sqlite3_accessor.cc
	src/lib/datasrc/sqlite3_accessor.h
	src/lib/datasrc/tests/database_unittest.cc
	src/lib/datasrc/tests/sqlite3_accessor_unittest.cc