GitLab

This message is only output when a receive operation is cancelled,
so the parameter was always the text "operation aborted" - which
gives no new information.

Documented JSON "schema" for isc::dhcp_ddns::NameChangeRequests
and added explanation of NCR members to D2 doxygen

A call to sigaction() is explicitly cast to void to indicate to
static code checkers that the return value is being ignored.

The messages in question are now output only with logging set to
DEBUG: the DHCP-DDNS process now outputs a minimum number of messages
by default.

Coverity picked up that a construct like "&array[ARRAY_LENGTH]" is
an access to an invalid element, although it is a valid marker
as the end of an STL range.  This change alters that construct
to "array + ARRAY_LENGTH".

Functionally there is no change to the code by this change addresses
the "buffer not null terminated" warning in the logger constructor.
As well as removing the cause of the warning (a "strncpy" where
the length copied is equal to the destination buffer length), it
it removed two assert() calls: one was replaced by the throwing of
am exception, and the second was redundant.

The if_ether.h is portable across various BSD system flavors. The
ethernet.h is missing on some OSes.

Fixed Mac OS-X/gcc 4.2.1 issued warning on empty bodied
while-loops in new asiolink::IntervalTimer unit tests.

 - cosmetic changes in configure.ac
 - comment in src/lib/testutils/testdata/Makefile.am updated

The unittests IntervalTimerTest.intervalModeTest and
IntervalTimerTest.timerReuseTest were failing under NetBSD VM.
They have been restructured to be less susceptible to timing.

There is a new function used in keactrl tests which waits for the server
to shutdown, rather than check if it is down already. This is to avoid
race condition when the process may not completely terminate when we
check that it is.

Added missing parameter and method commentary.
Extended unit tests as suggested.
Moved onreceipt_handler_ from SignalSet to
anonymous namespace.

 - dhcp6_test.py removed
 - src/lib/testuitls/testdata/*.wire files are now in repo,
   no longer need python3 script to generate
 - src/lib/cc/proto_defs.h added to repo, no longer autogenerated
 - Added comment to get-rdatacode.py
 - removed LIBRARY_PATH_PLACEHOLDER hacks from several Makefiles.
 - ChangeLog entry added.

On BSD the multicast packets are received on the socket bound to any
address. So, the packets sent to global unicast address must be filtered
out by the DHCP server.

On BSD open the socket, bind to in6addr_any and join multicast group.