GitLab

It seems some compilers can't find it otherwise. This should make them
happy.

There were tests that should have been disabled too, as they use the
static data source, which is loaded dynamically from a .so. Some systems
break on them.

Finally! This one was big.

With some minor updates to catch up to the changes after merge.

Conflicts:
	src/bin/auth/auth_srv.cc
	src/bin/auth/auth_srv.h
	src/bin/auth/tests/auth_srv_unittest.cc
	src/lib/datasrc/client_list.cc
	src/lib/datasrc/tests/client_list_unittest.cc

Conflicts:
	src/bin/auth/tests/datasrc_configurator_unittest.cc

We change the file, not the memory content.

to fix a report from a buildbot.  should be trivial, so committing it directly.

Conflicts:
	src/lib/datasrc/rbtree.h

as opposed to searching the import path; this gives us more flexibility over cfgmgr plugin names, and makes sure they don't conflict with actual modules.

at least my version of boost doesn't seem to allow the direct comparison
with != between offset_ptr and raw pointers.
also made some trivial style fixes.

this makes the code more concise.  also add comments on why we use ASSERT
for one of the tests.

also, use \brief instead of \short.

For uint8_t.

The (left|right)Rotate might have changed the parent, so it needs to be
reacquired after it.

- additional info in auth commands
- move 'check_session_start_forwarder_called' to session test setUp()
- fixed comment in auth_srv unit test

If they are called multiple times, it is stored into a variable.
Segfaults, needs a fix (again).

There was confusion about left_ and right_. After all, the left and
right depends on your point of view and on how many mirrors there are
around.

When there's a JSON error, we raise an exception with better
explanation.

As most of the handling moved to the ConfigurableClientList, it got so
simple the separate validate() method needed more care to pass values
around than the work it actually did, so it got inlined.

This one is mostly the hot-spot cache. The new data source model does
not use it at all. Also, the parameters to tune it were removed.