1. 29 Oct, 2019 1 commit
  2. 28 Oct, 2019 4 commits
  3. 16 Aug, 2019 2 commits
    • Thomas Markwalder's avatar
      [#730,!2-p] Addressed review comments · 1878553a
      Thomas Markwalder authored
          Minor cleanup
      
      ChangeLog
      src/bin/dhcp4/dhcp4_messages.mes
      src/bin/dhcp4/dhcp4_srv.cc
      src/lib/dns/tests/name_unittest.cc
      1878553a
    • Thomas Markwalder's avatar
      [#730,!2] Corrected assertion failure on malformed hostname from kea-dhcp4 · 9260b6d9
      Thomas Markwalder authored
      src/lib/exceptions/isc_assert.h
          New file that defines isc_assert_throw()
      
      src/lib/exceptions/Makefile.am
          added isc_asssert.h
      
      src/lib/exceptions/tests/exceptions_unittest.cc
          TEST(IscThrowAssert, checkMessage) - new test
      
      src/lib/dns/labelsequence.cc
      src/lib/dns/name.cc
          Replaced assert() calls with isc_throw_assert() calls
      
      src/lib/dns/tests/name_unittest.cc
          TEST_F(NameTest, unexpectedParseError) - new unit test
          for hostname option content based on fuzz test failure
      
      src/lib/dhcp_ddns/ncr_msg.cc
          Removed unnecessary include of dns/name.h
      
      src/bin/dhcp4/dhcp4_srv.cc
          Dhcpv4Srv::processHostnameOption() - added try catch
          around OptionDataTypeUtil::getLabelCount() call
      
      src/bin/dhcp4/dhcp4_messages.*
          added new log message DHCP4_CLIENT_HOSTNAME_MALFORMED
      
      src/bin/dhcp4/tests/fqdn_unittest.cc
          TEST_F(NameDhcpv4SrvTest, serverUpdateMalformedHostname) -
          renamed test and augmented it to include the packet of death
          produced by fuzz testing.
      9260b6d9
  4. 16 Jul, 2019 2 commits
  5. 27 Jun, 2019 1 commit
  6. 26 Jun, 2019 2 commits
  7. 22 May, 2019 3 commits
  8. 26 Mar, 2019 3 commits
  9. 25 Jan, 2019 1 commit
  10. 18 Jan, 2019 2 commits
  11. 16 Jan, 2019 2 commits
  12. 10 Dec, 2018 1 commit
  13. 20 Nov, 2018 1 commit
  14. 12 Nov, 2018 1 commit
  15. 08 Nov, 2018 1 commit
  16. 05 Nov, 2018 1 commit
    • Thomas Markwalder's avatar
      [#42] Implemented PacketQueueMgr class · 90fd7ebf
      Thomas Markwalder authored
      New files:
          src/lib/dhcp/packet_queue_mgr.h
          src/lib/dhcp/packet_queue_mgr4.cc
          src/lib/dhcp/packet_queue_mgr4.h
          src/lib/dhcp/packet_queue_mgr6.cc
          src/lib/dhcp/packet_queue_mgr6.h
          src/lib/dhcp/tests/packet_queue_mgr4_unittest.cc
          src/lib/dhcp/tests/packet_queue_mgr6_unittest.cc
          src/lib/dhcp/tests/packet_queue_testutils.h
      
      src/bin/dhcp4/ctrl_dhcp4_srv.cc
          Cleaned up packet queue config block
      
      src/bin/dhcp4/dhcp4_lexer.ll
      src/bin/dhcp4/dhcp4_parser.yy
      src/bin/dhcp4/tests/config_parser_unittest.cc
          added queue-type
      
      src/bin/dhcp4/dhcp4_messages.mes
          added DHCP4_CONFIG_PACKET_QUEUE message
      
      src/lib/dhcp/Makefile.am
          packet_queue_mgr.h
          packet_queue_mgr4.cc packet_queue_mgr4.h
          packet_queue_mgr6.cc packet_queue_mgr6.h
      
      src/lib/dhcp/iface_mgr.*
          Replaced packet queue members with PQM members
          Added PQM instantion to IfaceMgr ctor
      
      src/lib/dhcp/packet_queue.h
          added getInfo,getInfoStr
      
      src/lib/dhcp/tests/Makefile.am
          packet_queue_mgr4_unittest.cc
          packet_queue_mgr6_unittest.cc
      
      src/lib/dhcpsrv/parsers/queue_control_parser.cc
          added queue-type
      90fd7ebf
  17. 17 Oct, 2018 2 commits
  18. 05 Oct, 2018 1 commit
    • Thomas Markwalder's avatar
      [#32,!23] dhcp4 now parses "config-control" element · 8c5e6ce8
      Thomas Markwalder authored
      src/bin/dhcp4/dhcp4_lexer.ll
      src/bin/dhcp4/dhcp4_parser.yy
          Added parsing support for config-control and config-databases
      
      src/bin/dhcp4/json_config_parser.cc
          configureDhcp4Server() - added handler for config-control element
      
      src/bin/dhcp4/parser_context.*
          added CONFIG_CONTROL and CONFIG_DATABASE
      
      src/bin/dhcp4/tests/config_parser_unittest.cc
         TEST_F(Dhcp4ParserTest, configControlInfo) - new test
      8c5e6ce8
  19. 16 May, 2018 1 commit
  20. 06 Apr, 2018 1 commit
    • Thomas Markwalder's avatar
      [5556a] MySQL lease and host backends now support configurable auto-reconnect · f09bf17e
      Thomas Markwalder authored
          src/lib/dhcpsrv/mysql_connection.h
              MySqlConnection::checkError<>() - modified to invoke
              db lost callback
      
          src/lib/dhcpsrv/dhcpsrv_messages.mes
              Updated log messages
      
          src/lib/dhcpsrv/mysql_lease_mgr.cc
              MySqlLeaseMgr::getVersion() - updated to use checkError()
      
          src/lib/dhcpsrv/pgsql_connection.*
              PgSqlResult::PgSqlResult(PGresult *result) - now supports
              construction with null PGresult. This is to accomodate rare
              cases when PQ* statements can return NULL.
      
          src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.*
              class LeaseMgrDbLostCallbackTest - new test fixture for
              testing LeaseMgr DBLostCallback behavior
      
          src/lib/dhcpsrv/tests/host_mgr_unittest.cc
              class HostMgrDbLostCallbackTest
              class MySQLHostMgrDbLostCallbackTest
              class PostgreSQLHostMgrDbLostCallbackTest
              - new test fixtures for testing HostMgr DBLostCallback behavior
      
          src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc
              class MySQLLeaseMgrDbLostCallbackTest - new test fixture for
              testing MySQL LeaseMgr DBLostCallback behavior
      
          src/lib/dhcpsrv/tests/pgsql_lease_mgr_unittest.cc
              class PgSqlLeaseMgrDbLostCallbackTest - new test fixture for
              testing Postgresql LeaseMgr DBLostCallback behavior
      
          src/lib/dhcpsrv/tests/test_utils.*
              int findLastSocketFd() - new function used for finding what
              should be the fd of the SQL client socket
      
          doc/guide/dhcp4-srv.xml
          doc/guide/dhcp6-srv.xml
              Updated lease and host database parameter sections
      f09bf17e
  21. 05 Apr, 2018 1 commit
  22. 02 Mar, 2018 1 commit
  23. 01 Mar, 2018 2 commits
    • Marcin Siodelski's avatar
      [5551] Added missing dot. · 4a3e15a8
      Marcin Siodelski authored
      4a3e15a8
    • Thomas Markwalder's avatar
      [5477] kea-dhcp6 now supports db reconnect · 78b8edb6
      Thomas Markwalder authored
          kea-dhcp6
              added support for max-reconnect-tries and reconnect-wait-time
              to lease and host db parsers
      
              Added a callback for when DB backends detect loss of connectivity
      
              Added a self-rescheduling method to attempt to reconnect to the
              backends if retries are enabled
      
          dhcpsrv
              PgSqlConnection::checkStatementError() - Modified "fatal" logic
              to throw after invoking db_lost_callback.
      
          Misc. cleanup
      78b8edb6
  24. 28 Feb, 2018 1 commit
    • Thomas Markwalder's avatar
      [5477] dhcpsrv/postgres and kea-dhcp4 now support db reconnect · 249219f1
      Thomas Markwalder authored
      kea-dhcp4
          added support for max-reconnect-tries and reconnect-wait-time
          to lease and host db parsers
      
          Added a callback for when DB backends detect loss of connectivity
      
          Added a self-rescheduling method to attempt to reconnect to the
          backends if retries are enabled
      
      dhcpsrv
          Added a callback that DatabaseConnection derivations should invoke
          when they lose connectivity.
      
          Added an optional callback parameter from CfgDbAccess::createManagers()
          all the way down to DatabaseConnection ctor.
      
          pgsql_connection.cc
              PgSqlConnection::~PgSqlConnection() - Added logic to close the
              connection only when the connect state is still OK.
              Otherwise it likes to core dump.
      
              PgSqlConnection::checkStatementError() - Modified to invoke the
              connectivity lost callback on "fatal" errors
      
          pgsql_lease_mgr_unittest.cc
          pgsql_host_data_source_unittest.cc
              Added tests to verify that the lost callback is NOT invoked on an
              open failure
      249219f1
  25. 27 Feb, 2018 1 commit
    • Thomas Markwalder's avatar
      [5551] kea-dhcp4 now attempts to process packets with truncated VIVSO · f202ec60
      Thomas Markwalder authored
      src/lib/dhcp/option.h
          SkipRemainingOptionsError - new error to signal
          that unpacking skipped options
      src/lib/dhcp/option_vendor.cc
          OptionVendor::unpack() - modified to throw
          SkipRemainingOptions on truncated length
      
      src/lib/dhcp/option_definition.cc
          OptionDefinition::optionFactory()
          Added catch-rethrow of SkipRemainginOptionsError
      
      src/bin/dhcp4/dhcp4_messages.mes
          Added DHCP4_PACKET_OPTIONS_SKIPPED log message
      
      src/bin/dhcp4/dhcp4_srv.cc
          Dhcpv4Srv::processPacket() - added explicit catch
          of SkipRemainingOptionsError which logs the error
          but allows the processing to continue.
      
      src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
          TEST_F(Dhcpv4SrvTest, truncatedVIVSOOption) -
          new test to verify skip-options logic for truncated
          vendor option
      
      src/lib/dhcp/tests/pkt4_unittest.cc
          TEST_F(Pkt4Test, truncatedVendorLength) - new
          test that verifies Pkt4 unpacking of truncated VIVSO
      
      src/lib/dhcp/test...
      f202ec60
  26. 23 Feb, 2018 1 commit
    • Thomas Markwalder's avatar
      [5553] Added specific log for possible BOOTP packets · 00a15554
      Thomas Markwalder authored
      src/bin/dhcp4/dhcp4_messages.mes
          Added DHCP4_PACKET_DROP_0009 for possible bootp packets
      
      src/bin/dhcp4/dhcp4_srv.cc
          Dhcpv4Srv::acceptMessageType()
              rearranged a bit to test explicitly for DHCP_NOTYPE
      
      src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
          TEST_F(Dhcpv4SrvTest, acceptMessageType)
          Added tests for packets with no option 53 and for
          type > DHCPLEASEQUERYDONE
      00a15554