GitLab

see http://bind10.isc.org/ticket/1784#comment:5

thanks to the introduction of DNSServiceBase we don't need it any more.

also introduce mock DNSService and use it to test the behavior, and to test
the resolver behavior doesn't change.

the essential part should be quite simple; most of the changes are
straightforward interface adjustments.
it also includes some editorial cleanups such as adding header-file guards
or style guideline fixes.

Only some part of portconfig need to be adjusted; others will still use
the derived class directly.

"UDPVersion" is now more generic options, and its default is the previous
behavior, which should be more suitable default.  added test cases to
confirm the effect of the options.  added detailed documentation.

That matches the sense of YAGNI, and, in fact, would help avoid having the
type of regression we had in #1600.

also fixed memory leak in a test case using scoped_ptr.

otherwise it could result in duplicate free.  This basically recovers the
same behavior of d5ec40da that was lost
in commit 699068ef.

in the relevant tests, time.time() is temporarily replace by the function returned by get_fake_time_time(). After each test that uses this, it is restored to the original function (So as not to mess up unittest framework's concept of time).

Also renamed one test which had the same name as another test.

take potential second boundary into account
also fixed a few long lines

We can no longer EXPECT_THROW, if we don't throw.

suboptimal solution instead.

okayed by muks on jabber.

see
http://bind10.isc.org/ticket/1747?replyto=7#comment:9