GitLab

see http://bind10.isc.org/ticket/1784#comment:5

"UDPVersion" is now more generic options, and its default is the previous
behavior, which should be more suitable default.  added test cases to
confirm the effect of the options.  added detailed documentation.

That matches the sense of YAGNI, and, in fact, would help avoid having the
type of regression we had in #1600.

also fixed memory leak in a test case using scoped_ptr.

SyncUDPServer by command.

default internal buffer or set the separate buffer by setBuffer().

Actually, the SyncUDPSocket is currently a copy of the UDPSocket. It
needs to get stripped little bit.

The service is now (nonstatic) member and the static variable is only
pointer to the active one, so the signal handler can access it.

It eliminates the need to call commonSetup and makes it possible to
constify something.

constify things; use DISABLE_ instead of comment out for the disabled test;
typo

The test passes on Linux with epoll, as the (invalid) file descriptor is
inserted right away. The others don't detect the error right at the
time, so it doesn't throw.

* Use the address family instead of v6 boolean.
* Check it by exception.
* Documentation.

(based on the seeming intent), indentation.

it without them.

* Use IPv6 address for the test
* Don't use static strings, use char*
* Don't call them static if they are in anonymous namespace
* Use getaddrinfo to get the (slightly system dependant) address structure
* Use protocol field (even if it probably doesn't matter for SOCK_STREAM
  and SOCK_DGRAM)
* Be more careful about releasing resources in error states (even if
  it's a test and they would terminate on the error anyway)

Some loops changed to use unsigned loop indexes to avoid warning
messages from some compilers.

One compiler had a problem with the unqualifier data type
"error_code".  This has been changed to "asio::error_code".

The dns_service is not tested, so the tests are not added. It is simple
anyway.

And for check_LTLIBRARIES to noinst_LTLIBRARIES too.

This is so a regular "make" will build the test programs and
libraries too.  So the "make check" will just run the tests (and
not build them).  This is to help with test-driven development.

This reverses some from #1091, plus does the rest too.

Note that doing a "make check" before a "make" does not currently
work due to dependencies depending on each other (e.g. python/isc/log
tests needs datasrc but python/isc/datasrc tests need log_config_update).

and while here also only build when the "make check" target is used;
since we already require --with-gtest maybe this step is not of much
interest.

Add a reset logging function to specific tests to ensure that the
logging is routed to the stream selected by the B10 environment
variables prior to each test that generates messages.

Removes (by default) one of the remaining logging messages identified
in the review.

this should be trivial enough, so I'll push it to the shared repo directly.

These files weren't changed when root_logger_name.h was renamed to
logger_name.h.  Rather than just change the #include file name, the
logging was correctly initialized.

This only needed to be in the Makefile.am for the liblog library,
not everywhere else!

put the code for it in a slightly better call, and update the tests. Also does not include setDNSSECAwareness, since that actively breaks the resolver right now (which is another issue)

Also update the test Makefile.am files to include the appropriate libraries.