GitLab

[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Added ChangeLog entry fro better messages on config from CB failure

[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Split commit block to add CB indication in log/error messages

[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Improved messages (but still not found the bug)

[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Removed unused DCTL_CCSESSION_STARTING

src/hooks/dhcp/high_availability/ha_messages.mes
    Removed HA_SERVICE_CONNECT_INVALID_SOCKET message

src/hooks/dhcp/high_availability/ha_service.cc
    HAService::clientConnectHandler() - now just avoids registering
    an invalid FD with no log and return(true)

src/lib/http/client.cc
    Added commen in Connection::close()

src/lib/http/tests/server_client_unittests.cc
    Removed invalid FD failure in test

src/lib/http/tests/server_client_unittests.cc
    TEST_F(HttpClientTest, connectCloseCallbacks) - test now
    verifies callback invocations

    IfaceMgr and unit tests clean up.

src/hooks/dhcp/high_availability/ha_messages.mes
    HA_SERVICE_CONNECT_INVALID_SOCKET - new message

src/hooks/dhcp/high_availability/ha_service.cc
 HAService::clientConnectHandler() - added negative fd logic

src/lib/http/client.cc
    Connection::closeCallback() - new method that wraps invocation
    of close callback in try-catch.

src/lib/http/http_messages.mes
    HTTP_CONNECTION_CLOSE_CALLBACK_FAILED - new message

    Added TIMEOUT_DEFAULT_HTTP_CLIENT_REQUEST
    Removed virtual from callback declarations
    Added commentary to http/client.h

src/lib/dhcp/iface_mgr.cc
    IfaceMgr::purgeBadSockets() - new function to validate
    external sockets and unregister any that are invalid.

    IfaceMgr::receive4Indirect()
    IfaceMgr::receive4Direct()
    IfaceMgr::receive6Indirect()
    IfaceMgr::receive6Direct() - added logic to all
    purgeBadSockets() when select fails with EBADF

src/lib/dhcp/tests/iface_mgr_unittest.cc
    TEST_F(IfaceMgrTest, purgeExternalSockets4)
    TEST_F(IfaceMgrTest, purgeExternalSockets6) -  new tests
    to verify bad socket purging

src/lib/http/client.cc
    Move close_callback_ reset back to Connection::close()

src/hooks/dhcp/high_availability/ha_service.cc

    HAService
        clientConnectHandler() - new client connection connect callback
        clientCloseHandler() - new client connection close callback

        asyncSendLeaseUpdate()
        asyncSendHeartbeat()
        asyncDisableDHCPService()
        asyncEnableDHCPService()
        asyncSyncLeasesInternal() - added new call backs to
        HttpClient::asyncSendRequest() invocation

src/lib/http/client.cc
    Connection::resetState() - added reset of close callback

Addes close_callback and exposes Connectin's TCP socket to it
and connect_callback.

src/lib/http/client.h b/src/lib/http/client.h
    HttpClient:
        Added second parameter, socket FD, to ConnectHandler
        Added CloseHandler typedef

        asyncSendRequest() - added close_callback parameter

src/lib/http/client.cc
    Connection - added close_callback parameter to all
    methods that accept connect_callback parameter

    Added invocation of close_callback wherever the connection's
    socket is closed.

src/lib/http/tests/server_client_unittests.cc
    TEST_F(HttpClientTest, connectCloseCallbacks) - new test that
    verifies connect and close callback operations

[621-pd-pool-fields-are-not-described-in-kea6-all-keys-current-json] Added description of pd-pool current all keys example

[685-log-the-expected-subnet-id-as-well-as-the-actual-subnet-id-when-the-sanity-checker-identifies-a-problem] Added ChangeLog entry for sanity-checker logs

[685-log-the-expected-subnet-id-as-well-as-the-actual-subnet-id-when-the-sanity-checker-identifies-a-problem] Improved SanityChecker logs

[694-add-valid-lifetime-to-dhcp4_lease_alloc-and-dhcp6_lease_alloc-logging] Added ChangeLog entry for DHCP*_LEASE_ALLOC improvement

[694-add-valid-lifetime-to-dhcp4_lease_alloc-and-dhcp6_lease_alloc-logging] Added the unit (seconds)

[694-add-valid-lifetime-to-dhcp4_lease_alloc-and-dhcp6_lease_alloc-logging] Added lease valid lifetime to DHCP*_LEASE_ALLOC logs

[682-keactrl-unable-to-kill-kea-processes] Added expansion of runstatdir when it includes localstatedir