Commits · 4601b4d22e7c8874ce55c0e600650cbe7e82a95a · ISC Open Source Projects / Kea

21 Jul, 2010 4 commits

removed unnecessary forward declaration, and added a comment about the remaining one. · 4601b4d2
JINMEI Tatuya authored Jul 21, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2556 e5f2f494-b856-4b98-b285-d166d9295462
```
4601b4d2

- renamed a variable: s/is_axfr_connection_established/xfrout_connected/ as suggested in review · dc0e2cde

JINMEI Tatuya authored Jul 21, 2010

- commented on how a customized AbstractXfroutClient object is used


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2555 e5f2f494-b856-4b98-b285-d166d9295462

dc0e2cde

added notes about protected destructors in base classes. · 252f19a1
JINMEI Tatuya authored Jul 21, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2554 e5f2f494-b856-4b98-b285-d166d9295462
```
252f19a1

avoid using limited broadcast address (all 1 address) for a failure test case. · 05368c56

JINMEI Tatuya authored Jul 21, 2010

on some systems this won't fail as expected.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2553 e5f2f494-b856-4b98-b285-d166d9295462

05368c56

20 Jul, 2010 1 commit

Minor grammar fixes in comments. · 65166f58

Evan Hunt authored Jul 20, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2538 e5f2f494-b856-4b98-b285-d166d9295462

65166f58

10 Jul, 2010 15 commits

cleanup: removed an unnecessary namespace prefix. · c4f8a864

JINMEI Tatuya authored Jul 10, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2480 e5f2f494-b856-4b98-b285-d166d9295462

c4f8a864

disabled xfrin triggerred by a notify. the original implementation naively... · 667b9702

JINMEI Tatuya authored Jul 10, 2010

disabled xfrin triggerred by a notify.  the original implementation naively trusts the notify sender and uses it as the transfer master, which is very dangerous from security point of view.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2479 e5f2f494-b856-4b98-b285-d166d9295462

667b9702

made sure passing the RRClass of notify to the remote process. · 830be189

JINMEI Tatuya authored Jul 10, 2010

added tests about the CC message content for notify.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2478 e5f2f494-b856-4b98-b285-d166d9295462

830be189

use a string instead of an object for the RRclass parameter for xfrin/notify. · f55a7b74

JINMEI Tatuya authored Jul 10, 2010

add validation of the given string.
adjust/add tests for this change.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2477 e5f2f494-b856-4b98-b285-d166d9295462

f55a7b74

added test cases for notify, and fixed a bug identified by a test. · 0cfe69f9
JINMEI Tatuya authored Jul 10, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2476 e5f2f494-b856-4b98-b285-d166d9295462
```
0cfe69f9
for notify, use consistent parameter with other xfrin commands. · 4f65d1a1
JINMEI Tatuya authored Jul 10, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2475 e5f2f494-b856-4b98-b285-d166d9295462
```
4f65d1a1

added tests for specific addresses and "-4/-6" cases. · 48134262

JINMEI Tatuya authored Jul 10, 2010

the tests identified bugs in my previous refactoring, which were fixed.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2474 e5f2f494-b856-4b98-b285-d166d9295462

48134262

tests for cases of server initialization failure due to system level errors. · 8f5c79ba
JINMEI Tatuya authored Jul 10, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2473 e5f2f494-b856-4b98-b285-d166d9295462
```
8f5c79ba

added -a to the usage. · 918b6962

JINMEI Tatuya authored Jul 10, 2010

commented about some weirdness with this option.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2472 e5f2f494-b856-4b98-b285-d166d9295462

918b6962

on second thought, it would be better to separate constructors for the... · 84bdd045

JINMEI Tatuya authored Jul 10, 2010

on second thought, it would be better to separate constructors for the explicit address case and the "any" address case.
This will make the validation process a lot easier and helps reduce code duplicate.
option conflict between -a and -4|-6 is now caught in main.cc.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2471 e5f2f494-b856-4b98-b285-d166d9295462

84bdd045

(forgot to cleanup a leftover) · a146928f

JINMEI Tatuya authored Jul 10, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2469 e5f2f494-b856-4b98-b285-d166d9295462

a146928f

added tests for address family mismatches (give an ipv4 address with -6, etc) · 76f4788d
JINMEI Tatuya authored Jul 10, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2468 e5f2f494-b856-4b98-b285-d166d9295462
```
76f4788d

catch invalid addresses. added tests for that. · 999ab8cb

JINMEI Tatuya authored Jul 10, 2010

also improved exception message on bad ports.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2467 e5f2f494-b856-4b98-b285-d166d9295462

999ab8cb

changed interface of the IOService constructor so that it's impossible · 22d942fa

JINMEI Tatuya authored Jul 10, 2010

to pass NULL port string, which simplifies validation.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2466 e5f2f494-b856-4b98-b285-d166d9295462

22d942fa

added tests on port string validity · 4a777698

JINMEI Tatuya authored Jul 10, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2465 e5f2f494-b856-4b98-b285-d166d9295462

4a777698

09 Jul, 2010 10 commits

merged the original trac221 branch · 678e8861

JINMEI Tatuya authored Jul 09, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2464 e5f2f494-b856-4b98-b285-d166d9295462

678e8861

working branch for Trac , rebasing a newer trunk. · 20ecd3a7

JINMEI Tatuya authored Jul 09, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac221b@2462 e5f2f494-b856-4b98-b285-d166d9295462

20ecd3a7

changelog entry for Trac · f397ff42

JINMEI Tatuya authored Jul 09, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2460 e5f2f494-b856-4b98-b285-d166d9295462

f397ff42

merged branches/275 (for trac ). · 9f35b9ba

JINMEI Tatuya authored Jul 09, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2459 e5f2f494-b856-4b98-b285-d166d9295462

9f35b9ba

more sync trunk (not sure if I need to do this again, but reintegrate didn't succeed) · 3df6590a
JINMEI Tatuya authored Jul 09, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac275@2458 e5f2f494-b856-4b98-b285-d166d9295462
```
3df6590a

sync with trunk · 1944a7d2

JINMEI Tatuya authored Jul 09, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac275@2457 e5f2f494-b856-4b98-b285-d166d9295462

1944a7d2

additional comment about the requirement on the session arg to ModuleCCSession constructor. · c38bf808
JINMEI Tatuya authored Jul 09, 2010
```
from review discussion.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac275@2456 e5f2f494-b856-4b98-b285-d166d9295462
```
c38bf808
merged branches/trac285 (ticket #285, config set command doesn't work anymore) · 5e1e8cd2
Jelte Jansen authored Jul 09, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2452 e5f2f494-b856-4b98-b285-d166d9295462
```
5e1e8cd2

more editorial fix: add a space between a keyword and a parenthesis. · 153b6b2c

JINMEI Tatuya authored Jul 09, 2010

trivial, skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2447 e5f2f494-b856-4b98-b285-d166d9295462

153b6b2c

editorial fix: add a space between a keyword and a parenthesis. · 8a7b6a4a

JINMEI Tatuya authored Jul 09, 2010

trivial, skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2446 e5f2f494-b856-4b98-b285-d166d9295462

8a7b6a4a

08 Jul, 2010 7 commits

more comment update · 7ba6f110

JINMEI Tatuya authored Jul 08, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac275@2445 e5f2f494-b856-4b98-b285-d166d9295462

7ba6f110

cleanup: declare virtual functions in the derived class clearly, and changed... · 7e74ff76

JINMEI Tatuya authored Jul 08, 2010

cleanup: declare virtual functions in the derived class clearly, and changed essentially private methods to really private ones.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac275@2444 e5f2f494-b856-4b98-b285-d166d9295462

7e74ff76

comment update and a minor cleanup (change the type of string argument · 7e2454fa

JINMEI Tatuya authored Jul 08, 2010

to const string&)


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac275@2443 e5f2f494-b856-4b98-b285-d166d9295462

7e2454fa

removed unused declaration · 20f4352e

JINMEI Tatuya authored Jul 08, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac275@2442 e5f2f494-b856-4b98-b285-d166d9295462

20f4352e

fix; only initialize fully if it hasn't been done yet, otherwise only update... · a8bd18ab

Jelte Jansen authored Jul 08, 2010

fix; only initialize fully if it hasn't been done yet, otherwise only update the specifications and the configuration as known by the manager, not the local changes


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac285@2440 e5f2f494-b856-4b98-b285-d166d9295462

a8bd18ab

created short-lived branch for ticket 285 · 2c800eb2

Jelte Jansen authored Jul 08, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac285@2439 e5f2f494-b856-4b98-b285-d166d9295462

2c800eb2

Avoid socket error caused by shutting down one non-connected socket. · db0e2443
Likun Zhang authored Jul 08, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2432 e5f2f494-b856-4b98-b285-d166d9295462
```
db0e2443

07 Jul, 2010 3 commits

added entry for Trac · ba30d562

JINMEI Tatuya authored Jul 07, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2428 e5f2f494-b856-4b98-b285-d166d9295462

ba30d562

merged branches/trac148b: added -R<dir_to_libpython> when possible. it help build on netbsd. · c341da41
JINMEI Tatuya authored Jul 07, 2010
```
git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2427 e5f2f494-b856-4b98-b285-d166d9295462
```
c341da41

Add space; fix typo. · b77c35be

Jeremy C. Reed authored Jul 07, 2010


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac148b@2426 e5f2f494-b856-4b98-b285-d166d9295462

b77c35be