GitLab

Addressed a myriad of minor typos and wording issues.

modified:
ChangeLog
doc/examples/kea4/all-keys.json
doc/examples/kea6/all-keys.json
doc/sphinx/arm/dhcp4-srv.rst
doc/sphinx/arm/dhcp6-srv.rst
src/bin/dhcp4/dhcp4_srv.cc
src/bin/dhcp4/tests/config_parser_unittest.cc
src/bin/dhcp4/tests/fqdn_unittest.cc
src/bin/dhcp6/tests/config_parser_unittest.cc
src/bin/dhcp6/tests/d2_unittest.cc
src/bin/dhcp6/tests/fqdn_unittest.cc
src/lib/dhcpsrv/alloc_engine.cc
src/lib/dhcpsrv/alloc_engine.h
src/lib/dhcpsrv/d2_client_cfg.h
src/lib/dhcpsrv/parsers/base_network_parser.cc
src/lib/dhcpsrv/srv_config.h

src/bin/dhcp4/tests/get_config_unittest.cc
src/bin/dhcp6/tests/get_config_unittest.cc
    regenerated tests

src/lib/dhcpsrv/parsers/simple_parser4.cc
    Removed DDNS params from INHERIT_TO_SUBNET4 list

src/lib/dhcpsrv/parsers/simple_parser6.cc
    Removed DDNS params from INHERIT_TO_SUBNET6 list

src/bin/dhcp6/ctrl_dhcp6_srv.cc
    Removed setting D2ClientCfg fetch function

src/bin/dhcp6/dhcp6_lexer.ll
src/bin/dhcp6/dhcp6_parser.yy
    ddns-send-updates
    ddns-override-no-update
    ddns-override-client-update
    ddns-replace-client-name
    ddns-generated-prefix
    ddns-qualifying-suffix
    - added to DHCP4,SHARED_NETWORK,SUBNET4

    hostname-char-set
    hostname-char-replacement
    - added to SHARED_NETWORK,SUBNET4

src/bin/dhcp6/dhcp6_srv.cc
    Dhcpv6Srv::processClientFqdn()
    Dhcpv6Srv::createNameChangeRequests()
    Dhcpv6Srv::updateReservedFqdn()
    - use cxt.getDdnsParams()

src/bin/dhcp6/json_config_parser.cc
    configureDhcp6Server()
    - use SrvConfig::moveDdnsParams() to move dhcp-ddns parameters
    - handle new "ddns-" globals

src/bin/dhcp6/tests/config_parser_unittest.cc
src/bin/dhcp6/tests/fqdn_unittest.cc
src/bin/dhcp6/tests/get_config_unittest.cc
    Updated tests

src/bin/dhcp4/ctrl_dhcp4_srv.cc
    Removed setting D2ClientCfg fetch function

src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy
    ddns-send-updates
    ddns-override-no-update
    ddns-override-client-update
    ddns-replace-client-name
    ddns-generated-prefix
    ddns-qualifying-suffix
        - added to DHCP4,SHARED_NETWORK,SUBNET4

    hostname-char-set
    hostname-char-replacement
        - added to SHARED_NETWORK,SUBNET4

src/bin/dhcp4/dhcp4_srv.cc

    Dhcpv4Srv::processClientFqdnOption()
    Dhcpv4Srv::processHostnameOption()
    Dhcpv4Srv::assignLease()
        Use scoped DdnsParams from context to make decisions, pass
        into D2ClientMgr functions, and supply hostname sanitizer

src/bin/dhcp4/json_config_parser.cc
    configureDhcp4Server()
    - use SrvConfig::moveDdnsParams() to move dhcp-ddns parameters
    - handle new "ddns-" globals

src/bin/dhcp4/tests/config_parser_unittest.cc
src/bin/dhcp4/tests/d2_unittest.cc
src/bin/dhcp4/tests/dhcp4_test_utils.cc
src/bin/dhcp4/tests/fqdn_unittest.cc
src/bin/dhcp4/tests/get_config_unittest.cc
    Updated and new tests

[914-move-to-c-11-thread-library-in-core-library-code] Upgraded thread/mutex code in the core library to C++11

[168-config-manager-clear-does-not-clear-the-d2-client-config-full-clear] Fixed unit tests using previous CfgMgr clear() behavior

    src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
        Cleaned up failure text

    src/lib/testutils/gtest_utils.h
        Replaced array with vector

src/bin/dhcp4/dhcp4_srv.cc
    Dhcpv4Srv::processRequest()
    Dhcpv4Srv::processRelease()
    Dhcpv4Srv::processDecline()
    Dhcpv4Srv::processInform() - now all call sanityCheck()

src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
    TEST_F(Dhcpv4SrvTest, sanityCheckDiscover)
    TEST_F(Dhcpv4SrvTest, sanityCheckRequest)
    TEST_F(Dhcpv4SrvTest, sanityCheckDecline)
    TEST_F(Dhcpv4SrvTest, sanityCheckRelease)
    TEST_F(Dhcpv4SrvTest, sanityCheckInform) - new tests

src/lib/testutils/gtest_utils.h
    New file with handy new test macros:
        EXPECT_THROW_MSG()
        ASSERT_THROW_MSG()

src/lib/testutils/Makefile.am
    Added new file gtest_utils.h

Added a ChangeLog entry

[755-Kea-DHCP-servers-observations-should-be-reset] implement required changes to dhcp4 and dhcp6 servers

[755-Kea-DHCP-servers-observations-should-be-reset-to-some-initial] changes to way of initial values

[755-Kea-DHCP-servers-observations-should-be-reset-to-some-initial-values-upon-restart-or-reconfiguration] add initialization of all statistisc during set up

src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy
    Added max-row-errors

src/lib/database/database_connection.*
src/lib/database/dbaccess_parser.*
    Added max-row-errors

src/lib/database/tests/dbaccess_parser_unittest.cc
    New tests for max-row-errors

src/lib/dhcpsrv/lease_file_loader.h
    Changed logic value of 0 means unlimited

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::loadLeasesFromFiles() - now uses
    connection parmater value for max-row-errors or 0
    if not specified

src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
    TEST_F(LeaseFileLoaderTest, maxRowErrors4) - new unit test
    to verify max-row-errors operation

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
   TEST_F(MemfileLeaseMgrTest, constructor) - added tests for
   max-row-errors

src/bin/dhcp6/dhcp6_lexer.ll
src/bin/dhcp6/dhcp6_parser.yy
    Added max-row-errors

src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
    TEST_F(LeaseFileLoaderTest, maxRowErrors6) - new unit test
    to verify max-row-errors operation

src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy
    Added max-row-errors

src/lib/database/database_connection.*
src/lib/database/dbaccess_parser.*
    Added max-row-errors

src/lib/database/tests/dbaccess_parser_unittest.cc
    New tests for max-row-errors

src/lib/dhcpsrv/lease_file_loader.h
    Changed logic value of 0 means unlimited

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::loadLeasesFromFiles() - now uses
    connection parmater value for max-row-errors or 0
    if not specified

src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
    TEST_F(LeaseFileLoaderTest, maxRowErrors4) - new unit test
    to verify max-row-errors operation

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
   TEST_F(MemfileLeaseMgrTest, constructor) - added tests for
   max-row-errors

    Minor cleanup

ChangeLog
src/bin/dhcp4/dhcp4_messages.mes
src/bin/dhcp4/dhcp4_srv.cc
src/lib/dns/tests/name_unittest.cc

ChangeLog - added an entry

src/bin/dhcp4/tests/fqdn_unittest.cc
    TEST_F(NameDhcpv4SrvTest, serverUpdateMalformedHostname) - added
    commentary

src/lib/exceptions/isc_assert.h
    commentary changes

src/lib/exceptions/tests/exceptions_unittest.cc
    TEST(IscThrowAssert, checkMessage) - replace use of explicit line number

src/lib/exceptions/isc_assert.h
    New file that defines isc_assert_throw()

src/lib/exceptions/Makefile.am
    added isc_asssert.h

src/lib/exceptions/tests/exceptions_unittest.cc
    TEST(IscThrowAssert, checkMessage) - new test

src/lib/dns/labelsequence.cc
src/lib/dns/name.cc
    Replaced assert() calls with isc_throw_assert() calls

src/lib/dns/tests/name_unittest.cc
    TEST_F(NameTest, unexpectedParseError) - new unit test
    for hostname option content based on fuzz test failure

src/lib/dhcp_ddns/ncr_msg.cc
    Removed unnecessary include of dns/name.h

src/bin/dhcp4/dhcp4_srv.cc
    Dhcpv4Srv::processHostnameOption() - added try catch
    around OptionDataTypeUtil::getLabelCount() call

src/bin/dhcp4/dhcp4_messages.*
    added new log message DHCP4_CLIENT_HOSTNAME_MALFORMED

src/bin/dhcp4/tests/fqdn_unittest.cc
    TEST_F(NameDhcpv4SrvTest, serverUpdateMalformedHostname) -
    renamed test and augmented it to include the packet of death
    produced by fuzz testing.

Added an optional "pattern" parameter to logger output options. It supports
any combination of content described here:

https://log4cplus.sourceforge.io/docs/html/classlog4cplus_1_1PatternLayout.html

src/lib/log/output_option.*
    Added constants to define default patterns:
        OutputOption::DEFAULT_CONSOLE_PATTERN = "%D{%Y-%m-%d %H:%M:%S.%q} %-5p [%c/%i] %m\n";
        OutputOption::DEFAULT_FILE_PATTERN = "%D{%Y-%m-%d %H:%M:%S.%q} %-5p [%c/%i] %m\n";
        OutputOption::DEFAULT_SYSLOG_PATTERN = "%-5p [%c] %m\n";

    OutputOption::pattern_ - new member for conveying pattern string

src/lib/log/logger_manager_impl.*
    LoggerManagerImpl::createConsoleAppender()
    LoggerManagerImpl::createFileAppender()
    LoggerManagerImpl::createSyslogAppender() uses either
    paramater, option.pattern, or the appropriate default pattern

    LoggerManagerImpl::setAppenderLayout() - new, common method to
    set the layout, accepts a pattern string parameter

    LoggerManagerImpl::setConsoleAppenderLayout()
    LoggerManagerImpl::setSyslogAppenderLayout() - deleted

src/lib/process/log_parser.cc
    LogConfigParser::parseOutputOptions() - now supports pattern

src/lib/process/logging_info.*
    LoggingDestination::pattern_  - new member for conveying pattern string

src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy
    Added "pattern" to the parser grammar