1. 23 Oct, 2019 4 commits
    • Francis Dupont's avatar
    • Thomas Markwalder's avatar
      [#900,!561] Updated ChangeLog · 70477262
      Thomas Markwalder authored
      70477262
    • Thomas Markwalder's avatar
      [#900,!561] Addressed review comments · c75a7c10
      Thomas Markwalder authored
      src/lib/dhcp/libdhcp++.cc
          Cleaned up necessary exception decls
      
      src/lib/dhcp/option.h
          Added commentary for SkipThisOptionError
      
      src/lib/dhcp/option_definition.cc
          Cleaned up unnecessary exception decls
      
      src/lib/dhcp/option_string.cc
          Replaced NULL with nul
      
      src/lib/testutils/gtest_utils.h
          Added emissions of exception type name
      c75a7c10
    • Thomas Markwalder's avatar
      [#900,!561] kea-dhcp4/6 now quietly drop empty or all-null string options · a917e4ae
      Thomas Markwalder authored
      src/lib/dhcp/option.h
          class SkipThisOptionError - new exception type
      
      src/lib/dhcp/libdhcp++.cc
          LibDHCP::unpackOptions4()
          LibDHCP::unpackOptions6() - explicitly catches and handles
          SkipThisOptionError expceptions
      
      src/lib/dhcp/option_definition.cc
          OptionDefinition::optionFactory() - now rethrows SkipThisOptionError
      
      src/lib/dhcp/option_int.h
          OptionInt::unpack() - altered ambiguous exception text
      
      src/lib/dhcp/option_int_array.h
          OptionIntArray::unpack() - altered ambiguous exception text
      
      src/lib/dhcp/option_string.cc
          OptionString::unpack() - now throws SkipThisOptionError if option, once
          trimmed, is empty
      
      src/lib/dhcp/tests/option_string_unittest.cc
          Updated tests
      
      src/lib/dhcp/tests/pkt4_unittest.cc
          TEST_F(Pkt4Test, testSkipThisOptionError) - new test
      
      src/lib/dhcp/tests/pkt6_unittest.cc
          TEST_F(Pkt6Test, testSkipThisOptionError) - new test
      
      src/lib/dhcpsrv/tests/cfg_option_unittest.cc
          Updated expected exception text
      
      src/lib/testutils/gtest_utils.h
          Added two macros to emit exception info on throws.
          #define EXPECT_NO_THROW_LOG(statement)
          #define ASSERT_NO_THROW_LOG(statement)
      a917e4ae
  2. 22 Oct, 2019 2 commits
  3. 21 Oct, 2019 1 commit
  4. 18 Oct, 2019 8 commits
  5. 16 Oct, 2019 1 commit
  6. 15 Oct, 2019 8 commits
  7. 14 Oct, 2019 3 commits
  8. 10 Oct, 2019 13 commits
    • Thomas Markwalder's avatar
      [#35,!517] Updated ChangeLog · ac0bbcf6
      Thomas Markwalder authored
      ac0bbcf6
    • Thomas Markwalder's avatar
      [#35,!517] Addressed final review comments · 49ce6286
      Thomas Markwalder authored
      src/lib/dhcpsrv/parsers/simple_parser4.cc
      src/lib/dhcpsrv/parsers/simple_parser6.cc
          Fixed indentations in defaults list
      49ce6286
    • Francis Dupont's avatar
      8a63e7c0
    • Francis Dupont's avatar
    • Francis Dupont's avatar
    • Francis Dupont's avatar
    • Thomas Markwalder's avatar
      [#35,!517] Addressed review comments · 7cfc5d3f
      Thomas Markwalder authored
      Addressed a myriad of minor typos and wording issues.
      
      modified:
      ChangeLog
      doc/examples/kea4/all-keys.json
      doc/examples/kea6/all-keys.json
      doc/sphinx/arm/dhcp4-srv.rst
      doc/sphinx/arm/dhcp6-srv.rst
      src/bin/dhcp4/dhcp4_srv.cc
      src/bin/dhcp4/tests/config_parser_unittest.cc
      src/bin/dhcp4/tests/fqdn_unittest.cc
      src/bin/dhcp6/tests/config_parser_unittest.cc
      src/bin/dhcp6/tests/d2_unittest.cc
      src/bin/dhcp6/tests/fqdn_unittest.cc
      src/lib/dhcpsrv/alloc_engine.cc
      src/lib/dhcpsrv/alloc_engine.h
      src/lib/dhcpsrv/d2_client_cfg.h
      src/lib/dhcpsrv/parsers/base_network_parser.cc
      src/lib/dhcpsrv/srv_config.h
      7cfc5d3f
    • Francis Dupont's avatar
    • Thomas Markwalder's avatar
      [#35,!517] Updated ARM and example confings · 4ac6e5b9
      Thomas Markwalder authored
      Updated:
          doc/examples/kea4/all-keys.json
          doc/examples/kea4/with-ddns.json
          doc/examples/kea6/all-keys.json
          doc/sphinx/arm/dhcp4-srv.rst
          doc/sphinx/arm/dhcp6-srv.rst
      
      Added ChangeLogEntry
      4ac6e5b9
    • Thomas Markwalder's avatar
      [#35,!517] Removed ddns params from INHERIT_TO_SUBNETX lists · 1f60cb9d
      Thomas Markwalder authored
      src/bin/dhcp4/tests/get_config_unittest.cc
      src/bin/dhcp6/tests/get_config_unittest.cc
          regenerated tests
      
      src/lib/dhcpsrv/parsers/simple_parser4.cc
          Removed DDNS params from INHERIT_TO_SUBNET4 list
      
      src/lib/dhcpsrv/parsers/simple_parser6.cc
          Removed DDNS params from INHERIT_TO_SUBNET6 list
      1f60cb9d
    • Thomas Markwalder's avatar
      [#35,!517] Added v6 scope test · f5179e12
      Thomas Markwalder authored
      src/bin/dhcp6/tests/fqdn_unittest.cc
          TEST_F(FqdnDhcpv6SrvTest, ddnsScopeTest)  - new test
      f5179e12
    • Thomas Markwalder's avatar
      [#35,!517] Rework kea-dhcp6 parsing and server · ce14110b
      Thomas Markwalder authored
      src/bin/dhcp6/ctrl_dhcp6_srv.cc
          Removed setting D2ClientCfg fetch function
      
      src/bin/dhcp6/dhcp6_lexer.ll
      src/bin/dhcp6/dhcp6_parser.yy
          ddns-send-updates
          ddns-override-no-update
          ddns-override-client-update
          ddns-replace-client-name
          ddns-generated-prefix
          ddns-qualifying-suffix
          - added to DHCP4,SHARED_NETWORK,SUBNET4
      
          hostname-char-set
          hostname-char-replacement
          - added to SHARED_NETWORK,SUBNET4
      
      src/bin/dhcp6/dhcp6_srv.cc
          Dhcpv6Srv::processClientFqdn()
          Dhcpv6Srv::createNameChangeRequests()
          Dhcpv6Srv::updateReservedFqdn()
          - use cxt.getDdnsParams()
      
      src/bin/dhcp6/json_config_parser.cc
          configureDhcp6Server()
          - use SrvConfig::moveDdnsParams() to move dhcp-ddns parameters
          - handle new "ddns-" globals
      
      src/bin/dhcp6/tests/config_parser_unittest.cc
      src/bin/dhcp6/tests/fqdn_unittest.cc
      src/bin/dhcp6/tests/get_config_unittest.cc
          Updated tests
      ce14110b
    • Thomas Markwalder's avatar
      [#35,!517] Rework kea-dhcp4 parsing and server · 256feda6
      Thomas Markwalder authored
      src/bin/dhcp4/ctrl_dhcp4_srv.cc
          Removed setting D2ClientCfg fetch function
      
      src/bin/dhcp4/dhcp4_lexer.ll
      src/bin/dhcp4/dhcp4_parser.yy
          ddns-send-updates
          ddns-override-no-update
          ddns-override-client-update
          ddns-replace-client-name
          ddns-generated-prefix
          ddns-qualifying-suffix
              - added to DHCP4,SHARED_NETWORK,SUBNET4
      
          hostname-char-set
          hostname-char-replacement
              - added to SHARED_NETWORK,SUBNET4
      
      src/bin/dhcp4/dhcp4_srv.cc
      
          Dhcpv4Srv::processClientFqdnOption()
          Dhcpv4Srv::processHostnameOption()
          Dhcpv4Srv::assignLease()
              Use scoped DdnsParams from context to make decisions, pass
              into D2ClientMgr functions, and supply hostname sanitizer
      
      src/bin/dhcp4/json_config_parser.cc
          configureDhcp4Server()
          - use SrvConfig::moveDdnsParams() to move dhcp-ddns parameters
          - handle new "ddns-" globals
      
      src/bin/dhcp4/tests/config_parser_unittest.cc
      src/bin/dhcp4/tests/d2_unittest.cc
      src/bin/dhcp4/tests/dhcp4_test_utils.cc
      src/bin/dhcp4/tests/fqdn_unittest.cc
      src/bin/dhcp4/tests/get_config_unittest.cc
          Updated and new tests
      256feda6