1. 19 May, 2014 2 commits
  2. 02 May, 2014 1 commit
    • Thomas Markwalder's avatar
      [3382] A bit more clean up. · 785eb5ee
      Thomas Markwalder authored
      I removed todos on regarding use of binary of text.  I could not demonstrate
      any appreciable difference between the two forms and binary results require
      more manual conversion. Performance should be examined as a separte effort.
      785eb5ee
  3. 01 May, 2014 3 commits
    • Thomas Markwalder's avatar
      [3382] Replaced hard coded column types with constants · 7bd56487
      Thomas Markwalder authored
      Replaced hard coded numbers for column types in tagged_statements[]
      initialization.
      Replaced test of error message text for duplicate key violations with
      test of the SQL state code.  This is the recommended mechanism as
      error text can be affected by localization and is subject to content
      change.
      7bd56487
    • Thomas Markwalder's avatar
      [3328] Removed use of PgSqlStatementBind · 6d4aff17
      Thomas Markwalder authored
      Unlike, MySQL, PostgreSQL does not return anything to the caller when
      preparing an SQL statement, rather one uses its text name to execute it.
      PgSqlStatementBind was an unecessary duplication of data already available
      in tagged_statements.  This also resolved the unused member complaint from
      cppcheck regarding TaggedStatement::index.
      
      Also corrected two cppchecks in unit tests.
      6d4aff17
    • Thomas Markwalder's avatar
      [3382] Replaced remaining uses of PgSqlParam with PsqlBindArray · 1c6229d0
      Thomas Markwalder authored
      Replaced use of PgSqlParam with PsqlBindArray throughout.
      Updated commentary and general clean up.
      1c6229d0
  4. 30 Apr, 2014 1 commit
  5. 29 Apr, 2014 1 commit
  6. 02 Apr, 2014 2 commits
  7. 01 Apr, 2014 2 commits
  8. 29 Mar, 2014 1 commit
    • Thomas Markwalder's avatar
      [3080] Replaced use of CURSORs with single step selects · e954809f
      Thomas Markwalder authored
          Changed the SQL statements used to retrieve data to be simple selects
          rather than declared as cursors.  This allows the selects to be executed
          with a single statemen execution, eliminating the need for BEGIN and END
          blocks.
      
          Other minor clean up.
      e954809f
  9. 28 Mar, 2014 1 commit
    • Thomas Markwalder's avatar
      [3080] Fix build and unit test errors · 6adb8b73
      Thomas Markwalder authored
      Initial review and testing revealed build issues, unit test failures,
      and memory leaks.  With these changes it should build and pass unit testing.
      There are still runtime issues to address.
      
      Changed expire column type in lease tables to be "TIMESTAMP WITH TIME ZONE",
      and added methods to convert to and from such fields to LeaseExchange. This
      corrects mismatched time conversion to and from database which was causing unit tests to fail.
      
      Added constructors to PgSqlParam to eliminate use of ".value" initializers and
      to provide a safe, uniform way to create parameters for binary data. Prior to
      this valgrind was reporting invalid reads when vectors were statically cast
      to char*.
      
      Removed superflous BOOST_STATIC_ASSERT and corrected values tested in remaining
      check.
      
      Removed use of "SET AUTOCOMMIT TO" as it is no longer supported in PostgreSQL.
      
      Altered failure logic in PgSqlLeaseMgr::openDatabase() to release connection
      if it is not NULL. This was causing memory leak in unit tests.
      
      Added PQfinish call to createSchema() function to release the connection to fix
      memory leaks during unit testing.
      
      Cleaned most cppcheck complaints.
      6adb8b73
  10. 14 Mar, 2014 1 commit
  11. 12 Mar, 2014 3 commits
  12. 11 Mar, 2014 2 commits