GitLab

 - Removed unused constant. Failed to compile with Xcode 5.1

I removed todos on regarding use of binary of text.  I could not demonstrate
any appreciable difference between the two forms and binary results require
more manual conversion. Performance should be examined as a separte effort.

Replaced hard coded numbers for column types in tagged_statements[]
initialization.
Replaced test of error message text for duplicate key violations with
test of the SQL state code.  This is the recommended mechanism as
error text can be affected by localization and is subject to content
change.

Unlike, MySQL, PostgreSQL does not return anything to the caller when
preparing an SQL statement, rather one uses its text name to execute it.
PgSqlStatementBind was an unecessary duplication of data already available
in tagged_statements.  This also resolved the unused member complaint from
cppcheck regarding TaggedStatement::index.

Also corrected two cppchecks in unit tests.

Replaced use of PgSqlParam with PsqlBindArray throughout.
Updated commentary and general clean up.

Initial use of PsqlBindArray, working for v6.

Initial use of PsqlBindArray, working for v4.

Suppressed an unused structure member complaint in dhcpsrv/psql_lease_mgr.cc
This code is going to get a makeover under 3382 and it will be more properly
addressed then.

PgSqlLeaseMgr::openDatabase now sets conn_ to NULL after calling PQfinish.
PgSqlLeaseMgr constructor, moved member inits to the initializer list
Fixed exception text.

The procedure for configuring Postgresql backend in bind10-guide
was updated such that database tables are created and thus owned
by the Kea user rather than the postgres user.

Cleaned up some logging issues and minor cosmetics.

    Changed the SQL statements used to retrieve data to be simple selects
    rather than declared as cursors.  This allows the selects to be executed
    with a single statemen execution, eliminating the need for BEGIN and END
    blocks.

    Other minor clean up.

Initial review and testing revealed build issues, unit test failures,
and memory leaks.  With these changes it should build and pass unit testing.
There are still runtime issues to address.

Changed expire column type in lease tables to be "TIMESTAMP WITH TIME ZONE",
and added methods to convert to and from such fields to LeaseExchange. This
corrects mismatched time conversion to and from database which was causing unit tests to fail.

Added constructors to PgSqlParam to eliminate use of ".value" initializers and
to provide a safe, uniform way to create parameters for binary data. Prior to
this valgrind was reporting invalid reads when vectors were statically cast
to char*.

Removed superflous BOOST_STATIC_ASSERT and corrected values tested in remaining
check.

Removed use of "SET AUTOCOMMIT TO" as it is no longer supported in PostgreSQL.

Altered failure logic in PgSqlLeaseMgr::openDatabase() to release connection
if it is not NULL. This was causing memory leak in unit tests.

Added PQfinish call to createSchema() function to release the connection to fix
memory leaks during unit testing.

Cleaned most cppcheck complaints.

 - UPDATE_LEASE6 query is now working
 - Added bunch of new unit-tests

 - Added support for 3 new fields, altered schema
 - Fixed bug where empty HWADDR was throwing exception
 - Several clean-ups

 - patch contributed by David Carlier (thanks!)
 - updated to current master
 - fixed compliation issues
 - written developer's guide (pgsql setup steps)
 - many smaller changes
 - still WIP