GitLab

To allow for future optimization, the RRset pointer classes now
point to the base of the RRset inheritance hierarchy.

As it is tightly coupled with the previous try statement.

The server is a separate entity from the developer's collective mind,
which, at last for the time being, is not considered sentient. Therefore
the word "we" is not appropriate and the server should be described in
third person.

removed before releasing the wrapper code.  Compiler will detect if
any of them is forgotten to be cleaned up.

(there doesn't seem to be need for updating the python doc)

as suggested in review.  hid the concrete derived class in the implementation.
adjusted tests accordingly.

It happens to work already.

If it is not one of the "known to be OK" exceptions, we abort.

we should either/both consider revisiting the interface so we avoid the
issue as a result or require higher version of boost.  but for now this
should be okay.

So we can distinguish the errors.

fixing bugs like case-sensitivity or corner cases for empty salts.
provided more detailed tests and documentation.

not directly related but would be helpful for the purpose of the branch.

the change introduced in this branch breaks the assumption of the
callback function used in the test code.

testing a single flag.  it's stricter and probably a better test.

in the database zone finder.  right now it's a TODO and the current
implementation is a kind of workaround.

(which was C++ version only); corrected the return value description of
find_all() which was accidentally broken.

It caused the pycompile script to fail

(they should have succeeded in the original version of implementation)

now the test passed.

separate RRsets.  As noted in the previous comment the previous behavior
was okay in practice within the expected restriction of the current
implementation, but as we are probably going to accept more generic forms
of input it would be prudent to fix it at this timing.